* Re: [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM [not found] <1766C9E1207ACAEE.10073@groups.io> @ 2023-06-22 5:07 ` Kun Qin 2023-06-22 7:06 ` Sami Mujawar 0 siblings, 1 reply; 3+ messages in thread From: Kun Qin @ 2023-06-22 5:07 UTC (permalink / raw) To: devel Cc: Hao A Wu, Liming Gao, Jian J Wang, Leif Lindholm, Ard Biesheuvel, Sami Mujawar Hi Arm and MdeModule package maintainers, This patch series has been sent out for almost 2 weeks without any reviews. Could you please provide feedback on the change when you have a chance? Any input is appreciated. Regards, Kun On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 > > As of today, there has been a void in the variable service in PEI phase > on ARM systems that support PEI phase and standalone MM hosted variable > service. > > This change adds the support through: > 1. Add MM communication services in PEI phase for ARM platforms. This > module is based on SMC calls to standalone MM environments, similar to > "ArmPkg/Drivers/MmCommunicationDxe". > > 2. A service module that installs `gEfiPeiReadOnlyVariable2PpiGuid` based > on step 1. Note that this driver will not have special dependency on ARM > specific code, thus will be ideally added to MdeModulePkg. > > Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1 > > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Sami Mujawar <sami.mujawar@arm.com> > > Kun Qin (2): > ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI > MdeModulePkg: Variable: Introduce MM based variable read service in > PEI > > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 178 +++++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c | 381 ++++++++++++++++++++ > ArmPkg/ArmPkg.dsc | 2 + > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h | 76 ++++ > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf | 41 +++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h | 134 +++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf | 43 +++ > 8 files changed, 856 insertions(+) > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM 2023-06-22 5:07 ` [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM Kun Qin @ 2023-06-22 7:06 ` Sami Mujawar 2023-06-22 18:19 ` Kun Qin 0 siblings, 1 reply; 3+ messages in thread From: Sami Mujawar @ 2023-06-22 7:06 UTC (permalink / raw) To: Kun Qin, devel@edk2.groups.io Cc: Hao A Wu, Liming Gao, Jian J Wang, Leif Lindholm, Ard Biesheuvel, nd Hi Kun, Apologies for the delay in reviewing. I will take a look at this series shortly and get back. Regards, Sami Mujawar On 22/06/2023, 06:07, "Kun Qin" <kuqin12@gmail.com <mailto:kuqin12@gmail.com>> wrote: Hi Arm and MdeModule package maintainers, This patch series has been sent out for almost 2 weeks without any reviews. Could you please provide feedback on the change when you have a chance? Any input is appreciated. Regards, Kun On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 <https://bugzilla.tianocore.org/show_bug.cgi?id=4464> > > As of today, there has been a void in the variable service in PEI phase > on ARM systems that support PEI phase and standalone MM hosted variable > service. > > This change adds the support through: > 1. Add MM communication services in PEI phase for ARM platforms. This > module is based on SMC calls to standalone MM environments, similar to > "ArmPkg/Drivers/MmCommunicationDxe". > > 2. A service module that installs `gEfiPeiReadOnlyVariable2PpiGuid` based > on step 1. Note that this driver will not have special dependency on ARM > specific code, thus will be ideally added to MdeModulePkg. > > Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1 <https://github.com/kuqin12/edk2/tree/arm_var_pei_v1> > > Cc: Hao A Wu <hao.a.wu@intel.com <mailto:hao.a.wu@intel.com>> > Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>> > Cc: Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com>> > Cc: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>> > Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>> > > Kun Qin (2): > ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI > MdeModulePkg: Variable: Introduce MM based variable read service in > PEI > > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 178 +++++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c | 381 ++++++++++++++++++++ > ArmPkg/ArmPkg.dsc | 2 + > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h | 76 ++++ > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf | 41 +++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h | 134 +++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf | 43 +++ > 8 files changed, 856 insertions(+) > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM 2023-06-22 7:06 ` Sami Mujawar @ 2023-06-22 18:19 ` Kun Qin 0 siblings, 0 replies; 3+ messages in thread From: Kun Qin @ 2023-06-22 18:19 UTC (permalink / raw) To: Sami Mujawar, devel@edk2.groups.io Cc: Hao A Wu, Liming Gao, Jian J Wang, Leif Lindholm, Ard Biesheuvel, nd Thanks a lot, Sami! On 6/22/2023 12:06 AM, Sami Mujawar wrote: > Hi Kun, > > Apologies for the delay in reviewing. > I will take a look at this series shortly and get back. > > Regards, > > Sami Mujawar > > On 22/06/2023, 06:07, "Kun Qin" <kuqin12@gmail.com <mailto:kuqin12@gmail.com>> wrote: > > > Hi Arm and MdeModule package maintainers, > > > This patch series has been sent out for almost 2 weeks without any reviews. > > > Could you please provide feedback on the change when you have a chance? > Any input is appreciated. > > > Regards, > Kun > > > On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 <https://bugzilla.tianocore.org/show_bug.cgi?id=4464> >> >> As of today, there has been a void in the variable service in PEI phase >> on ARM systems that support PEI phase and standalone MM hosted variable >> service. >> >> This change adds the support through: >> 1. Add MM communication services in PEI phase for ARM platforms. This >> module is based on SMC calls to standalone MM environments, similar to >> "ArmPkg/Drivers/MmCommunicationDxe". >> >> 2. A service module that installs `gEfiPeiReadOnlyVariable2PpiGuid` based >> on step 1. Note that this driver will not have special dependency on ARM >> specific code, thus will be ideally added to MdeModulePkg. >> >> Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1 <https://github.com/kuqin12/edk2/tree/arm_var_pei_v1> >> >> Cc: Hao A Wu <hao.a.wu@intel.com <mailto:hao.a.wu@intel.com>> >> Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>> >> Cc: Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com>> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>> >> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>> >> Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>> >> >> Kun Qin (2): >> ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI >> MdeModulePkg: Variable: Introduce MM based variable read service in >> PEI >> >> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 178 +++++++++ >> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c | 381 ++++++++++++++++++++ >> ArmPkg/ArmPkg.dsc | 2 + >> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h | 76 ++++ >> ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf | 41 +++ >> MdeModulePkg/MdeModulePkg.dsc | 1 + >> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h | 134 +++++++ >> MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf | 43 +++ >> 8 files changed, 856 insertions(+) >> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c >> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c >> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h >> create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf >> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h >> create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf >> > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-22 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1766C9E1207ACAEE.10073@groups.io>
2023-06-22 5:07 ` [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM Kun Qin
2023-06-22 7:06 ` Sami Mujawar
2023-06-22 18:19 ` Kun Qin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox