From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 45A70203525E3 for ; Tue, 24 Oct 2017 05:07:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60268B649; Tue, 24 Oct 2017 12:10:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 60268B649 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-52.rdu2.redhat.com [10.10.120.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5EFD60BCB; Tue, 24 Oct 2017 12:10:45 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org, leif.lindholm@linaro.org Cc: daniel.thompson@linaro.org References: <20171021131049.23844-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <0f440c7d-f590-57c1-9f34-f9c8a54c81d6@redhat.com> Date: Tue, 24 Oct 2017 14:10:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171021131049.23844-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 24 Oct 2017 12:10:47 +0000 (UTC) Subject: Re: [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 12:07:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/21/17 15:10, Ard Biesheuvel wrote: > To make it easier for power users to provision a 'desktop' system [as > opposed to a VM or server] from scratch, introduce a driver that adds > boot options to the boot menu that can launch network installers over > HTTP straight off the Internet. > > Currently, this only supports the 'mini.iso' style netboot installers > that Debian/Ubuntu provide: larger images that need to be mounted by > the installer when running under the Linux kernel are only supported > on ACPI systems with support for the NFIT table, and this was enabled > only recently (Linux v4.14) for arm64. For DT boot, there is currently > no way at all to expose ramdisks created by UEFI as block devices in > Linux. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > > Posted as an RFC because: > a) Where does this belong? Surely not in ArmPkg but I had to put it somewhere > b) Currently, the way the options are created results in them taking priority > if no real boot options were set (i.e., for GRUB). > c) Is there a use case for downloading 300-500 MB installers off the Internet > for a one shot installation? Or should we just stick to the mini.iso flavors. > d) Did I miss any distros we may care about? > > ArmPkg/Drivers/OsInstallerMenuDxe/OsInstallerMenuDxe.c | 228 ++++++++++++++++++++ > ArmPkg/Drivers/OsInstallerMenuDxe/OsInstallerMenuDxe.inf | 42 ++++ > 2 files changed, 270 insertions(+) https://github.com/tianocore/tianocore.github.io/wiki/HTTP-Boot If the HTTP Boot stack is built into the firmware, it is possible to navigate to: Device Manager Network Device List MAC:xx:xx:xx:xx:xx:xx HTTP Boot Configuration On this dialog, we have - "Input the description" - "Internet protocol" - "Boot URI" The help text says, "A new Boot Option will be created according to this Boot URI". Therefore, I think the functionality already exists (for power users that are willing to pick a NIC and to type a URL, anyway). Is the goal of your patch to provide more convenience, or to provide the base functionality? Also, I think that creating baked-in boot options belongs with the platform's PlatformBootManagerLib instance, not a separate UEFI_DRIVER module. (That's where the UEFI shell boot option is created already, for example.) Platform BDS is responsible for connecting NICs (none of them, some of them, all of them -- and recursively or non-recursively), so if you want to look at specific NIC-related protocol instances, you know exactly when to look. If the goal is really to save the user the typing of one URL, then I suggest to implement this feature as a small, standalone library, under edk2-platforms; with a sole API called CreateOsInstallerBootOptions(). Then, interested platforms may invoke CreateOsInstallerBootOptions() in their PlatformBootManagerLib instances. (This would be similar to: OvmfPkg/Include/Library/QemuBootOrderLib.h OvmfPkg/Library/QemuBootOrderLib/ and how we call SetBootOrderFromQemu() in ArmVirtPkg's and OvmfPkg's PlatformBootManagerLib instances.) Perhaps you can introduce the lib class, with a Null instance, in edk2 as well; and then call the new API in ArmPkg/Library/PlatformBootManagerLib at the right spot. (I think adding the API / lib class to edk2 makes sense, but I also think the lib instance with the actual URLs should live under edk2-platforms, somewhere.) Just my two cents. Thanks! Laszlo