From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.2788.1586488743205879975 for ; Thu, 09 Apr 2020 20:19:03 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) IronPort-SDR: U4ydD8wLL6+zZYriOOV6zgCkSZNBYXypUFCXL3czkCKENxOC8to7yIhTI205RJCifwsPuEGx+d tA5XSqPR1rdg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 20:19:03 -0700 IronPort-SDR: Y3CTboMgwQiGJXmuuuDdq9RZURG8RBJNmkQ6oF4FzdsPbW+umURnM2SkKnxfS/JQDW2PXLA/Yk yClae3LpIl6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="452251264" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 09 Apr 2020 20:19:02 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 20:19:02 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 10 Apr 2020 11:19:00 +0800 Received: from shsmsx604.ccr.corp.intel.com ([10.109.6.214]) by SHSMSX604.ccr.corp.intel.com ([10.109.6.214]) with mapi id 15.01.1713.004; Fri, 10 Apr 2020 11:19:00 +0800 From: "Liming Gao" To: "Liu, Zhiguang" , "devel@edk2.groups.io" , "pierre.gondois@arm.com" CC: "Kinney, Michael D" , "Sami.Mujawar@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions Thread-Index: AQHWBnCbBc73B4D1PEeFmUvDg9QUq6hxH+IAgACgweA= Date: Fri, 10 Apr 2020 03:19:00 +0000 Message-ID: <0f5b368983d64a01af925ef4dda4e5d2@intel.com> References: <20200330085238.43376-1-pierre.gondois@arm.com> <7e9ab4a9321b4315909c34df943763fa@intel.com> In-Reply-To: <7e9ab4a9321b4315909c34df943763fa@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Liu, Zhiguang > Sent: Friday, April 10, 2020 9:44 AM > To: devel@edk2.groups.io; pierre.gondois@arm.com > Cc: Kinney, Michael D ; Gao, Liming ; Sami.Mujawar@arm.com; nd@arm.com > Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCod= e definitions >=20 > Reviewed-by: Zhiguang Liu >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Pi= erreGondois > Sent: Monday, March 30, 2020 4:53 PM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Kinney, Michael D ; Gao, Liming > ; Sami.Mujawar@arm.com; nd@arm.com > Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode de= finitions >=20 > From: Pierre Gondois >=20 > The ACPI specification, version 6.3, January 2019, > defines the Named Objects Encoding for FieldElements > in section '20.2.5.2 Named Objects Encoding'. > FieldElements can be one of the following: > NamedField | ReservedField | AccessField | > ExtendedAccessField | ConnectField >=20 > Some of these keywords are starting with an opcode, > allowing to identify their type. > E.g.: ReservedField :=3D 0x00 PkgLength >=20 > This patch adds these FieldElement opcodes definitions to > the list of AML Opcode definitions. >=20 > Signed-off-by: Pierre Gondois > --- >=20 > The changes can be seen at https://github.com/PierreARM/edk2/commits/695= _Add_FieldElement_OpCode_v1 >=20 > Notes: > v1: > - Add AML Field Element OpCodes [Pierre] >=20 > MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/= IndustryStandard/AcpiAml.h > index 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a04379362= 843473cac5ea5856 100644 > --- a/MdePkg/Include/IndustryStandard/AcpiAml.h > +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h > @@ -168,4 +168,12 @@ > #define AML_EXT_BANK_FIELD_OP 0x87 > #define AML_EXT_DATA_REGION_OP 0x88 >=20 > +// > +// FieldElement OpCode > +// > +#define AML_FIELD_RESERVED_OP 0x00 > +#define AML_FIELD_ACCESS_OP 0x01 > +#define AML_FIELD_CONNECTION_OP 0x02 > +#define AML_FIELD_EXT_ACCESS_OP 0x03 > + > #endif > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20