From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.40]) by mx.groups.io with SMTP id smtpd.web09.25098.1659964974738243410 for ; Mon, 08 Aug 2022 06:22:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=HgkF2MYQ; spf=pass (domain: arm.com, ip: 40.107.8.40, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GizEETgdGG0fqoP2Z5BRe4idmHhiniE38QHT9ygu2BBXDb+dwWdmcwrMnobDiogoTEW+oF/x/+IBvoe5CvvIc6lYNNXLWGG7s1gp0Z2gqijPPW1Qy42II2DgGBicsv4Wecare+XQ7myDP2ZlQZGRYRZ0OWzfESKTHiMULY2A/c2V7dlXLK2tBi3wyjOzYFlon4RXN8oDPv9I16d6ya6k5Ks4gpUnBEbRHpYJoVMEZieBO6A3eEJla/LSoiczwN5IjzxvD4vp07LYkPio59cb4SjLf7JXviVudafukh2TzPE4Zxiq/T2uJ/SqcHgV9nMymH6NzmJHwui2BPTkYrleyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JNH6mfHtzbT2K79LVSN+q8bdoHs9vDjsG4ZKzXJvpBI=; b=d5LYGKYuvWSmBvtKq7ts+L3D3rMj38IfdtovHRChNS1mqp1Skk9AewuQSW5EnDoUnlRk4KFAjGRWYBGYFPXOi3hYjUJkGJccDt0qCsIqiBAjbbmN+Myhbr53QZlRc8CY7esGJwlfO4gUC2U2EllTbP0d3w6kxyIJXtQ0nOukImn77KgHZhWAWoMobdKKRoEye9GP6bcrkzsE1n5ZhUN+99nF1+ZIIvVwFNLfHQupUl/LORzm24pxNsh1M8rpMrKVK9OSP27ahKz/j6ZRSjDpKRLznGlZwrX2DuAeFATPI7p/TUg/aehveZnIiMJkefFFuleAWeOTBJHVdJdlwExbuQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNH6mfHtzbT2K79LVSN+q8bdoHs9vDjsG4ZKzXJvpBI=; b=HgkF2MYQbCgN1mbp80yTM5PAM+XwVxbTcvLtoqkf2XEg6pdPBZtlsP+OFuXQAf1Nrwwpq2mR4gck0d/NcBpuTLvpZtR9BxYeMsmFFEnIcbJ0c2GMWQ0EopK2B/H+GuB35/IpNgWauDRDNTGFX8uJ4qPPgmeDCJ4OpFIvbesnMCA= Received: from AM5PR0701CA0055.eurprd07.prod.outlook.com (2603:10a6:203:2::17) by VE1PR08MB4878.eurprd08.prod.outlook.com (2603:10a6:802:a7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Mon, 8 Aug 2022 13:22:50 +0000 Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::3a) by AM5PR0701CA0055.outlook.office365.com (2603:10a6:203:2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.9 via Frontend Transport; Mon, 8 Aug 2022 13:22:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 13:22:50 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Mon, 08 Aug 2022 13:22:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3476bbc09e05df3f X-CR-MTA-TID: 64aa7808 Received: from b74235ec1cef.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E72E21D-3DE8-479B-8F32-EA6BEB6ACA7D.1; Mon, 08 Aug 2022 13:22:39 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b74235ec1cef.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Aug 2022 13:22:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9v2tL1HUYp4EIz9BqMfDL5/ZNnvH7oFBpYnXux43uScF62RTM8rWyUKMbXyOi2gMHqfr/AqaI7Zin0Rtv0zC8lyIrxMF/SgqiD9XewfTRfW3JzWm3Cgo3vJ+2C0VjkOP7WWm4zEs8jNvreVNBPctrKEKZ6VYfB5GpBppRR84Bop8QFc+evMlEh72SgxP+dzvdHE94UBq0Q9cAreMvAI+4M/VEyDyizbEfaOlH3pLBCuAYMjMCFD4BK1Jug/pT6attS+LiVxA0fqPanmUVgIkaZ0nxRQ63j+OL0kuTOI4jHD1brSEXf+UKK0TPZN2Jlt6mZvIE//MgUkzxXi+hX/nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JNH6mfHtzbT2K79LVSN+q8bdoHs9vDjsG4ZKzXJvpBI=; b=dq8yhUGqtqOZOQPkSJiSwLLbte8Fp38yGJY+lU3awKF2ZH02rQCr22ZSkt8Ng2mYEhHkjavWlL5N0fRhADrvvJgvQvgiyPiTUFspyWXRb02ZnrfNfivtaj+wKZ5j29rO5OzxIqSdJjbtDCbFZyOhLxXu8FO8raOvB0LtHH7a0oTnXl0SaXI2yId9pVzZbHQTY5RpbVpQFc1OITj8p1H4DqZ2BpWOefnfCeCJ3xMwKr+4g/9N3NglWHOMTDkZZmK0RlKK6s+ktSeHikqIB4he6Mx/lvLACjJGXE/sn1GivZxSnrM77AZL21W54LLydzFAvAv5efMcs+i1te/fXevKAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNH6mfHtzbT2K79LVSN+q8bdoHs9vDjsG4ZKzXJvpBI=; b=HgkF2MYQbCgN1mbp80yTM5PAM+XwVxbTcvLtoqkf2XEg6pdPBZtlsP+OFuXQAf1Nrwwpq2mR4gck0d/NcBpuTLvpZtR9BxYeMsmFFEnIcbJ0c2GMWQ0EopK2B/H+GuB35/IpNgWauDRDNTGFX8uJ4qPPgmeDCJ4OpFIvbesnMCA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB7946.eurprd08.prod.outlook.com (2603:10a6:10:3ca::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Mon, 8 Aug 2022 13:22:37 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 13:22:36 +0000 Message-ID: <0f622281-79ad-f751-3595-46279e5e3c63@arm.com> Date: Mon, 8 Aug 2022 14:22:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config To: Kun Qin , devel@edk2.groups.io Cc: Alexei Fedorov , Joe Lopez , Pierre Gondois , "nd@arm.com" References: <20220731053727.536-1-kuqin12@gmail.com> <20220731053727.536-7-kuqin12@gmail.com> From: "Sami Mujawar" In-Reply-To: <20220731053727.536-7-kuqin12@gmail.com> X-ClientProxiedBy: LO2P265CA0376.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::28) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 73de53b2-6456-488e-bf0d-08da794117ee X-MS-TrafficTypeDiagnostic: DU0PR08MB7946:EE_|AM5EUR03FT058:EE_|VE1PR08MB4878:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LwMkJheRhh+jAtDAe1vepn4rcaCUREwjiJoM3b4Yy/ywbIDGn36avHTq1ViqQHaum4IJsHQwzgHILOQJ6GzjE1JGEXHm/L4vq2JQF8IadG9i0d6/WXOol3NQRoWrCQnPy7JWuBByqwTgvuJNS8FlorWJGS46fLqDC0e+qmrIF9Yoo9b+VmTkawJikYN2/DSxm1F5nUC2hQdU2Oir2tpO7n0LBU0liJP+xPJkRFQvciVg3Gz1Ikn9JpSTaxT5WN4WD7kDWUwFteO0AYV0p4BxrZDCsdMgCcG4W1vqqK0Xa+uClwgS/9/IEL3fb4QWkYYXA2kC1dvXFnJmeF9TJZgE7t3l28gwjhfvex4GWYSDkvyS2nDrR/sm1sfkIuLBLdTZ7pUdCk8wZyqKRJ+FKSEONZh6djSWxgGNdv9tomT9RBTs+7GXFbV/rNe3vmRA/+bUqxbJPA1l3/LRDHpALaIZ4pZalGjn6pAfWc6bSEW0r5W6bFWPfBEDCGQKoNrPEgnO1FGba0IzGAe1oB2Q/ijZ8YrULtKm9xl3YyIurMFZycFUsvqgAtFlYJkKNxyJAGPH1EjxVJfazOpIcMaRB4qUXcKrxF2UgRmN65UjE4ep+o8Qkez3OdqWQbMQUL0zHTalMvhklxvR/7GOm84ao3Kr85KwaPHmYVLznYcdcz0gl6UMPlbwirHtP+23uw22KoM2CdGSzOep9Q6WohchmFAFmmg1B6SB5URegbBJwyjV3FHOiQDZgle8c8qNcz6KEnSLZm+JeSn/UPzjpBd73r/PFQKJaQnTQ0i+LHs0jWPDwgQZiu4azHlLPt7pym1DPwYSaafn5vh5zJDfIFc6aahlNSWF8AdNJNHrMFJnMP5Lw0+oBF3VEs6aaOyjFh1xbAxW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(316002)(8676002)(4326008)(36756003)(44832011)(66476007)(66556008)(5660300002)(45080400002)(6486002)(966005)(66946007)(2906002)(54906003)(478600001)(86362001)(38100700002)(2616005)(6512007)(6506007)(53546011)(26005)(31696002)(41300700001)(31686004)(8936002)(186003)(213903007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7946 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 62e8c788-a5fd-4421-f8e0-08da79410f94 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MGd6KUoBAzDdT8WHrpLRv/0Q+c4/pTjNrXh6Bfl10M+ihDsVSWd0HtPRaMECPEKBPQZI8aYiTq5LObeHhESUG2hGgJKXa+qMMpmtgPxQ/9Nz4tl74AYI6I7VzbU0xsihBj7yHIOY4SGwNrI0exU0Yw0QtVdOERF95+nJylfDRtcGGLtzsXyrQaTa1AEiaA/zNUM0bJUIEnnIfpN04ELLbNkDpIT5LrSxdjPeg3zc8o6K8ZQlS1cslsu3jVcGAqgnBo86YwTqT5O5UbPpusqdh4MzTRN/jee7fTbbjCQBdAumD9KTHoDP3qFixRTVnnOIR2RLhUN6YO+N6KUGmrN2lgy++WBv2Vn8L3lleYMg1LbBw/lL0LHmiAOdBAv/97vAT17fMvYoNSQReJ7Is8Z2i3FuA+8QD7YLqaWuLBCQUiMqBdsqVfwG7fg9bSK1mh3yQqF4ddnGgz5GxUY02OLQYJRawmITIXbyZKNnU+3I97IppR7yjyAxMhmLHndr/w2cJjh5wPHteKkS0zfnMhliLuhhm7i5rPKb+aWhD99V3UNQ5aaSUyteaX33M+kcE8iZ96qVecaLjB8Ipz/dHJz8tCa0D632vrl6QMOqGE7JsvOk9pih/MEFotbC0FVDEpM542fn7o75uFKPAZpzOV2UbamzjChu6RcHZkRREq/IIi1qY6lrJLzEbu4hHlBSB6NzPm8oTU4r44GWG30Ixi+rGeloxj+Ldxpm/xgtT8Knxspd4PkmuR/ivAMwKF24HXdVKBYyXH0zSWJhs541qq7VBqtvkx0fLl52YvVHRFX+2I0NkZuheLvc/BnJcTfXHaUlkP6/dPuIDJOnGjd+r4MTPfFhlQs9drBT4slymNw+5z6hdd684ctdK+hbeTxWgveZXstqplhEQ8L6VGmjCZtX8g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966006)(40470700004)(36840700001)(5660300002)(70206006)(8676002)(4326008)(70586007)(316002)(54906003)(86362001)(31696002)(36756003)(82310400005)(40480700001)(478600001)(40460700003)(44832011)(8936002)(2906002)(36860700001)(82740400003)(31686004)(81166007)(356005)(41300700001)(26005)(53546011)(6506007)(6512007)(45080400002)(966005)(336012)(186003)(6486002)(2616005)(47076005)(213903007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 13:22:50.7085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73de53b2-6456-488e-bf0d-08da794117ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4878 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kun, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 31/07/2022 06:37 am, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 > > This change added a switch case handling for PCI_SS_CONFIG during SSDT > generation. This will allow PCI config case return EFI_SUCCESS instead of > EFI_INVALID_PARAMETER. > > Cc: Sami Mujawar > Cc: Alexei Fedorov > > Co-authored-by: Joe Lopez > Signed-off-by: Kun Qin > Reviewed-by: Pierre Gondois > --- > > Notes: > v2: > - Added Reviewed-by tag [Pierre] > > v3: > - No change > > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > index 658a089c8f1f..740271b504ca 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > @@ -603,6 +603,11 @@ GeneratePciCrs ( > ); > > break; > > > > + case PCI_SS_CONFIG: > > + // Do nothing > > + Status = EFI_SUCCESS; > > + break; > > + > > default: > > Status = EFI_INVALID_PARAMETER; > > } // switch >