From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.67; helo=mail-wr1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D062C21195BFB for ; Mon, 7 Jan 2019 02:08:54 -0800 (PST) Received: by mail-wr1-f67.google.com with SMTP id c14so42615586wrr.0 for ; Mon, 07 Jan 2019 02:08:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hsz8FMqOxCsZnRnACsjxmUWDYYW05FiZoRrqg2xzDIA=; b=JBHqP8+ByVzXpDJ4tQMJmp9FejcQOuOmcoP0MfZY09UTvRWST5CG/kqfLLmsIgUkpI uKciblCph6cztngNuBNfD+hOWiU3wMNryyAPTCRZYnRhu8houNrtkrrfbNUtT9YvDgMB gCWqyMzB54KB87pHeDkPv8LeZXsy9jAgBlDzYhJxcYYT16LsvObGaGu8IEnHyUT8WqQX rKAU2kaMmnmfGi0fSa8JGmMBntFkpYWLCpyD3kt74VhFd0EKBoKbQjx4nm/8JEKY4ut7 684WWwNIYSvnaYPr9nmqrL2Bf85BPI0hmIjw9ERm+eW2KB0ZYjGJwL60jNwQD1t9tHLv AreQ== X-Gm-Message-State: AJcUukdhL/jiHrPbMZKLoMQpyHPoYjV2LRX5Ok3sGljh9NV97p40UAND FER3oHAM3sWtMDtZxE6wEBYt8A== X-Google-Smtp-Source: ALg8bN61CvFxz7Bi6+nr5bhiOPiG6w9e+VpoFCy8EJZPUy7++UuDfcLotIzgpZ6Lt2fKz1s8BvWxrA== X-Received: by 2002:adf:c888:: with SMTP id k8mr55223277wrh.6.1546855733309; Mon, 07 Jan 2019 02:08:53 -0800 (PST) Received: from [10.201.33.118] ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id f2sm44724687wru.14.2019.01.07.02.08.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 02:08:52 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: liming.gao@intel.com References: <20190107065541.1854-1-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <0f842e4a-3ca6-371e-f527-8368a9a091e5@redhat.com> Date: Mon, 7 Jan 2019 11:08:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190107065541.1854-1-ard.biesheuvel@linaro.org> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 10:08:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, On 1/7/19 7:55 AM, Ard Biesheuvel wrote: > GCC for 32-bit ARM chokes on .aslc files when running with LTO > enabled. Since LTO has no benefit whatsoever here, just disable > it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index f7eb87af14c2..e68cfd9a4997 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os > *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy > > *_GCC5_ARM_ARCHCC_FLAGS = -mthumb > -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto Why not add it globally to GCC5_ASLCC_FLAGS? > *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS) > *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS) > *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS) >