Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

["Laszlo Ersek" <lersek@redhat.com>]

On 9/13/23 13:02, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
>> it. Original explanation by Drew Jones.
>>
> 
> Out of curiosity: how is this different from the -no-acpi QEMU command
> line option?

They are the same thing:

https://www.qemu.org/docs/master/about/deprecated.html#no-acpi-since-8-0

"The -no-acpi setting has been turned into a machine property. Use
-machine acpi=off instead."

That is, "-no-acpi" has been deprecated since QEMU 8.0.

Cheers
Laszlo

> 
> 
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Jones <ajones@ventanamicro.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
>> index 193e4afe8dee..1dba1a26af2d 100644
>> --- a/OvmfPkg/RiscVVirt/README.md
>> +++ b/OvmfPkg/RiscVVirt/README.md
>> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>>          -device virtio-blk-device,drive=hd0 \
>>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>>
>> +    Note: the `acpi=off` machine property is specified because Linux guest
>> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
>> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
>> +    yourself.
>> +
>>  ## Test with your own OpenSBI binary
>>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108598): https://edk2.groups.io/g/devel/message/108598
Mute This Topic: https://groups.io/mt/101334265/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-