From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4AAF6AC0CE7 for ; Wed, 28 Feb 2024 12:53:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YXbQzuJwn1t9oepam5rhERMfXqCJX9o59zLuxs297ng=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709124832; v=1; b=XhbGLyVMw6o5lCZJU0FWEF7t3D6DldQIWk48VJgjiXVfPEmRjr25ZOM1D+aQWN1gxXsOJo/v FRX3IxKDOpMOCDIHNpZ0c02ZSSRUpzgKZjWw5ImTMBNuNJzgwFqydUtyZkUiLiQ3t+UgrRer3yr 8m1z/OSEyM/BedDY72YodKJA= X-Received: by 127.0.0.2 with SMTP id TSgWYY7687511x5Dv1Awl8P9; Wed, 28 Feb 2024 04:53:52 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.54]) by mx.groups.io with SMTP id smtpd.web10.12216.1709124831078495300 for ; Wed, 28 Feb 2024 04:53:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOrKbA1tIC0yO4tGqUp0+NH/Z2rfrDJdj5Y21GORQlqfS/7ll7afGPb+K6kRsffdb5P7vf5Aitl41WwBv2N96NkICc9yALHoSp1xcO+VdOTh5k9Msh3j/OlK3xavXmkTqNLXVTCI46k3qTHWZv/VbVk/0vZsOv5hDjlJuowczULaL9/uh75R6tvF+dZWylEbcKwLFqCGpju3qtSzMG7iVJ7A7yrowXIY8yfwlaWoFkGs0AH+HNCnFw7lAyhj6VxDkU/JVd9gMdb1NMWiZ6W1xTY7GQmtsSlw6WK7LHSb8QeezDNvB1/BLx8Ui/HJ3z4Ta7w1utI7aW6cS66ZLjk2gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=00fis5sJojooq8cDHzk5rorsUfxaW9DofMY0xyKqfhg=; b=hNkW6Amh+1mBUxnM1Sp4mHx90s6QmIDJCF3PNCYy4mWyp903dvjmD8RYwWGWJ/+tZO0cdd2pnF8vv6phgVxgd5lvb+lsH4kqvp+guPjhUdLf56QfaRAlHXDvBeOMzK1A58hliV0rmWsYPbjKxOdyKovfxHcogKqijqYEKQN1EmH6gxkH5KXSAxjbnZ/j9IbnmD03c+4ZVRdKhvUw+Z47q9Z3DWS+sjkwBuc6xg/8Hlxg8l4/cz1Vg7ypjuxk5CvoIjJnAHtC0r+RMm4mZo85I9AN5+En2u736q++WkoeuXbfvLOm9WzNOlD1Q/+T3QMFAtH/86FXj4YwrlL5VB/S+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by DS0PR12MB9060.namprd12.prod.outlook.com (2603:10b6:8:c4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Wed, 28 Feb 2024 12:53:47 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::b913:7732:22e1:b71e]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::b913:7732:22e1:b71e%6]) with mapi id 15.20.7316.034; Wed, 28 Feb 2024 12:53:47 +0000 Message-ID: <0fd9d8ab-c33d-4d28-aae6-3a8dd34b1910@amd.com> Date: Wed, 28 Feb 2024 18:23:40 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Adds ACPI HPET Table generator To: Pierre Gondois , Abdul Lateef Attar , devel@edk2.groups.io CC: Sami Mujawar References: <2990ed3964382d88df2aed092a25fc796c5705b5.1708411357.git.AbdulLateef.Attar@amd.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: X-ClientProxiedBy: PN2P287CA0011.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:21b::18) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|DS0PR12MB9060:EE_ X-MS-Office365-Filtering-Correlation-Id: 45022815-81d0-49a5-bea8-08dc385c4dc6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 8N2n1X3dRCYPQqwpLKosaqHQsaNoua8qddxZQLTwv6br12lk/BhIGLijVI1NzmUIUGd8MavOUASoOCRwaPDpC7rNej1XUVkm8vL4dy0hFLOnIo2f6uGMTYiCsfSB2FasOVpvPTYVBb856pUJ/hTf8H5wqt1/Ue1MsSNKEKucyJtJHPDylOVorZqkuenrF0ARqNUN565FvadMudeDbJtf9vdliXsZ8LCgP9+snGE9/9RdoZJWSRKqDbA4g0xMyEPGf3Bdl+dk3F/LWxuZOCqLPfdDYl+VG84SePLxR7aG4u9delBlL381arcuOuaeOeujOFDsKRTR1AhgCP/oLByW7VLTpbmXEYyfbxaftXlRABjDbah1Hp6D/FyQ9IEvnxTuCo7hEkjkLV3ZL4qNXXaZe/yJlKwr5X47/mauVsrkrD/moYEy/SBkyG0tJrSymlmtpzIBy/9DGxFBhk5jM0TRFIyKiTNkFganMDpWIxMtpnp5FYCReW7LEQZRokTNRVI8ed0aWdDh+fBMMYw4BSwGGgAEecvWvyS5syOq9ONDIfYnDeFdXXhuDU6IcV7dWijLKcTcT7a7hxdecyXvPJKBYDoNMd82JvzmY4/KNB9sKK1lWQvrXfAbM25ywGmuhWAw5qzmjJrslHbO68g8ZeQFTlvp7mfaJk6v/4zycwcZloo= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MpAumJUEugVQCXU+IrfMKvIZPbQs0h+mpL1zG7DTA8Dk7RLXH1eve7/2B1BK?= =?us-ascii?Q?FXF6z9sGWMUvOfgyQfj/2TgfYEUWisNeh/pTpW4ibXtGjWFH7fE5jiiy2Fcv?= =?us-ascii?Q?o3c28R1GE6j8ueGQN6KT6wLAdNZ+i6ULWJzADd/MvW5u4eP+Xg8d2E9WojDb?= =?us-ascii?Q?35AL5qmxzowIFFwqCOwOdhPxQO4fKIEnZKDKpA3thL6N5YR2p5wiaaZw74gT?= =?us-ascii?Q?IxCDvZSTJUk+ce+i7tOhuOlptFcc1Tmt3oQXuaPICRU4UeD8n/w2ds98A5+v?= =?us-ascii?Q?c1cQApo1Uf3eAohffGXRfQN2wEUr1k6PNajBTNKHdmxiPwJEby4JvS7Ku294?= =?us-ascii?Q?OgxDux2eAXN3XLIaLxtqVpqx5bcyUajEk1hus/hwGMKCoRov/bWm0N7JZOdI?= =?us-ascii?Q?GCMiLb/56aKhX5L1ljXj+/j+zOSJL1SkzNw6BGenJ+QbRn0qvB1OUzDu/iQk?= =?us-ascii?Q?6OpFHSCD1qSesNDyiRu6mg0Jr7eNYEetMm75Z5vGUl0/hdBUhfeoiC7Cq4Sb?= =?us-ascii?Q?1TvpcFsiZ3Nr2oyodyBkZmSlAaGq15sKxG4pzNlrsw/Z62+lnY8gKXjPLp/R?= =?us-ascii?Q?4YXwz2akXrAUIu/AQ5wxylatK1ufHnoKeXkNJ3rZCaFju2lfc2U1dAKLHigb?= =?us-ascii?Q?dIcF/exHZMj8aCfQr3NfHeB/GpbhEqZI6wvpg+nSgrZ79JT9U8KL6pK7LN7w?= =?us-ascii?Q?PBj9CBqBO+hjChcotjBTa+ULDjAjf3r9CJCKYvErj31nWq2GrMUsnAcfGtc9?= =?us-ascii?Q?zOArSMedMhz3jJife8amAJ6YtayF1TJ7FGdOWTaujBKhJyK4rYhcbY46B56p?= =?us-ascii?Q?2qlLLUy81vPpaV+NVHP3U2vyLoADkC+UepbMXzZAY30hzAXzVcSL1eqML4Kp?= =?us-ascii?Q?bZj0SplUpym+7+X6yBHXAeTMHQVB4P6ypFtLMwACJPcy+wPkW9VC6QdkIfZs?= =?us-ascii?Q?eFagiU3ow/EM5aHRmBFeqB+XDhDK6JFYv4l2AzZwOOSxpT9FFa02vxa7oaJ5?= =?us-ascii?Q?Y16Z1lcUGM6XSvuiCVjvQ56AwAsK9PkmW8tQaNJPI8csK8MQjDd81RK0N7he?= =?us-ascii?Q?is9UrEsHNCVgsLAb//W6JFC+IppP1OHW92MWrWpNeBI+zLAIyvNDMECjrouO?= =?us-ascii?Q?KzKpMkzqF/CVVXiwK5G0B4ntcxrdBi5oMzhCP457geWccbteRO2vESwP4lgq?= =?us-ascii?Q?Ue1IxmI8ZpnADs/B7DbnWv1qzt3Cf92qzK1DPhIHqO066FhVIHlCaaXiGqTt?= =?us-ascii?Q?vOqufPyNIYl+Tw5FLzXqo/8K47mlK/pICp7QkEx1M8kCIuIlTB2cPidKREw8?= =?us-ascii?Q?hVRNbjYgj724ROMliPBYV7QkvOAf3eBqVaPWMzUu+s3gyoVdLSmhpEjLSR0p?= =?us-ascii?Q?Xz5drzJYRlRz/EPZQZc4M/UqDgdFF8O3sVqLvNCA86cD5HenAh9EPKZpbS3a?= =?us-ascii?Q?Sh3J9leQTuL3n5nvrg70n/cW9ghSN0TPUm8jm4fCvy0Vg6V7rRKAKB8E2gBZ?= =?us-ascii?Q?gblvpr1XcaJ/qLNoTalj/DeYwbHV0/swm9SsPCAKq6fGnX4Xh3WsE/6xHpFs?= =?us-ascii?Q?2aDMh793j1SkJWj6dzCMvIgZC937PRFpN12ieZom?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45022815-81d0-49a5-bea8-08dc385c4dc6 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 12:53:47.6270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: omhIrKa9fFxt5n3TMwh8BapWGA/StOY/F9mWEQaNLVUJ1N1vGvK4FifmCxxrBx6WvockkkhHyc5bXBbGDFgvew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9060 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d2te4gXOPodQidVPHEv1g9Myx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XhbGLyVM; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Pierre Gondois, =C2=A0=C2=A0=C2=A0 Thanks for review the comment, i will make the changes = accordingly. Please find my response in line. Thanks AbduL On 27-02-2024 21:32, Pierre Gondois wrote: > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. > > > Hello Abdul, > > From the HPET spec: > """ > For the case where there may be additional Event Timer Blocks=20 > implemented in the system, their base > addresses would be described in ACPI Name space. > """ > So it seems it might be good (but not necessary) to to add a=20 > description in > a SSDT/DSDT table of the object (with _HID=3DPNP0103). [Abdul] I will submit another Generator library for creating the=20 platform devices in ACPI namespace. > > --- > > Same comment about than for the other patches about adding objects to > the common Arch namespace.` > [Abdul] This Arch namespace changes are non-disruptive and wont cause=20 any failure to existing ARM namespace. I'll submit a separate patch for acpiview to parse the HPET and WSMT table. > > On 2/20/24 07:48, Abdul Lateef Attar wrote: >> From: Abdul Lateef Attar >> >> Adds generic ACPI HPET table generator library. >> Register/Deregister HPET table. >> Update the HPET table during boot as per specification. >> >> Cc: Sami Mujawar >> Cc: Pierre Gondois >> Signed-off-by: Abdul Lateef Attar >> --- >> =C2=A0 DynamicTablesPkg/DynamicTables.dsc.inc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 + >> =C2=A0 DynamicTablesPkg/DynamicTablesPkg.ci.yaml=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 3 +- >> =C2=A0 DynamicTablesPkg/Include/AcpiTableGenerator.h |=C2=A0=C2=A0 1 + >> =C2=A0 .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf=C2=A0 |=C2=A0 38 +++= + >> =C2=A0 .../Library/Acpi/AcpiHpetLib/HpetGenerator.c=C2=A0 | 208 ++++++++= ++++++++++ >> =C2=A0 5 files changed, 251 insertions(+), 1 deletion(-) >> =C2=A0 create mode 100644=20 >> DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> =C2=A0 create mode 100644=20 >> DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c >> >> diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc=20 >> b/DynamicTablesPkg/DynamicTables.dsc.inc >> index 5ec9ffac06..af70785520 100644 >> --- a/DynamicTablesPkg/DynamicTables.dsc.inc >> +++ b/DynamicTablesPkg/DynamicTables.dsc.inc >> @@ -35,6 +35,7 @@ >> =C2=A0=C2=A0=C2=A0 # Generators >> =C2=A0=C2=A0=C2=A0 # >> =C2=A0=C2=A0=C2=A0 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib= .inf >> +=C2=A0 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> >> =C2=A0=C2=A0=C2=A0 # >> =C2=A0=C2=A0=C2=A0 # Dynamic Table Factory Dxe >> @@ -42,6 +43,7 @@ >> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.i= nf=20 >> { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >> NULL|DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf >> + NULL|DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> =C2=A0=C2=A0=C2=A0 } >> >> =C2=A0 [Components.ARM, Components.AARCH64] >> diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml=20 >> b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml >> index 1ad5540e24..cacdaa1df6 100644 >> --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml >> +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml >> @@ -53,7 +53,8 @@ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "EmbeddedPkg/EmbeddedPkg.dec", >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "DynamicTablesPkg/DynamicTablesPkg.dec", >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "MdeModulePkg/MdeModulePkg.dec", >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Mde= Pkg/MdePkg.dec" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Mde= Pkg/MdePkg.dec", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "PcA= tChipsetPkg/PcAtChipsetPkg.dec" >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For host based = unit tests >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDepend= encies-HOST_APPLICATION":[ >> diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h=20 >> b/DynamicTablesPkg/Include/AcpiTableGenerator.h >> index d0eda011c3..18b5f99f47 100644and >> --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h >> +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h >> @@ -99,6 +99,7 @@ typedef enum StdAcpiTableId { >> =C2=A0=C2=A0=C2=A0 EStdAcpiTableIdSsdtCpuTopology,=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ///< SSDT C= pu Topology >> =C2=A0=C2=A0=C2=A0 EStdAcpiTableIdSsdtPciExpress,=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ///< = SSDT Pci=20 >> Express Generator >> =C2=A0=C2=A0=C2=A0 EStdAcpiTableIdPcct,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ///< PCCT Generator >> +=C2=A0 EStdAcpiTableIdHpet,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ///< HPET Generator >> =C2=A0=C2=A0=C2=A0 EStdAcpiTableIdMax >> =C2=A0 } ESTD_ACPI_TABLE_ID; >> >> diff --git=20 >> a/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf=20 >> b/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> new file mode 100644 >> index 0000000000..74a1358ffe >> --- /dev/null >> +++ b/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf >> @@ -0,0 +1,38 @@ >> +## @file >> +#=C2=A0 HPET Table Generator >> +# >> +#=C2=A0 Copyright (C) 2024 Advanced Micro Devices, Inc. All rights rese= rved. >> +# >> +#=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent >> +## >> + >> +[Defines] >> +=C2=A0 INF_VERSION=C2=A0=C2=A0=C2=A0 =3D 1.27 >> +=C2=A0 BASE_NAME=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D AcpiHpetLib >> +=C2=A0 FILE_GUID=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 4E75F653-C356-48B3-B= 32C-D1B901ECF90A >> +=C2=A0 VERSION_STRING =3D 1.0 >> +=C2=A0 MODULE_TYPE=C2=A0=C2=A0=C2=A0 =3D DXE_DRIVER >> +=C2=A0 LIBRARY_CLASS=C2=A0 =3D NULL|DXE_DRIVER >> +=C2=A0 CONSTRUCTOR=C2=A0=C2=A0=C2=A0 =3D AcpiHpetLibConstructor >> +=C2=A0 DESTRUCTOR=C2=A0=C2=A0=C2=A0=C2=A0 =3D AcpiHpetLibDestructor >> + >> +[Sources] >> +=C2=A0 HpetGenerator.c >> + >> +[Packages] >> +=C2=A0 DynamicTablesPkg/DynamicTablesPkg.dec >> +=C2=A0 EmbeddedPkg/EmbeddedPkg.dec > > I think the dependency could be deleted, along with: > HpetGenerator.c:19:#include > >> +=C2=A0 MdeModulePkg/MdeModulePkg.dec >> +=C2=A0 MdePkg/MdePkg.dec >> +=C2=A0 PcAtChipsetPkg/PcAtChipsetPkg.dec > > (for Sami) > A dependency over the PcAtChipsetPkg is introduced here. > >> + >> +[LibraryClasses] >> +=C2=A0 BaseLib >> +=C2=A0 DebugLib >> +=C2=A0 IoLib >> +=C2=A0 PcdLib >> + >> +[Pcd] >> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId >> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision >> +=C2=A0 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress > > > [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116116): https://edk2.groups.io/g/devel/message/116116 Mute This Topic: https://groups.io/mt/104463460/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-