From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3F46211616A2 for ; Tue, 2 Oct 2018 05:19:39 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70EF8300294E; Tue, 2 Oct 2018 12:19:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C3EE79822; Tue, 2 Oct 2018 12:19:35 +0000 (UTC) To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: marcandre , michael.d.kinney@intel.com, jordan.l.justen@intel.com, edk2-devel@lists.01.org, anthony.perard@citrix.com References: <20181002083602.581-1-marcandre.lureau@redhat.com> <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com> From: Laszlo Ersek Message-ID: <100c7116-34ba-f5f9-8b79-9aa201b31506@redhat.com> Date: Tue, 2 Oct 2018 14:19:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 02 Oct 2018 12:19:39 +0000 (UTC) Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 12:19:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/02/18 14:10, Marc-André Lureau wrote: > Hi > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: >> >> On 10/02/18 13:37, Marc-André Lureau wrote: >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: >> >>>> Please fix your git settings for your local edk2 clone. Your patch >>>> contains context lines with LF (not CRLF) line endings, and that's not >>>> correct for edk2. >>> >>> Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1 ? >> >> Yes, it should be caught by "PatchCheck.py". The "force_crlf" member is >> set iff the pathname doesn't end in ".sh", and then the >> check_added_line() method verifies CRLF. >> >> I don't know why it doesn't work in practice. Can you submit a TianoCore >> BZ about it? >> >> (Your patch uses LF on both context lines and new (added) lines, so the >> current script logic should complain, yes.) >> >>> Hmm, this is weird, the original patch has crlf (see attach file). >>> send-email or the mail server somehow stripped it? >>> >>> I use your recommend git settings, I don't know what I am missing here. >> >> You are right, the attachment looks fine. >> >> ... Can you resend the v2 patch (just to me directly, off-list) with >> >> --transfer-encoding=quoted-printable >> >> ? My guess is that the base64 encoding in git-send-email includes an >> automatic CR stripping phase. > > Hmm, actually it's my emacs settings that stripped the crlf from the patch. > > I edited the patch manually to add some notes... Haha, serves you right then ;) I suggest never editing patches after formatting them. In the first place, there's no reason to: you can add, edit and remove notes on commits with "git notes" (without changing the commit hashes / git history). And "git-format-patch" takes a "--notes" option. (Same for "git show".) I do mention git-notes in the "unkempt guide": git config notes.rewriteRef refs/notes/commits git format-patch \ --notes \ git notes edit COMMIT_HASH_OF_THAT_PATCH Thanks for tracking this down! Laszlo