public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Bob Feng <bob.c.feng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers
Date: Wed, 29 Apr 2020 19:51:12 +0200	[thread overview]
Message-ID: <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> (raw)
In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com>

On 4/29/20 6:36 PM, Leif Lindholm wrote:
> We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which
> while it predates the MdeModulePkg SD/(E)MMCsupport is in effect
> unmaintained and also duplicates core industry standard definitions.
> 
> Since we now have GetMaintainers.py to parse Maintainers.txt for us,
> extend its functionality to warn about less supported code.
> 
> Then as an indication of its unsuitability for reference (or use), set
> its Status flag in Maintainers.txt to Obsolete.
> 
> Once this is done, follow up and do the same with the hardware drivers
> (not the software ones) still left in EmbeddedPkg/Drivers. They were
> added back when not using the UEFI driver model was still cool, or
> simply before edk2-platforms existed.
> They should move to edk2-platforms, but most of them require some
> level of rewriting before that.
> 
> 1/3 adds a warning printout to GetMaintainer.py
> 
> 2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/
> 
> 3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers
> Cc: Andrew Fish <afish@apple.com>
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Leif Lindholm (3):
>    BaseTools: add handling for 'S:' flag to GetMaintainer.py
>    Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete
>    Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete
> 

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

I am mostly concerned about the use of MmcDxe in new platforms. The 
other bits I'm not too worried about, and I think it would be fine to 
move those into Platform/ARM/VExpressPkg in edk2-platforms, instead of 
hoping that someone will turn up and turn them into driver model drivers.

One thing I'd like to do in the short term is renaming 
gEfiMmcHostProtocolGuid, given that it violates the naming rules, and 
move the PL180 driver to edk2-platforms. Any thoughts about DwEmmcDxe? 
Only HiKey uses that at the moment, given that socfpga apparently 
switched to the generic version.



  parent reply	other threads:[~2020-04-29 17:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 16:36 [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Leif Lindholm
2020-04-29 16:36 ` [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py Leif Lindholm
2020-04-30  7:00   ` Bob Feng
2020-04-29 16:36 ` [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete Leif Lindholm
2020-04-29 20:12   ` [edk2-devel] " Laszlo Ersek
2020-04-29 16:36 ` [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete Leif Lindholm
2020-04-29 20:14   ` [edk2-devel] " Laszlo Ersek
2020-04-29 17:51 ` Ard Biesheuvel [this message]
2020-04-29 19:53   ` [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Leif Lindholm
2020-04-29 20:04     ` Ard Biesheuvel
2020-04-29 21:45       ` Leif Lindholm
2020-04-29 21:47         ` Ard Biesheuvel
2020-04-30 11:17           ` Laszlo Ersek
2020-04-30 13:28             ` Leif Lindholm
2020-04-30 13:43               ` Ard Biesheuvel
2020-04-30 14:59                 ` Leif Lindholm
2020-04-29 20:14 ` [edk2-devel] " Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10151f16-f903-6fcf-92c8-f28f269eab53@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox