From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.1624.1588182677820558140
 for <devel@edk2.groups.io>;
 Wed, 29 Apr 2020 10:51:18 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FF691045;
	Wed, 29 Apr 2020 10:51:16 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A23CA3F73D;
	Wed, 29 Apr 2020 10:51:14 -0700 (PDT)
Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Bob Feng <bob.c.feng@intel.com>,
 Laszlo Ersek <lersek@redhat.com>, Liming Gao <liming.gao@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20200429163616.5951-1-leif@nuviainc.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com>
Date: Wed, 29 Apr 2020 19:51:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/29/20 6:36 PM, Leif Lindholm wrote:
> We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which
> while it predates the MdeModulePkg SD/(E)MMCsupport is in effect
> unmaintained and also duplicates core industry standard definitions.
> 
> Since we now have GetMaintainers.py to parse Maintainers.txt for us,
> extend its functionality to warn about less supported code.
> 
> Then as an indication of its unsuitability for reference (or use), set
> its Status flag in Maintainers.txt to Obsolete.
> 
> Once this is done, follow up and do the same with the hardware drivers
> (not the software ones) still left in EmbeddedPkg/Drivers. They were
> added back when not using the UEFI driver model was still cool, or
> simply before edk2-platforms existed.
> They should move to edk2-platforms, but most of them require some
> level of rewriting before that.
> 
> 1/3 adds a warning printout to GetMaintainer.py
> 
> 2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/
> 
> 3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers
> Cc: Andrew Fish <afish@apple.com>
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Leif Lindholm (3):
>    BaseTools: add handling for 'S:' flag to GetMaintainer.py
>    Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete
>    Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete
> 

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

I am mostly concerned about the use of MmcDxe in new platforms. The 
other bits I'm not too worried about, and I think it would be fine to 
move those into Platform/ARM/VExpressPkg in edk2-platforms, instead of 
hoping that someone will turn up and turn them into driver model drivers.

One thing I'd like to do in the short term is renaming 
gEfiMmcHostProtocolGuid, given that it violates the naming rules, and 
move the PL180 driver to edk2-platforms. Any thoughts about DwEmmcDxe? 
Only HiKey uses that at the moment, given that socfpga apparently 
switched to the generic version.