From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 18F0C7803CC for ; Fri, 17 May 2024 17:54:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CidDNtXbv8xf7xqYd5vdM0Y7O6bpY9a7r1DqvXQfxMY=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715968495; v=1; b=1+IBgufbXCs5W31ZrQMeJk1V7NfIbXRqZxE8GfNsgTBdHgZhQHXvxfAC9dH4CXCrm4pLUYZY oy+AfigMIAKtNCMQ6vTr6g6FAQ32e63gfVsOJHGNTuLhKG5UEQ+sTyTuCgO78ChCSKWFHmi4M3o MUX52+pdZ5B0RlhUFnbU6sBjjLNtZYzm7+xAknU77FFV83l+SzeNenRJQFnNLChYZ7e7/Mr4GFO gTUdmUQ4WDdnaBeJHGd0H2fsn2Gt8PM/5+3e8gQag5fZVfLbgts6quH1RgIJj1meWo3xS3Wn/dM sVffxcy/3MuMFHO6UwZJwTCKdHJ8RMc0MYJD2Qs0aDgqA== X-Received: by 127.0.0.2 with SMTP id enI5YY7687511xKTrdGta6T3; Fri, 17 May 2024 10:54:55 -0700 Subject: Re: [edk2-devel] [PATCH] XiangshanSeriesPkg:Add Support for Xilinx RC(PCIE) Driver To: "WangYang" , devel@edk2.groups.io From: suijingfeng@bosc.ac.cn X-Originating-Location: Beijing, CN (123.114.53.210) X-Originating-Platform: Linux Firefox 125 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 16 May 2024 19:41:26 -0700 References: <13d2e7e.67.18f7f52c638.Coremail.wangyang@bosc.ac.cn> In-Reply-To: <13d2e7e.67.18f7f52c638.Coremail.wangyang@bosc.ac.cn> Message-ID: <10155.1715913686593449338@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,suijingfeng@bosc.ac.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oR5PGsz3ZDZfxZStXicB4sXTx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=1+IBgufb; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, May 16, 2024 at 10:54 AM, WangYang wrote: Hi, > > Hi,Ray >=20 > Thank you very much for your attention. > The reviewer Ray told you that you patch has some small problems,=20 For example, the clause "if ((Bus =3D=3D 1) || (Bus =3D=3D 2) || (Bus =3D= =3D 3) || (Bus =3D=3D 4)) " is useless. As both code path returns same value.=20 You should solve this small problems, also cut this big patch into smaller = pieces as smaller patch is easier to review. and when all problem solved, you should send the updated patch as V2. Since= this version is V1 as far as I know. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119052): https://edk2.groups.io/g/devel/message/119052 Mute This Topic: https://groups.io/mt/105572700/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-