* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes [not found] <17CDBAD36E570CF2.8965@groups.io> @ 2024-05-16 9:37 ` Yao, Jiewen 2024-05-17 5:36 ` Du Lin 2024-05-27 6:22 ` Du Lin 0 siblings, 2 replies; 14+ messages in thread From: Yao, Jiewen @ 2024-05-16 9:37 UTC (permalink / raw) To: devel@edk2.groups.io, Lin, Du; +Cc: Ard Biesheuvel, Gerd Hoffmann Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du > Sent: Thursday, May 9, 2024 1:27 PM > To: devel@edk2.groups.io > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; > Gerd Hoffmann <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com> > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support > new resource attributes > > Encrypted and Special Purpose resource attributes are introduced in > PI 1.8 Specification. This patch is to update VMM Hob list integrity > check to recognise these resource attributes. > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Signed-off-by: Du Lin <du.lin@intel.com> > --- > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > index b6085eab44..19e9b1bf54 100644 > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > @@ -643,6 +643,8 @@ ValidateHobList ( > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > + > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > { > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > >ResourceAttribute)); > -- > 2.44.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118955): https://edk2.groups.io/g/devel/message/118955 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-16 9:37 ` [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes Yao, Jiewen @ 2024-05-17 5:36 ` Du Lin 2024-05-27 6:22 ` Du Lin 1 sibling, 0 replies; 14+ messages in thread From: Du Lin @ 2024-05-17 5:36 UTC (permalink / raw) To: Yao, Jiewen, devel [-- Attachment #1: Type: text/plain, Size: 560 bytes --] Thanks for the review and approval. Could you please help merge this patch to the upstream? A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5644. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118980): https://edk2.groups.io/g/devel/message/118980 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 1061 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-16 9:37 ` [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes Yao, Jiewen 2024-05-17 5:36 ` Du Lin @ 2024-05-27 6:22 ` Du Lin 2024-05-27 6:42 ` Yao, Jiewen 1 sibling, 1 reply; 14+ messages in thread From: Du Lin @ 2024-05-27 6:22 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: Ard Biesheuvel, Gerd Hoffmann, Yao, Jiewen, Lin, Du Thanks for the review and approval. Could you please help merge this patch to the upstream? A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5644. Thanks. BRs, Lin, Du -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Thursday, May 16, 2024 5:37 PM To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com> Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du > Sent: Thursday, May 9, 2024 1:27 PM > To: devel@edk2.groups.io > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Yao, > Jiewen <jiewen.yao@intel.com> > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Encrypted and Special Purpose resource attributes are introduced in PI > 1.8 Specification. This patch is to update VMM Hob list integrity > check to recognise these resource attributes. > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Signed-off-by: Du Lin <du.lin@intel.com> > --- > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > index b6085eab44..19e9b1bf54 100644 > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > @@ -643,6 +643,8 @@ ValidateHobList ( > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > + > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > + > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > { > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > >ResourceAttribute)); > -- > 2.44.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119274): https://edk2.groups.io/g/devel/message/119274 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-27 6:22 ` Du Lin @ 2024-05-27 6:42 ` Yao, Jiewen 2024-05-27 7:11 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 14+ messages in thread From: Yao, Jiewen @ 2024-05-27 6:42 UTC (permalink / raw) To: Lin, Du, devel@edk2.groups.io; +Cc: Ard Biesheuvel, Gerd Hoffmann I have approved it. What is the process to merge? There is no COMMIT button or PUSH label. > -----Original Message----- > From: Lin, Du <du.lin@intel.com> > Sent: Monday, May 27, 2024 2:23 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > <du.lin@intel.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Thanks for the review and approval. Could you please help merge this patch to > the upstream? A pull request has been created for this patch: > https://github.com/tianocore/edk2/pull/5644. Thanks. > > BRs, > Lin, Du > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, May 16, 2024 5:37 PM > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > <kraxel@redhat.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du > > Sent: Thursday, May 9, 2024 1:27 PM > > To: devel@edk2.groups.io > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Yao, > > Jiewen <jiewen.yao@intel.com> > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support new resource attributes > > > > Encrypted and Special Purpose resource attributes are introduced in PI > > 1.8 Specification. This patch is to update VMM Hob list integrity > > check to recognise these resource attributes. > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Signed-off-by: Du Lin <du.lin@intel.com> > > --- > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > index b6085eab44..19e9b1bf54 100644 > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > + > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > + > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > { > > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > > >ResourceAttribute)); > > -- > > 2.44.0.windows.1 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119276): https://edk2.groups.io/g/devel/message/119276 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-27 6:42 ` Yao, Jiewen @ 2024-05-27 7:11 ` gaoliming via groups.io 2024-05-27 7:12 ` Yao, Jiewen [not found] ` <17D347097EAE4902.28935@groups.io> 0 siblings, 2 replies; 14+ messages in thread From: gaoliming via groups.io @ 2024-05-27 7:11 UTC (permalink / raw) To: devel, jiewen.yao, 'Lin, Du' Cc: 'Ard Biesheuvel', 'Gerd Hoffmann' Jiewen: If the patch is urgent to be merged, I will help add push label to merge it with current process. If the patch is not urgent, it can be merged after TianoCore Code Review is switched from email to GitHub Pull Requests on US Tuesday. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > 发送时间: 2024年5月27日 14:43 > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > <kraxel@redhat.com> > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support > new resource attributes > > I have approved it. > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > -----Original Message----- > > From: Lin, Du <du.lin@intel.com> > > Sent: Monday, May 27, 2024 2:23 PM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > <du.lin@intel.com> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support new resource attributes > > > > Thanks for the review and approval. Could you please help merge this patch to > > the upstream? A pull request has been created for this patch: > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > BRs, > > Lin, Du > > > > -----Original Message----- > > From: Yao, Jiewen <jiewen.yao@intel.com> > > Sent: Thursday, May 16, 2024 5:37 PM > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > <kraxel@redhat.com> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support new resource attributes > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du > > > Sent: Thursday, May 9, 2024 1:27 PM > > > To: devel@edk2.groups.io > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Yao, > > > Jiewen <jiewen.yao@intel.com> > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > support new resource attributes > > > > > > Encrypted and Special Purpose resource attributes are introduced in PI > > > 1.8 Specification. This patch is to update VMM Hob list integrity > > > check to recognise these resource attributes. > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > --- > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > index b6085eab44..19e9b1bf54 100644 > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > + > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > + > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > { > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > > > >ResourceAttribute)); > > > -- > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119277): https://edk2.groups.io/g/devel/message/119277 Mute This Topic: https://groups.io/mt/106326539/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-27 7:11 ` 回复: " gaoliming via groups.io @ 2024-05-27 7:12 ` Yao, Jiewen [not found] ` <17D347097EAE4902.28935@groups.io> 1 sibling, 0 replies; 14+ messages in thread From: Yao, Jiewen @ 2024-05-27 7:12 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io, Lin, Du Cc: 'Ard Biesheuvel', 'Gerd Hoffmann' Thanks. Not urgent. Let’s wait. > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Monday, May 27, 2024 3:12 PM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > <du.lin@intel.com> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Jiewen: > If the patch is urgent to be merged, I will help add push label to merge > it with current process. > > If the patch is not urgent, it can be merged after TianoCore Code Review > is switched from email to GitHub Pull Requests on US Tuesday. > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > 发送时间: 2024年5月27日 14:43 > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > <kraxel@redhat.com> > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support > > new resource attributes > > > > I have approved it. > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > -----Original Message----- > > > From: Lin, Du <du.lin@intel.com> > > > Sent: Monday, May 27, 2024 2:23 PM > > > To: devel@edk2.groups.io > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > > <du.lin@intel.com> > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > support new resource attributes > > > > > > Thanks for the review and approval. Could you please help merge this > patch to > > > the upstream? A pull request has been created for this patch: > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > BRs, > > > Lin, Du > > > > > > -----Original Message----- > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > Sent: Thursday, May 16, 2024 5:37 PM > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > <kraxel@redhat.com> > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > support new resource attributes > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > To: devel@edk2.groups.io > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Yao, > > > > Jiewen <jiewen.yao@intel.com> > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > > support new resource attributes > > > > > > > > Encrypted and Special Purpose resource attributes are introduced in PI > > > > 1.8 Specification. This patch is to update VMM Hob list integrity > > > > check to recognise these resource attributes. > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > --- > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > index b6085eab44..19e9b1bf54 100644 > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > + > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > + > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > { > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > > > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > > > > >ResourceAttribute)); > > > > -- > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119278): https://edk2.groups.io/g/devel/message/119278 Mute This Topic: https://groups.io/mt/106326545/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <17D347097EAE4902.28935@groups.io>]
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes [not found] ` <17D347097EAE4902.28935@groups.io> @ 2024-05-29 23:59 ` Yao, Jiewen 2024-05-30 10:26 ` Du Lin 0 siblings, 1 reply; 14+ messages in thread From: Yao, Jiewen @ 2024-05-29 23:59 UTC (permalink / raw) To: devel@edk2.groups.io, Yao, Jiewen, gaoliming, Lin, Du Cc: 'Ard Biesheuvel', 'Gerd Hoffmann' Lin Du Just FYI: The CI failed after I rebase. If possible, I recommend to submit a new PR to get it resolved. Then I can approve again. > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen > Sent: Monday, May 27, 2024 3:13 PM > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Lin, Du > <du.lin@intel.com> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Thanks. Not urgent. Let’s wait. > > > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Monday, May 27, 2024 3:12 PM > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > <du.lin@intel.com> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com> > > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support new resource attributes > > > > Jiewen: > > If the patch is urgent to be merged, I will help add push label to merge > > it with current process. > > > > If the patch is not urgent, it can be merged after TianoCore Code Review > > is switched from email to GitHub Pull Requests on US Tuesday. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > > 发送时间: 2024年5月27日 14:43 > > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > <kraxel@redhat.com> > > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support > > > new resource attributes > > > > > > I have approved it. > > > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > > > > -----Original Message----- > > > > From: Lin, Du <du.lin@intel.com> > > > > Sent: Monday, May 27, 2024 2:23 PM > > > > To: devel@edk2.groups.io > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > > > <du.lin@intel.com> > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > > support new resource attributes > > > > > > > > Thanks for the review and approval. Could you please help merge this > > patch to > > > > the upstream? A pull request has been created for this patch: > > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > > > BRs, > > > > Lin, Du > > > > > > > > -----Original Message----- > > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > > Sent: Thursday, May 16, 2024 5:37 PM > > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com> > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > > support new resource attributes > > > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > > > -----Original Message----- > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, > Du > > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; > Yao, > > > > > Jiewen <jiewen.yao@intel.com> > > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > > > support new resource attributes > > > > > > > > > > Encrypted and Special Purpose resource attributes are introduced in PI > > > > > 1.8 Specification. This patch is to update VMM Hob list integrity > > > > > check to recognise these resource attributes. > > > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > > --- > > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > index b6085eab44..19e9b1bf54 100644 > > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > > + > > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > > + > > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > > { > > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor > > > > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor- > > > > > >ResourceAttribute)); > > > > > -- > > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119368): https://edk2.groups.io/g/devel/message/119368 Mute This Topic: https://groups.io/mt/106379971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-29 23:59 ` Yao, Jiewen @ 2024-05-30 10:26 ` Du Lin 2024-05-30 10:30 ` Yao, Jiewen 0 siblings, 1 reply; 14+ messages in thread From: Du Lin @ 2024-05-30 10:26 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io, gaoliming Cc: 'Ard Biesheuvel', 'Gerd Hoffmann', Lin, Du Thanks Jiewen. A new PR has been submitted for this: https://github.com/tianocore/edk2/pull/5699. BRs, Lin, Du -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Thursday, May 30, 2024 8:00 AM To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; Lin, Du <du.lin@intel.com> Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com> Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes Lin Du Just FYI: The CI failed after I rebase. If possible, I recommend to submit a new PR to get it resolved. Then I can approve again. > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, > Jiewen > Sent: Monday, May 27, 2024 3:13 PM > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Lin, > Du <du.lin@intel.com> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > to support new resource attributes > > Thanks. Not urgent. Let’s wait. > > > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Monday, May 27, 2024 3:12 PM > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > Du <du.lin@intel.com> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com> > > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > to support new resource attributes > > > > Jiewen: > > If the patch is urgent to be merged, I will help add push label to > > merge it with current process. > > > > If the patch is not urgent, it can be merged after TianoCore Code > > Review is switched from email to GitHub Pull Requests on US Tuesday. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > > 发送时间: 2024年5月27日 14:43 > > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > <kraxel@redhat.com> > > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > support > > > new resource attributes > > > > > > I have approved it. > > > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > > > > -----Original Message----- > > > > From: Lin, Du <du.lin@intel.com> > > > > Sent: Monday, May 27, 2024 2:23 PM > > > > To: devel@edk2.groups.io > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > > > <du.lin@intel.com> > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > check to support new resource attributes > > > > > > > > Thanks for the review and approval. Could you please help merge > > > > this > > patch to > > > > the upstream? A pull request has been created for this patch: > > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > > > BRs, > > > > Lin, Du > > > > > > > > -----Original Message----- > > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > > Sent: Thursday, May 16, 2024 5:37 PM > > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com> > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > check to support new resource attributes > > > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > > > -----Original Message----- > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > > > Lin, > Du > > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com>; > Yao, > > > > > Jiewen <jiewen.yao@intel.com> > > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > check to support new resource attributes > > > > > > > > > > Encrypted and Special Purpose resource attributes are > > > > > introduced in PI > > > > > 1.8 Specification. This patch is to update VMM Hob list > > > > > integrity check to recognise these resource attributes. > > > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > > --- > > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > index b6085eab44..19e9b1bf54 100644 > > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > > + > > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > > + > > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > > { > > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow > > > > > ResourceDescriptor ResourceAttribute type. Type: 0x%08x\n", > > > > > Hob.ResourceDescriptor- > > > > > >ResourceAttribute)); > > > > > -- > > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119387): https://edk2.groups.io/g/devel/message/119387 Mute This Topic: https://groups.io/mt/106379971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-30 10:26 ` Du Lin @ 2024-05-30 10:30 ` Yao, Jiewen 2024-05-30 12:06 ` Du Lin 0 siblings, 1 reply; 14+ messages in thread From: Yao, Jiewen @ 2024-05-30 10:30 UTC (permalink / raw) To: Lin, Du, devel@edk2.groups.io, gaoliming Cc: 'Ard Biesheuvel', 'Gerd Hoffmann' It is out of date again. When I click rebase, I notice git uses "merge branch". It seems not what we want. I am not sure how to handle it. Next time, please tell me ASAP once you submit a new PR. > -----Original Message----- > From: Lin, Du <du.lin@intel.com> > Sent: Thursday, May 30, 2024 6:26 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming > <gaoliming@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com>; Lin, Du <du.lin@intel.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Thanks Jiewen. A new PR has been submitted for this: > https://github.com/tianocore/edk2/pull/5699. > > BRs, > Lin, Du > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, May 30, 2024 8:00 AM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming > <gaoliming@byosoft.com.cn>; Lin, Du <du.lin@intel.com> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Lin Du > Just FYI: The CI failed after I rebase. > > If possible, I recommend to submit a new PR to get it resolved. > Then I can approve again. > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, > > Jiewen > > Sent: Monday, May 27, 2024 3:13 PM > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Lin, > > Du <du.lin@intel.com> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com> > > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > to support new resource attributes > > > > Thanks. Not urgent. Let’s wait. > > > > > > > -----Original Message----- > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > Sent: Monday, May 27, 2024 3:12 PM > > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > > Du <du.lin@intel.com> > > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > > <kraxel@redhat.com> > > > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > > to support new resource attributes > > > > > > Jiewen: > > > If the patch is urgent to be merged, I will help add push label to > > > merge it with current process. > > > > > > If the patch is not urgent, it can be merged after TianoCore Code > > > Review is switched from email to GitHub Pull Requests on US Tuesday. > > > > > > Thanks > > > Liming > > > > -----邮件原件----- > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > > > 发送时间: 2024年5月27日 14:43 > > > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com> > > > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > > > support > > > > new resource attributes > > > > > > > > I have approved it. > > > > > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > > > > > > > -----Original Message----- > > > > > From: Lin, Du <du.lin@intel.com> > > > > > Sent: Monday, May 27, 2024 2:23 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du > > > > > <du.lin@intel.com> > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > check to support new resource attributes > > > > > > > > > > Thanks for the review and approval. Could you please help merge > > > > > this > > > patch to > > > > > the upstream? A pull request has been created for this patch: > > > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > > > > > BRs, > > > > > Lin, Du > > > > > > > > > > -----Original Message----- > > > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > > > Sent: Thursday, May 16, 2024 5:37 PM > > > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com> > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > check to support new resource attributes > > > > > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > > > > Lin, > > Du > > > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > > <kraxel@redhat.com>; > > Yao, > > > > > > Jiewen <jiewen.yao@intel.com> > > > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > > check to support new resource attributes > > > > > > > > > > > > Encrypted and Special Purpose resource attributes are > > > > > > introduced in PI > > > > > > 1.8 Specification. This patch is to update VMM Hob list > > > > > > integrity check to recognise these resource attributes. > > > > > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > > > --- > > > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > index b6085eab44..19e9b1bf54 100644 > > > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > > > + > > > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > > > + > > > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > > > { > > > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow > > > > > > ResourceDescriptor ResourceAttribute type. Type: 0x%08x\n", > > > > > > Hob.ResourceDescriptor- > > > > > > >ResourceAttribute)); > > > > > > -- > > > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119388): https://edk2.groups.io/g/devel/message/119388 Mute This Topic: https://groups.io/mt/106379971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-30 10:30 ` Yao, Jiewen @ 2024-05-30 12:06 ` Du Lin 2024-05-30 12:11 ` Yao, Jiewen 0 siblings, 1 reply; 14+ messages in thread From: Du Lin @ 2024-05-30 12:06 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io, gaoliming Cc: 'Ard Biesheuvel', 'Gerd Hoffmann', Lin, Du Hi Jiewen, Thanks for your patience. I rebased this PR again since CI failed after "merge branch". And it is ready to go now. Per my limited understanding, it should be OK to add the "push" label to merge a PR to upstream even the PR shows "This branch is out-of-date with the base branch" as long as there are no merge conflicts. - Example of adding "push" label to an out-of-date PR: https://github.com/tianocore/edk2/pull/5461 - Example of adding "push" label to an up-to-date PR: https://github.com/tianocore/edk2/pull/5460 BRs, Lin, Du -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Thursday, May 30, 2024 6:31 PM To: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn> Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com> Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes It is out of date again. When I click rebase, I notice git uses "merge branch". It seems not what we want. I am not sure how to handle it. Next time, please tell me ASAP once you submit a new PR. > -----Original Message----- > From: Lin, Du <du.lin@intel.com> > Sent: Thursday, May 30, 2024 6:26 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; > gaoliming <gaoliming@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com>; Lin, Du <du.lin@intel.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > to support new resource attributes > > Thanks Jiewen. A new PR has been submitted for this: > https://github.com/tianocore/edk2/pull/5699. > > BRs, > Lin, Du > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, May 30, 2024 8:00 AM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; > gaoliming <gaoliming@byosoft.com.cn>; Lin, Du <du.lin@intel.com> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > to support new resource attributes > > Lin Du > Just FYI: The CI failed after I rebase. > > If possible, I recommend to submit a new PR to get it resolved. > Then I can approve again. > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, > > Jiewen > > Sent: Monday, May 27, 2024 3:13 PM > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Lin, > > Du <du.lin@intel.com> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com> > > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > to support new resource attributes > > > > Thanks. Not urgent. Let’s wait. > > > > > > > -----Original Message----- > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > Sent: Monday, May 27, 2024 3:12 PM > > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > > Du <du.lin@intel.com> > > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > > <kraxel@redhat.com> > > > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > check to support new resource attributes > > > > > > Jiewen: > > > If the patch is urgent to be merged, I will help add push label > > > to merge it with current process. > > > > > > If the patch is not urgent, it can be merged after TianoCore > > > Code Review is switched from email to GitHub Pull Requests on US Tuesday. > > > > > > Thanks > > > Liming > > > > -----邮件原件----- > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > > > 发送时间: 2024年5月27日 14:43 > > > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > <kraxel@redhat.com> > > > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > > > to > > > support > > > > new resource attributes > > > > > > > > I have approved it. > > > > > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > > > > > > > -----Original Message----- > > > > > From: Lin, Du <du.lin@intel.com> > > > > > Sent: Monday, May 27, 2024 2:23 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > > > > Du <du.lin@intel.com> > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > check to support new resource attributes > > > > > > > > > > Thanks for the review and approval. Could you please help > > > > > merge this > > > patch to > > > > > the upstream? A pull request has been created for this patch: > > > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > > > > > BRs, > > > > > Lin, Du > > > > > > > > > > -----Original Message----- > > > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > > > Sent: Thursday, May 16, 2024 5:37 PM > > > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com> > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > check to support new resource attributes > > > > > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf > > > > > > Of Lin, > > Du > > > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > > <kraxel@redhat.com>; > > Yao, > > > > > > Jiewen <jiewen.yao@intel.com> > > > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > > check to support new resource attributes > > > > > > > > > > > > Encrypted and Special Purpose resource attributes are > > > > > > introduced in PI > > > > > > 1.8 Specification. This patch is to update VMM Hob list > > > > > > integrity check to recognise these resource attributes. > > > > > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > > > --- > > > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > index b6085eab44..19e9b1bf54 100644 > > > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > > > + > > > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > > > + > > > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > > > { > > > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow > > > > > > ResourceDescriptor ResourceAttribute type. Type: 0x%08x\n", > > > > > > Hob.ResourceDescriptor- > > > > > > >ResourceAttribute)); > > > > > > -- > > > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119393): https://edk2.groups.io/g/devel/message/119393 Mute This Topic: https://groups.io/mt/106379971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-30 12:06 ` Du Lin @ 2024-05-30 12:11 ` Yao, Jiewen 0 siblings, 0 replies; 14+ messages in thread From: Yao, Jiewen @ 2024-05-30 12:11 UTC (permalink / raw) To: Lin, Du, devel@edk2.groups.io, gaoliming Cc: 'Ard Biesheuvel', 'Gerd Hoffmann' merged > -----Original Message----- > From: Lin, Du <du.lin@intel.com> > Sent: Thursday, May 30, 2024 8:07 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming > <gaoliming@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com>; Lin, Du <du.lin@intel.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > Hi Jiewen, > > Thanks for your patience. I rebased this PR again since CI failed after "merge > branch". And it is ready to go now. > > Per my limited understanding, it should be OK to add the "push" label to merge a > PR to upstream even the PR shows "This branch is out-of-date with the base > branch" as long as there are no merge conflicts. > - Example of adding "push" label to an out-of-date PR: > https://github.com/tianocore/edk2/pull/5461 > - Example of adding "push" label to an up-to-date PR: > https://github.com/tianocore/edk2/pull/5460 > > BRs, > Lin, Du > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, May 30, 2024 6:31 PM > To: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io; gaoliming > <gaoliming@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > <kraxel@redhat.com> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to > support new resource attributes > > It is out of date again. > > When I click rebase, I notice git uses "merge branch". It seems not what we > want. > > I am not sure how to handle it. > > Next time, please tell me ASAP once you submit a new PR. > > > > -----Original Message----- > > From: Lin, Du <du.lin@intel.com> > > Sent: Thursday, May 30, 2024 6:26 PM > > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; > > gaoliming <gaoliming@byosoft.com.cn> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com>; Lin, Du <du.lin@intel.com> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > to support new resource attributes > > > > Thanks Jiewen. A new PR has been submitted for this: > > https://github.com/tianocore/edk2/pull/5699. > > > > BRs, > > Lin, Du > > > > -----Original Message----- > > From: Yao, Jiewen <jiewen.yao@intel.com> > > Sent: Thursday, May 30, 2024 8:00 AM > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; > > gaoliming <gaoliming@byosoft.com.cn>; Lin, Du <du.lin@intel.com> > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > <kraxel@redhat.com> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > to support new resource attributes > > > > Lin Du > > Just FYI: The CI failed after I rebase. > > > > If possible, I recommend to submit a new PR to get it resolved. > > Then I can approve again. > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, > > > Jiewen > > > Sent: Monday, May 27, 2024 3:13 PM > > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Lin, > > > Du <du.lin@intel.com> > > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > > <kraxel@redhat.com> > > > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > > to support new resource attributes > > > > > > Thanks. Not urgent. Let’s wait. > > > > > > > > > > -----Original Message----- > > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > > Sent: Monday, May 27, 2024 3:12 PM > > > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > > > Du <du.lin@intel.com> > > > > Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > > > > <kraxel@redhat.com> > > > > Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > check to support new resource attributes > > > > > > > > Jiewen: > > > > If the patch is urgent to be merged, I will help add push label > > > > to merge it with current process. > > > > > > > > If the patch is not urgent, it can be merged after TianoCore > > > > Code Review is switched from email to GitHub Pull Requests on US Tuesday. > > > > > > > > Thanks > > > > Liming > > > > > -----邮件原件----- > > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > > > > 发送时间: 2024年5月27日 14:43 > > > > > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io > > > > > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > <kraxel@redhat.com> > > > > > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check > > > > > to > > > > support > > > > > new resource attributes > > > > > > > > > > I have approved it. > > > > > > > > > > What is the process to merge? There is no COMMIT button or PUSH label. > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Lin, Du <du.lin@intel.com> > > > > > > Sent: Monday, May 27, 2024 2:23 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, > > > > > > Du <du.lin@intel.com> > > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > > check to support new resource attributes > > > > > > > > > > > > Thanks for the review and approval. Could you please help > > > > > > merge this > > > > patch to > > > > > > the upstream? A pull request has been created for this patch: > > > > > > https://github.com/tianocore/edk2/pull/5644. Thanks. > > > > > > > > > > > > BRs, > > > > > > Lin, Du > > > > > > > > > > > > -----Original Message----- > > > > > > From: Yao, Jiewen <jiewen.yao@intel.com> > > > > > > Sent: Thursday, May 16, 2024 5:37 PM > > > > > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > > <kraxel@redhat.com> > > > > > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > > check to support new resource attributes > > > > > > > > > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf > > > > > > > Of Lin, > > > Du > > > > > > > Sent: Thursday, May 9, 2024 1:27 PM > > > > > > > To: devel@edk2.groups.io > > > > > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel > > > > > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann > > > > > > > <kraxel@redhat.com>; > > > Yao, > > > > > > > Jiewen <jiewen.yao@intel.com> > > > > > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list > > > > > > > check to support new resource attributes > > > > > > > > > > > > > > Encrypted and Special Purpose resource attributes are > > > > > > > introduced in PI > > > > > > > 1.8 Specification. This patch is to update VMM Hob list > > > > > > > integrity check to recognise these resource attributes. > > > > > > > > > > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > > > > > > Signed-off-by: Du Lin <du.lin@intel.com> > > > > > > > --- > > > > > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ > > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > > index b6085eab44..19e9b1bf54 100644 > > > > > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c > > > > > > > @@ -643,6 +643,8 @@ ValidateHobList ( > > > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | > > > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | > > > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | > > > > > > > + > > > > > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > > > > > > > + > > > > > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | > > > > > > > > > > > > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) > > > > > > > { > > > > > > > DEBUG ((DEBUG_ERROR, "HOB: Unknow > > > > > > > ResourceDescriptor ResourceAttribute type. Type: 0x%08x\n", > > > > > > > Hob.ResourceDescriptor- > > > > > > > >ResourceAttribute)); > > > > > > > -- > > > > > > > 2.44.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119394): https://edk2.groups.io/g/devel/message/119394 Mute This Topic: https://groups.io/mt/106379971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes @ 2024-05-09 5:27 Du Lin 2024-05-13 8:58 ` Gerd Hoffmann 2024-05-20 7:14 ` Du Lin 0 siblings, 2 replies; 14+ messages in thread From: Du Lin @ 2024-05-09 5:27 UTC (permalink / raw) To: devel; +Cc: Du Lin, Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao Encrypted and Special Purpose resource attributes are introduced in PI 1.8 Specification. This patch is to update VMM Hob list integrity check to recognise these resource attributes. Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Signed-off-by: Du Lin <du.lin@intel.com> --- OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c index b6085eab44..19e9b1bf54 100644 --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c @@ -643,6 +643,8 @@ ValidateHobList ( EFI_RESOURCE_ATTRIBUTE_PERSISTABLE | EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED | EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE | + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| + EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0) { DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor->ResourceAttribute)); -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118715): https://edk2.groups.io/g/devel/message/118715 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-09 5:27 Du Lin @ 2024-05-13 8:58 ` Gerd Hoffmann 2024-05-20 7:14 ` Du Lin 1 sibling, 0 replies; 14+ messages in thread From: Gerd Hoffmann @ 2024-05-13 8:58 UTC (permalink / raw) To: devel, du.lin; +Cc: Ard Biesheuvel, Jiewen Yao On Thu, May 09, 2024 at 01:27:07PM GMT, Du Lin wrote: > Encrypted and Special Purpose resource attributes are introduced in > PI 1.8 Specification. This patch is to update VMM Hob list integrity > check to recognise these resource attributes. > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Signed-off-by: Du Lin <du.lin@intel.com> > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED| > + EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE | Acked-by: Gerd Hoffmann <kraxel@redhat.com> take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118859): https://edk2.groups.io/g/devel/message/118859 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes 2024-05-09 5:27 Du Lin 2024-05-13 8:58 ` Gerd Hoffmann @ 2024-05-20 7:14 ` Du Lin 1 sibling, 0 replies; 14+ messages in thread From: Du Lin @ 2024-05-20 7:14 UTC (permalink / raw) To: Du Lin, devel [-- Attachment #1: Type: text/plain, Size: 560 bytes --] Thanks for the review and approval. Could you please help merge this patch to the upstream? A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5644. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119076): https://edk2.groups.io/g/devel/message/119076 Mute This Topic: https://groups.io/mt/105996363/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 3083 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-05-30 12:12 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <17CDBAD36E570CF2.8965@groups.io>
2024-05-16 9:37 ` [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes Yao, Jiewen
2024-05-17 5:36 ` Du Lin
2024-05-27 6:22 ` Du Lin
2024-05-27 6:42 ` Yao, Jiewen
2024-05-27 7:11 ` 回复: " gaoliming via groups.io
2024-05-27 7:12 ` Yao, Jiewen
[not found] ` <17D347097EAE4902.28935@groups.io>
2024-05-29 23:59 ` Yao, Jiewen
2024-05-30 10:26 ` Du Lin
2024-05-30 10:30 ` Yao, Jiewen
2024-05-30 12:06 ` Du Lin
2024-05-30 12:11 ` Yao, Jiewen
2024-05-09 5:27 Du Lin
2024-05-13 8:58 ` Gerd Hoffmann
2024-05-20 7:14 ` Du Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox