From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.20542.1590695929230930445 for ; Thu, 28 May 2020 12:58:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iybuPl/A; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590695928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HnkCj4vvZ9YNSevskje30GRmoWFhssF+kmx/eaW3rig=; b=iybuPl/AaIPM/s+HVpYxZDC2sgfRUa42q2GhNHd2KcJ3XeCZHFC9q0GWlXWg0Fc6SbsPTk BpX5cEwftoSVfJxw/NpXm3N9E567cXv6lkut6tpNe/UbDG7b9nZO5V4Feu6x1O4nS61EgY sYv1GhjKhRkU2gA4J4vsm6FM2mgLHq4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-hPORYRunPxSymFZsLG9ZfQ-1; Thu, 28 May 2020 15:58:46 -0400 X-MC-Unique: hPORYRunPxSymFZsLG9ZfQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF0A518FF660; Thu, 28 May 2020 19:58:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-101.ams2.redhat.com [10.36.112.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 878126EA51; Thu, 28 May 2020 19:58:43 +0000 (UTC) Subject: Re: [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option To: Ard Biesheuvel , devel@edk2.groups.io Cc: jon@solid-run.com, Leif Lindholm , Ray Ni , Zhichao Gao References: <20200528091741.14610-1-ard.biesheuvel@arm.com> <20200528091741.14610-5-ard.biesheuvel@arm.com> From: "Laszlo Ersek" Message-ID: <102561d0-7bcf-4008-7b9b-18cfe1b479e7@redhat.com> Date: Thu, 28 May 2020 21:58:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200528091741.14610-5-ard.biesheuvel@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/28/20 11:17, Ard Biesheuvel wrote: > Without ConnectAll() being called on the boot path, the UEFI shell will > be entered with no block devices or anything else connected, and so for > the novice user, this is not a very accommodating environment. Now that > we have made the UiApp the last resort on boot failure, and made the > UEFI Shell accessible directly via the 's' hotkey if you really need > it, let's hide it as an ordinary boot option. > > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 85cb32f6d7cd..1e9b736993d0 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -777,9 +777,7 @@ PlatformBootManagerAfterConsole ( > // > Key.ScanCode = SCAN_NULL; > Key.UnicodeChar = L's'; > - PlatformRegisterFvBootOption ( > - &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key > - ); > + PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", 0, &Key); > } > > /** > Reviewed-by: Laszlo Ersek