From: "PierreGondois" <pierre.gondois@arm.com>
To: Bob Feng <bob.c.feng@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro
Date: Mon, 10 Feb 2020 05:29:08 -0800 [thread overview]
Message-ID: <1032.1581341348449835793@groups.io> (raw)
In-Reply-To: <260e8e0b8214418ea47b139b8c137fca@intel.com>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Hello Bob,
[From Bob]
This patch cause UefiCpuPkg build fail.
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86
As said in the cover letter of the v4 available at the link below, I was not able to reproduce the build fail that you pointed out. In the v4, the only thing that I am modifying is a condition on the makefile type. Hopefully this should only impact the build on Windows platforms using GNU makefiles. Thus there should not be any reason not to build on Windows platform using nmake makefiles. Feel free to modify this patch if you see what needs to be done.
V4 of "BaseTools: Remove caret in NASM_INC": https://edk2.groups.io/g/devel/message/54125
Regards,
Pierre
[-- Attachment #2: Type: text/html, Size: 736 bytes --]
next prev parent reply other threads:[~2020-02-10 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 15:51 [PATCH v3 0/2] BaseTools: Rationalise makefile generation PierreGondois
2020-02-06 15:51 ` [PATCH v3 1/2] " PierreGondois
2020-02-06 15:51 ` [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro PierreGondois
2020-02-07 7:14 ` [edk2-devel] " Bob Feng
2020-02-10 13:29 ` PierreGondois [this message]
2020-02-11 13:29 ` Bob Feng
2020-02-11 14:20 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032.1581341348449835793@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox