From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro
To: Bob Feng <bob.c.feng@intel.com>,devel@edk2.groups.io
From: "PierreGondois" <pierre.gondois@arm.com>
X-Originating-Location: Cambridge, England, GB (217.140.106.52)
X-Originating-Platform: Windows Firefox 72
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Mon, 10 Feb 2020 05:29:08 -0800
References: <260e8e0b8214418ea47b139b8c137fca@intel.com>
In-Reply-To: <260e8e0b8214418ea47b139b8c137fca@intel.com>
Message-ID: <1032.1581341348449835793@groups.io>
Content-Type: multipart/alternative; boundary="dD65srURDxFjDb9j3Uth"

--dD65srURDxFjDb9j3Uth
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Bob,

[From Bob]
This patch cause UefiCpuPkg build fail.
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86

As said in the cover letter of the v4 available at the link below, I was n=
ot able to reproduce the build fail that you pointed out. In the v4, the on=
ly thing that I am modifying is a condition on the makefile type. Hopefully=
 this should only impact the build on Windows platforms using GNU makefiles=
. Thus there should not be any reason not to build on Windows platform usin=
g nmake makefiles. Feel free to modify this patch if you see what needs to =
be done.
V4 of "BaseTools: Remove caret in NASM_INC": https://edk2.groups.io/g/deve=
l/message/54125

Regards,
Pierre

--dD65srURDxFjDb9j3Uth
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Bob,<br /><br />[From Bob]<br />This patch cause UefiCpuPkg build fai=
l.<br />build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86<br /><br />=
As said in the cover letter of the v4 available at the link below, I was no=
t able to reproduce the build fail that you pointed out. In the v4, the onl=
y thing that I am modifying is a condition on the makefile type. Hopefully =
this should only impact the build on Windows platforms using GNU makefiles.=
 Thus there should not be any reason not to build on Windows platform using=
 nmake makefiles. Feel free to modify this patch if you see what needs to b=
e done.<br />V4 of "BaseTools: Remove caret in NASM_INC": https://edk2.grou=
ps.io/g/devel/message/54125<br /><br />Regards,<br />Pierre

--dD65srURDxFjDb9j3Uth--