From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=laurie.jarlstrom@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F2ED202E60EB for ; Mon, 16 Oct 2017 12:43:12 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2017 12:46:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,387,1503385200"; d="scan'208";a="139035538" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 16 Oct 2017 12:46:37 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 12:46:31 -0700 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.185]) by fmsmsx120.amr.corp.intel.com ([169.254.15.198]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 12:46:31 -0700 From: "Jarlstrom, Laurie" To: "Carsey, Jaben" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Thread-Index: AQHTRpxeQynPi53DHUaGdjZBQqmgE6Lm4WTQ Date: Mon, 16 Oct 2017 19:46:31 +0000 Message-ID: <10380531DF222B45964BE3E93EFE5F0488F7E837@fmsmsx104.amr.corp.intel.com> References: <20171016073048.236980-1-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 19:43:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE= to EFI_CYAN to get a brighter blue. thanks, Laurie =A0 laurie.jarlstrom@intel.com Intel SSG/STO/EBP (503) 712-9395 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Cars= ey, Jaben Sent: Monday, October 16, 2017 9:32 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/g= reen color Reviewed-by: Jaben Carsey We could also use some PCDs if different people really want different color= s in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green=20 > color > Importance: High >=20 > Some developers/QAs complain the color of directory or executable=20 > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLU= E, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel