From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mx.groups.io with SMTP id smtpd.web11.20462.1594919672174377172 for ; Thu, 16 Jul 2020 10:14:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=U6RRIlA8; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.208.181, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-lj1-f181.google.com with SMTP id z24so8717436ljn.8 for ; Thu, 16 Jul 2020 10:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=oqHztuBOPu1kC9ASELCgn1AvCfylu/nHBAobSciuPoM=; b=U6RRIlA85U01B56HtxH6RKv6KMt7NbO2+zK30/kXrQLvaNB0CVO4ZEzEujFtMkSxVJ sBVj5lSxCY5jpEqMSG7MocoDI1hIxD7jaZJPTkr1AE54cfl9jaL/e98DBTNJnStesez4 NYvH0N30rcE6pvVH+cBERradXBi+ut6qxnNQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=oqHztuBOPu1kC9ASELCgn1AvCfylu/nHBAobSciuPoM=; b=ZCPbFQjvfvMA8byumSN+BBrT9LtivFrgRnu6ru8shBnonhXhqfSuK8TE2UJJjB+OZr IMbDuG+NbmoMlE1QA6siz8FcS7fDIJ+AH7LsH79D/75209eY5VDa3MYvmpZjBFOxTUHM lB2WZPJhowaVr/FSWPgzxv+pzbz3plywcu3QdHz+yQlsap+GYiGTA7P75v7C4mKAeivY xi5u4svAQMNT+2fe5y6sE/AcUAcdcf4x3aI2k/6FucUU3bHR+BqNQFdexc8j9XNXBHHK miMlGEph13rAO9QNFmTLUIAKCZXResIJN3S/FySWDGQaNxiR8HNkSzCc6dfwVgkmOdvH CrTQ== X-Gm-Message-State: AOAM531eU+j9sx4VePJlOmwZJeHhY5eOf2Hzuk4faTbnU++c7+Dtwhz2 sXFjSjEo5r2V77Hrz9XUaaE0Vje/bIPZngv/HNUje/bwRO8= X-Google-Smtp-Source: ABdhPJzrKz3JZGndYBfQIC63E+wL25nHGoCcu/bTNULQkhvA7TvLw08E2ZBAnAMT+QYM4/f0qfijzObsW4ic0iUIZTI= X-Received: by 2002:a2e:2a81:: with SMTP id q123mr2581182ljq.229.1594919670388; Thu, 16 Jul 2020 10:14:30 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com> <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHWOTapeOQNV4NQfAeaKbZPaHyXkQF6CKeRAhRV4gEBSZV8tQJCru4lARhsZj2oyRyPMA== Date: Thu, 16 Jul 2020 10:14:28 -0700 Message-ID: <103e6868de68d05e2817abe00cba878a@mail.gmail.com> Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Samer El-Haj-Mahmoud , Laszlo Ersek , devel@edk2.groups.io Cc: Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , nd Content-Type: text/plain; charset="UTF-8" > -----Original Message----- > From: Samer El-Haj-Mahmoud > Sent: Thursday, July 16, 2020 8:26 AM > > Adding to Laszlo's feedback, yes thank you for this feature! I have been > using > this tool on some systems (like the Raspberry Pi) for some time now. It is > *very* useful for some use cases (such as transferring files from/to a > remote > system running in the UEFI Shell). Thank you Samer, we use http download for all our platforms in place of tftp. On our network the speed is more than x10 times faster comparing to tftp download speed. > > What is surprising is the time it is taking for the patches to be reviewed > and > integrated. If I remember correctly, it has been close to 6 months since > v1 > was submitted, correct? And so far, it looks like the review is mainly > around > the Shell command usage. I *think* the patches are still waiting for > NetworkPkg maintainers review correct? Yes, the first patcheset was sent sometime in winter. We are waiting for NetworkPkg reviewers to approve/or comment the patchset. The time can be affected by lockdowns due to pandemic, I understand. Thank you, Vladimir > > Thanks, > --Samer > > > > -----Original Message----- > > From: Laszlo Ersek > > Sent: Thursday, July 16, 2020 8:20 AM > > To: Vladimir Olovyannikov ; > > devel@edk2.groups.io > > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao > > ; Maciej Rabeda > > ; Jiaxin Wu ; > > Siyuan Fu ; Ray Ni ; Liming Gao > > ; nd > > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > > HttpDynamicCommand > > > > On 07/15/20 19:09, Vladimir Olovyannikov wrote: > > > Hi Laszlo, > > > > > > Thank you for supporting this. > > > I can add required support. > > > > Thanks! > > > > > But shouldn't we wait until the patch is reviewed and approved first? > > > I don't know the proper procedure. Please advise. > > > > If a v4 of your patch becomes necessary, based on the ShellPkg > maintainers' > > review, then my suggestion would be to send v4 as a patch series, not > > as a single patch. The v4 1/3 patch would be the current patch (with > > updates as requested by the ShellPkg reviewers). The v4 2/3 patch > > would extend ArmVirtPkg to include the new dynamic command. The v4 > > 3/3 patch would do the same for OvmfPkg. > > > > If a v4 of your patch turns out to be unnecessary (i.e., in case the > > ShellPkg maintainers merge your v3 patch as-is), then sending a > > separate 2-part series > > (1/2: ArmVirtPkg, 2/2: OvmfPkg) would be straightforward, in my opinion. > > > > Thank you for considering my request (and for implementing the feature > > in the first place, of course)! > > > > Laszlo