public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Vivek Kumar Gautam <vivek.gautam@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] Platform/Sgi: Add smmu node in the iort acpi table
Date: Mon, 01 Mar 2021 06:38:39 -0800	[thread overview]
Message-ID: <10413.1614609519697322544@groups.io> (raw)
In-Reply-To: <20210215103229.12310-2-vivek.gautam@arm.com>

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Vivek,

Can you include the description you included in the cover letter in the commit message for this patch, please?

On Mon, Feb 15, 2021 at 01:00 PM, Vivek Kumar Gautam wrote:

> 
> + __builtin_offsetof (ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE, ItsNode=

Use OFFSET_OF() macro as __builtin_offsetof is compiler specific.

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 415 bytes --]

  reply	other threads:[~2021-03-01 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 10:32 [edk2-platforms][PATCH V1 0/2] Enable SMMUv3 for Arm SGI/RD platforms Vivek Kumar Gautam
2021-02-15 10:32 ` [edk2-platforms][PATCH V1 1/2] Platform/Sgi: Add smmu node in the iort acpi table Vivek Kumar Gautam
2021-03-01 14:38   ` Sami Mujawar [this message]
2021-03-05 13:05     ` [edk2-devel] " Vivek Kumar Gautam
2021-02-15 10:32 ` [edk2-platforms][PATCH V1 2/2] Platform/Sgi: Enable ATS mode over PCI root complex Vivek Kumar Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10413.1614609519697322544@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox