public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Adding Bhyve support into upstream EDK2
Date: Wed, 11 Mar 2020 03:21:20 +0000	[thread overview]
Message-ID: <10477f31afe34c2ba8b38a94bca2152c@intel.com> (raw)
In-Reply-To: <13852.1583869480045221662@groups.io>

[-- Attachment #1: Type: text/plain, Size: 1923 bytes --]

Sean:
  We mostly use Emulator to verify and debug the code change in the common module, such as BDS, HII, DxeCore, PeiCore. Compared to the real platform, Emulator and OVMF are more easier to be built and verified. So, I request to add Open CI build test for Ovmf and Emulator (BZ 2570). Later, we may consider to add boot test on them.

Thanks
Liming
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean via Groups.Io
Sent: Wednesday, March 11, 2020 3:45 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] Adding Bhyve support into upstream EDK2

If I look around i don't see that documented.
https://github.com/tianocore/edk2#code-contributions
https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions
https://github.com/tianocore/tianocore.github.io/wiki/How-To-Contribute
https://github.com/tianocore/tianocore.github.io/wiki/How-to-Become-a-Contributor

In Laszlo's massive write up that is very detailed for the contribution process there is nothing calling out that the contributor must test on any given platform.
He does however suggest that maybe as a maintainer you should test it but again no indication of how/what/where.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#maint-13

In all the teams i have worked with over the years no one has used OVMF or emulator package as the verification for an edk2 patch.  Maybe that is just my experience.

Overall my point is I don't think this is clear to the community and I believe that adding this requirement without actually building the full infrastructure online will be detrimental to the contribution process.  And if building the infrastructure online then build it to scale to N platforms to cover more of the edk2 community and not just those in the edk2 tree.

Thanks
Sean


[-- Attachment #2: Type: text/html, Size: 5323 bytes --]

  parent reply	other threads:[~2020-03-11  3:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 16:09 Adding Bhyve support into upstream EDK2 Rebecca Cran
2020-03-06 19:54 ` Laszlo Ersek
2020-03-06 20:04   ` [edk2-devel] " Laszlo Ersek
2020-03-07  1:29 ` Yao, Jiewen
2020-03-24  1:34   ` Rebecca Cran
2020-03-25  0:04     ` Laszlo Ersek
2020-03-25 18:18       ` [EXTERNAL] " Bret Barkelew
2020-03-27 12:56         ` Laszlo Ersek
2020-03-25 18:50       ` Rebecca Cran
     [not found] ` <15F9E16A0219E7B7.19404@groups.io>
2020-03-07  1:43   ` Yao, Jiewen
2020-03-07  7:39     ` Laszlo Ersek
2020-03-07  7:52       ` Ard Biesheuvel
2020-03-08  2:40         ` Rebecca Cran
2020-03-09  6:08         ` Sean
2020-03-09 22:54           ` Laszlo Ersek
2020-03-09 23:17             ` Laszlo Ersek
2020-03-10  1:50               ` Sean
2020-03-10  9:05                 ` Laszlo Ersek
2020-03-10 17:25                   ` Sean
2020-03-10 17:54                     ` Ard Biesheuvel
2020-03-10 19:10                       ` Sean
2020-03-10 19:23                         ` Michael D Kinney
2020-03-10 19:44                           ` Sean
2020-03-10 20:04                             ` Rebecca Cran
2020-03-11  0:05                             ` Laszlo Ersek
2020-03-11  0:30                               ` Sean
2020-03-11  3:21                             ` Liming Gao [this message]
2020-03-10 23:34                     ` Laszlo Ersek
2020-03-11  0:43           ` Leif Lindholm
2020-03-07  7:53       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10477f31afe34c2ba8b38a94bca2152c@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox