From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by mx.groups.io with SMTP id smtpd.web11.3322.1638412948665945672 for ; Wed, 01 Dec 2021 18:42:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@bsdio.com header.s=xmission header.b=gtqUMmp7; spf=neutral (domain: bsdio.com, ip: 166.70.13.232, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To:From :References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EE+Ak3J/k1yWWORljnqNPsq853RLxj4GnWe/PGHSEgc=; b=gtqUMmp7jq8CQ2W5QiSvlTt6qO dfHUaevEyjInKSc9u9RVXtlfaO/2LlylBVrXfG+T5eCNiue4YUgzKahFF7Q6LCwEkJB5gL5EHyAq0 ffV1NDoValNt0Rgb0DISbFhQ8ihVNbDMXieiTziq4uLbDELFJP3oj3dfZZI7SJNd5qoQ=; Received: from in02.mta.xmission.com ([166.70.13.52]:45156) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1msc3G-003QRp-Op; Wed, 01 Dec 2021 19:42:26 -0700 Received: from mta5.zcs.xmission.com ([166.70.13.69]:45134) by in02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1msc3E-00Aq4z-Mz; Wed, 01 Dec 2021 19:42:26 -0700 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 7451E1280962; Wed, 1 Dec 2021 19:42:24 -0700 (MST) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n5JXoO91XNk4; Wed, 1 Dec 2021 19:42:24 -0700 (MST) Received: from [10.0.10.162] (c-98-202-152-176.hsd1.ut.comcast.net [98.202.152.176]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 3748F128095D; Wed, 1 Dec 2021 19:42:24 -0700 (MST) Message-ID: <105601cb-f815-4a5e-c786-c065f737953b@bsdio.com> Date: Wed, 1 Dec 2021 19:42:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 To: Andrew Fish , edk2-devel-groups-io Cc: Ray Ni , "Kinney, Michael D" , Ard Biesheuvel , leif@nuviainc.com References: <20210509192647.14478-1-rebecca@bsdio.com> <37EF0F13-4C27-4D4F-93D1-FEF6CB0DF8C2@apple.com> From: "Rebecca Cran" In-Reply-To: <37EF0F13-4C27-4D4F-93D1-FEF6CB0DF8C2@apple.com> X-XM-SPF: eid=1msc3E-00Aq4z-Mz;;;mid=<105601cb-f815-4a5e-c786-c065f737953b@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=neutral X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa03.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,TR_XM_BayesUnsub,TR_XM_SB_Phish, T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,TooManyTo_001,XMBrknScrpt_02, XMSubLong,XMSubPhish11,XM_B_Unsub autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.5 XM_B_Unsub Unsubscribe in body of email but missing unsubscribe * header * 0.4 XMBrknScrpt_02 Possible Broken Spam Script * 1.5 XMSubPhish11 Phishy Language Subject * -2.2 NICE_REPLY_A Looks like a legit reply (A) * 1.5 TR_XM_BayesUnsub High bayes score with no unsubscribe header * 0.0 TR_XM_SB_Phish Phishing flag in subject of message X-Spam-DCC: XMission; sa03 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Andrew Fish , edk2-devel-groups-io X-Spam-Relay-Country: X-Spam-Timing: total 1572 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.8 (0.2%), b_tie_ro: 2.6 (0.2%), parse: 1.41 (0.1%), extract_message_metadata: 26 (1.6%), get_uri_detail_list: 4.9 (0.3%), tests_pri_-1000: 8 (0.5%), tests_pri_-950: 0.94 (0.1%), tests_pri_-900: 0.79 (0.1%), tests_pri_-90: 87 (5.5%), check_bayes: 86 (5.5%), b_tokenize: 16 (1.0%), b_tok_get_all: 11 (0.7%), b_comp_prob: 2.6 (0.2%), b_tok_touch_all: 53 (3.4%), b_finish: 0.66 (0.0%), tests_pri_0: 1432 (91.1%), check_dkim_signature: 0.48 (0.0%), check_dkim_adsp: 43 (2.7%), poll_dns_idle: 41 (2.6%), tests_pri_10: 1.68 (0.1%), tests_pri_500: 7 (0.5%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3 X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I just noticed this was never committed. Could someone commit/push this change please? -- Rebecca Cran On 7/20/21 23:25, Andrew Fish wrote: > Reviewed-by: Andrew Fish > >> On May 9, 2021, at 12:26 PM, Rebecca Cran wrote: >> >> The version of lldb shipping with macOS Big Sur is lldb-1205.0.27.3, and >> it uses python3. Update lldbefi.py to work with it, including removing >> the unused 'commands' import and fixing the print statements. >> >> Signed-off-by: Rebecca Cran >> --- >> EmulatorPkg/Unix/lldbefi.py | 17 ++++++++--------- >> 1 file changed, 8 insertions(+), 9 deletions(-) >> >> diff --git a/EmulatorPkg/Unix/lldbefi.py b/EmulatorPkg/Unix/lldbefi.py >> index c3fb2675cb..952f8bf982 100755 >> --- a/EmulatorPkg/Unix/lldbefi.py >> +++ b/EmulatorPkg/Unix/lldbefi.py >> @@ -10,7 +10,6 @@ import lldb >> import os >> import uuid >> import string >> -import commands >> import optparse >> import shlex >> >> @@ -389,7 +388,7 @@ def LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict): >> >> FileName = frame.thread.process.ReadCStringFromMemory (FileNamePtr, FileNameLen, Error) >> if not Error.Success(): >> - print "!ReadCStringFromMemory() did not find a %d byte C string at %x" % (FileNameLen, FileNamePtr) >> + print("!ReadCStringFromMemory() did not find a %d byte C string at %x" % (FileNameLen, FileNamePtr)) >> # make breakpoint command continue >> return False >> >> @@ -398,7 +397,7 @@ def LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict): >> LoadAddress = frame.FindVariable ("LoadAddress").GetValueAsUnsigned() - 0x240 >> >> debugger.HandleCommand ("target modules add %s" % FileName) >> - print "target modules load --slid 0x%x %s" % (LoadAddress, FileName) >> + print("target modules load --slid 0x%x %s" % (LoadAddress, FileName)) >> debugger.HandleCommand ("target modules load --slide 0x%x --file %s" % (LoadAddress, FileName)) >> else: >> target = debugger.GetSelectedTarget() >> @@ -408,7 +407,7 @@ def LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict): >> if FileName == ModuleName or FileName == SBModule.GetFileSpec().GetFilename(): >> target.ClearModuleLoadAddress (SBModule) >> if not target.RemoveModule (SBModule): >> - print "!lldb.target.RemoveModule (%s) FAILED" % SBModule >> + print("!lldb.target.RemoveModule (%s) FAILED" % SBModule) >> >> # make breakpoint command continue >> return False >> @@ -490,15 +489,15 @@ def efi_guid_command(debugger, command, result, dict): >> >> if len(args) >= 1: >> if GuidStr in guid_dict: >> - print "%s = %s" % (guid_dict[GuidStr], GuidStr) >> - print "%s = %s" % (guid_dict[GuidStr], GuidToCStructStr (GuidStr)) >> + print("%s = %s" % (guid_dict[GuidStr], GuidStr)) >> + print("%s = %s" % (guid_dict[GuidStr], GuidToCStructStr (GuidStr))) >> else: >> - print GuidStr >> + print(GuidStr) >> else: >> # dump entire dictionary >> width = max(len(v) for k,v in guid_dict.iteritems()) >> for value in sorted(guid_dict, key=guid_dict.get): >> - print '%-*s %s %s' % (width, guid_dict[value], value, GuidToCStructStr(value)) >> + print('%-*s %s %s' % (width, guid_dict[value], value, GuidToCStructStr(value))) >> >> return >> >> @@ -538,4 +537,4 @@ def __lldb_init_module (debugger, internal_dict): >> if Breakpoint.GetNumLocations() == 1: >> # Set the emulator breakpoints, if we are in the emulator >> debugger.HandleCommand("breakpoint command add -s python -F lldbefi.LoadEmulatorEfiSymbols {id}".format(id=Breakpoint.GetID())) >> - print 'Type r to run emulator. SecLldbScriptBreak armed. EFI modules should now get source level debugging in the emulator.' >> + print('Type r to run emulator. SecLldbScriptBreak armed. EFI modules should now get source level debugging in the emulator.') >> -- >> 2.30.1 (Apple Git-130) >> >> >> >> >> >> >>