This looks fine but it seems focused on writing a new module/project.&nbsp; Most python work going into edk2 is part of existing code.&nbsp; <br />I would like to see additional documentation about how this applies to edk2 basetools.<br /><br />* A flake8 config file could be added to basetools python.&nbsp; <br />* Documentation of developer workflows with edk2 basetools<br />* A plan for how to get edk2 basetools to meet these requirements<br />* A plan for automated patch verification of meeting these rules.<br /><br />I have a rule of thumb for code guidelines.&nbsp; I don't make any rules unless I can enforce them without un-manageable burden.&nbsp;&nbsp;<br /><br />I also would rather see this type of documentation in the basetools python folder.&nbsp; There is no reason a developer should have to go looking for this somewhere else within the tianocore site.&nbsp;&nbsp;<br /><br />Finally, I would suggest we leverage an auto-formatter and provide the config file for that.&nbsp; This reduces significant burden on the developer and keeps all contributes aligned.&nbsp;&nbsp;<br /><br />Thanks<br />Sean