From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] EDK II Python development process specification -draft To: Purma, Kondal R ,devel@edk2.groups.io From: "Sean" X-Originating-Location: Redmond, Washington, US (50.35.74.15) X-Originating-Platform: Windows Chrome 82 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Sat, 07 Mar 2020 13:35:38 -0800 References: <55pT.1583540823516683908.5KzJ@groups.io> In-Reply-To: <55pT.1583540823516683908.5KzJ@groups.io> Message-ID: <10736.1583616938364039740@groups.io> Content-Type: multipart/alternative; boundary="ZfYp0FDhly6UlmrXxmkK" --ZfYp0FDhly6UlmrXxmkK Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This looks fine but it seems focused on writing a new module/project.=C2=A0= Most python work going into edk2 is part of existing code. I would like to see additional documentation about how this applies to edk= 2 basetools. * A flake8 config file could be added to basetools python. * Documentation of developer workflows with edk2 basetools * A plan for how to get edk2 basetools to meet these requirements * A plan for automated patch verification of meeting these rules. I have a rule of thumb for code guidelines.=C2=A0 I don't make any rules u= nless I can enforce them without un-manageable burden. I also would rather see this type of documentation in the basetools python= folder.=C2=A0 There is no reason a developer should have to go looking for= this somewhere else within the tianocore site. Finally, I would suggest we leverage an auto-formatter and provide the con= fig file for that.=C2=A0 This reduces significant burden on the developer a= nd keeps all contributes aligned. Thanks Sean --ZfYp0FDhly6UlmrXxmkK Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable This looks fine but it seems focused on writing a new module/project. = Most python work going into edk2 is part of existing code. 
I w= ould like to see additional documentation about how this applies to edk2 ba= setools.

* A flake8 config file could be added to basetools pyth= on. 
* Documentation of developer workflows with edk2 basetools<= br />* A plan for how to get edk2 basetools to meet these requirements
* A plan for automated patch verification of meeting these rules.
I have a rule of thumb for code guidelines.  I don't make any rules= unless I can enforce them without un-manageable burden.  
<= br />I also would rather see this type of documentation in the basetools py= thon folder.  There is no reason a developer should have to go looking= for this somewhere else within the tianocore site.  

= Finally, I would suggest we leverage an auto-formatter and provide the conf= ig file for that.  This reduces significant burden on the developer an= d keeps all contributes aligned.  

Thanks
Sean --ZfYp0FDhly6UlmrXxmkK--