public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <sean.brogan@microsoft.com>
To: Abner Chang <abner.chang@hpe.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI.
Date: Sat, 07 Mar 2020 14:13:36 -0800	[thread overview]
Message-ID: <10736.1583619216783439185@groups.io> (raw)
In-Reply-To: <20200304052607.31801-5-abner.chang@hpe.com>

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Tue, Mar 3, 2020 at 10:02 PM, Abner Chang wrote:

> 
> BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml

Web extdeps can have a hash so we are sure we get the expected file.  My opinion is for edk2 extdeps we should use this feature.

https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/usability/using_extdep.md#sha256-optional

The rest of the changes look good.
Thanks
Sean

[-- Attachment #2: Type: text/html, Size: 607 bytes --]

  reply	other threads:[~2020-03-07 22:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  5:26 [edk2/master PATCH RISC-V CI v1 0/6] RISC-V EDK2 CI configuration files Abner Chang
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 1/6] RiscVPlatformPkg: Add RiscVPlatformPkg yaml file for EDK2 CI Abner Chang
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 2/6] RiscVPkg: Add RiscVPkg " Abner Chang
2020-03-07 22:18   ` [edk2-devel] " Sean
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 3/6] MdeModulePkg: Revise MdeModulePkg yaml file for RISC-V " Abner Chang
2020-03-07 22:15   ` [edk2-devel] " Sean
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RISC-V architecture " Abner Chang
2020-03-07 22:13   ` Sean [this message]
2020-03-09  1:34     ` [edk2-devel] " Abner Chang
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 5/6] .azurepipelines: Add RISC-V architecture on " Abner Chang
2020-03-04  5:26 ` [edk2/master PATCH RISC-V CI v1 6/6] .pytool: " Abner Chang
2020-03-07 22:08   ` [edk2-devel] " Sean
2020-03-09  1:31     ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10736.1583619216783439185@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox