From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 13 Jun 2019 08:01:02 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 542A4B5C0B; Thu, 13 Jun 2019 15:00:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75A562B460; Thu, 13 Jun 2019 15:00:46 +0000 (UTC) Subject: Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: Ray Ni , Andrew Fish , Leif Lindholm , Michael D Kinney , David Woodhouse References: <20190527063656.9996-1-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <1078732d-ef74-0c9e-689c-44e9822c5c84@redhat.com> Date: Thu, 13 Jun 2019 17:00:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190527063656.9996-1-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 13 Jun 2019 15:00:59 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hello Hao, On 05/27/19 08:36, Wu, Hao A wrote: > ''' > Please note that this patch will be hold until all the below requirements > are met: > > A. edk2-stable201905 is created; > B. OvmfPkg has drop its usage of the legacy ISA stack (which includes > the IsaAcpiDxe driver); > C. UefiPayloadPkg has been updated to drop its consume to the > 8259InterruptControllerDxe driver. > ''' > > This patch itself will not be sent to the mailing list and is only > available at: > https://github.com/hwu25/edk2/tree/delete_framework > (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416) > > > Below modules will be removed from PcAtChipsetPkg: > * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf > * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf OvmfPkg's dependency on IsaAcpiDxe has been removed in commit 562688707145 ("OvmfPkg: Drop build flag USE_LEGACY_ISA_STACK and legacy ISA stack", 2019-06-11), so that's fine. The other two drivers (8259InterruptControllerDxe and 8254TimerDxe) have been copied under OvmfPkg for bug 1496. I haven't reviewed this series in detail, but based on the above, I'm fine with the removals, in general. Acked-by: Laszlo Ersek Thanks Laszlo > > They are considered legacy framework components and will no longer be used > after the removal of IntelFramework[Module]Pkg. > > Also, the unused (after the modules being removed) PCDs will be deleted in > package level DEC/UNI files. > > Cc: Ray Ni > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > > > Hao A Wu (1): > PcAtChipsetPkg: Remove framework modules > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 -- > PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +- > PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 -- > PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 -- > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 -- > PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------ > PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 ------- > PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 --------- > PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 ------------- > PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 -------------------- > PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ---------- > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 ----------- > PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------ > PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 - > PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 - > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 - > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 - > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 - > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 - > PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +- > 20 files changed, 2 insertions(+), 3078 deletions(-) > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni >