Re: [edk2-devel] [PATCH v2 0/7] EDK2-TEST TCG MOR Tests

["Stuart Yoder" <stuart.yoder@arm.com>]

On 1/30/24 5:23 PM, Abhimanyu Singh via groups.io wrote:
> Updates after feedback from Stuart <Stuart.Yoder@arm.com>
> 
> -add tests that checks if MOR variable can be deleted if
>   MORLOCK is in a lock state.
> -fix some grammar/spelling/capitalization errors.
> -relaxed some tests to work with current edk2 implementation.
> 
> Patch series v1:
> These tests support platform firmware that implement
> MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
> UEFI variables in accordance with TCG PC Platform Reset Attack
> Mitigation Specification.
> 
> The first 6/7 patches are split according to the six sections
> documented in the SCT spec document referenced below.
> 
> SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
> 
> Github PR: https://github.com/tianocore/edk2-test/pull/81

Hi Abhi,

A few things I saw when reviewing:

-The patches have Gerrit Change-Ids left in them. Can you delete those
  as they have no meaning upstream

-The code seems out of sync with the spec with respect to the test
  assertion numbers and GUIDs.  Probably the spec needs to be updated?

Thanks,
Stuart


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115466): https://edk2.groups.io/g/devel/message/115466
Mute This Topic: https://groups.io/mt/104065281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-