From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C788FD81542 for ; Wed, 14 Feb 2024 16:33:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BUV3BJFqBe5KygCQrmBtl8Aj4yzBTqRIGrXvjl99Kv8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707928406; v=1; b=idHE4NZPYNHL8wJG4BbRrSqbk0R8x+zLlK6+ZV1Fmo5dqA6oWwLVz0ghZehUJdQLXeX3TgR7 DFcBJaN4Zz2HNEi3sxDz9zC7jUIe3khp9xqGAvoooOlmptQCINohPP2tFM6zra2qLrcL5yXNVzy KQOzmaF6vpPrOUJmwG7drsGU= X-Received: by 127.0.0.2 with SMTP id DfQQYY7687511xxDoTrfTT9O; Wed, 14 Feb 2024 08:33:26 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.45438.1707928405693607893 for ; Wed, 14 Feb 2024 08:33:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DCABC1FB; Wed, 14 Feb 2024 08:34:05 -0800 (PST) X-Received: from [10.119.34.107] (unknown [10.119.34.107]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9AC303F762; Wed, 14 Feb 2024 08:33:24 -0800 (PST) Message-ID: <107a0ef5-0d42-41b2-9d35-a1ad28045352@arm.com> Date: Wed, 14 Feb 2024 10:33:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/7] EDK2-TEST TCG MOR Tests To: devel@edk2.groups.io, Abhi.Singh@arm.com Cc: G Edhaya Chandran , Barton Gao , Carolyn Gjertsen , Sunny Wang References: <20240130232332.235302-1-Abhi.Singh@arm.com> From: "Stuart Yoder" In-Reply-To: <20240130232332.235302-1-Abhi.Singh@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stuart.yoder@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 265DRv0npWq489nPglJqVOGex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=idHE4NZP; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) On 1/30/24 5:23 PM, Abhimanyu Singh via groups.io wrote: > Updates after feedback from Stuart >=20 > -add tests that checks if MOR variable can be deleted if > MORLOCK is in a lock state. > -fix some grammar/spelling/capitalization errors. > -relaxed some tests to work with current edk2 implementation. >=20 > Patch series v1: > These tests support platform firmware that implement > MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock > UEFI variables in accordance with TCG PC Platform Reset Attack > Mitigation Specification. >=20 > The first 6/7 patches are split according to the six sections > documented in the SCT spec document referenced below. >=20 > SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4374 >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4419 >=20 > Github PR: https://github.com/tianocore/edk2-test/pull/81 Hi Abhi, A few things I saw when reviewing: -The patches have Gerrit Change-Ids left in them. Can you delete those as they have no meaning upstream -The code seems out of sync with the spec with respect to the test assertion numbers and GUIDs. Probably the spec needs to be updated? Thanks, Stuart -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115466): https://edk2.groups.io/g/devel/message/115466 Mute This Topic: https://groups.io/mt/104065281/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-