From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59BD9211BFCB5 for ; Wed, 30 Jan 2019 06:09:29 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 06:09:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="314874314" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2019 06:09:26 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 485C5580550; Wed, 30 Jan 2019 06:09:24 -0800 (PST) Message-ID: <109f2fa1f40ce07244818837e297f4d291d66d59.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 15:09:22 +0100 In-Reply-To: <20181106175833.26964-18-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-18-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 14:09:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > GCC chokes on the unknown MSVC specific #pragmas used for suppressing > warnings, so remove them and use the INF BuildOptions section > instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 2 +- > IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > index 19dae9a0987a..9159e826ec45 100644 > --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > @@ -41,7 +41,7 @@ ENTRY_POINT = InitializeGigUNDIDriver > UNLOAD_IMAGE = GigUndiUnload > > [BuildOptions.common] > - MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG > + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /wd4244 /wd4206 > GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG > > [BuildOptions.X64] > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > index 4408b409a445..70f33811dd04 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > @@ -34,9 +34,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #include > #include > > -#pragma warning(disable : 4244) > -#pragma warning(disable : 4206) > - > #ifndef EFI_SPECIFICATION_VERSION > #define EFI_SPECIFICATION_VERSION 0x00020000 > #endif /* EFI_SPECIFICATION_VERSION */