From: "Laszlo Ersek" <lersek@redhat.com>
To: Star Zeng <star.zeng@intel.com>, devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Chandana Kumar <chandana.c.kumar@intel.com>,
Kevin Li <kevin.y.li@intel.com>
Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue
Date: Wed, 10 Jul 2019 18:08:21 +0200 [thread overview]
Message-ID: <10caf91a-4723-1abf-d3ae-2640a5b60baf@redhat.com> (raw)
In-Reply-To: <20190710114236.14800-1-star.zeng@intel.com>
On 07/10/19 13:42, Star Zeng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968
>
> We met assertion like below, it happens when there is only
> one processor.
>
> ASSERT_EFI_ERROR (Status = Not started)
> ASSERT [CpuFeaturesDxe] X:\XXX\XXX\RegisterCpuFeaturesLib\
> DxeRegisterCpuFeaturesLib.c(149): !EFI_ERROR (Status)
>
> The code should not call StartupAllAPs when there is only one processor.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Cc: Kevin Li <kevin.y.li@intel.com>
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> .../CpuFeaturesInitialize.c | 10 +++--
> .../DxeRegisterCpuFeaturesLib.c | 43 +++++++++++--------
> .../PeiRegisterCpuFeaturesLib.c | 11 +++--
> 3 files changed, 37 insertions(+), 27 deletions(-)
I'll skip this patch.
Thanks!
Laszlo
next prev parent reply other threads:[~2019-07-10 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 11:42 [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue Zeng, Star
2019-07-10 16:08 ` Laszlo Ersek [this message]
2019-07-11 1:59 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10caf91a-4723-1abf-d3ae-2640a5b60baf@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox