From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by mx.groups.io with SMTP id smtpd.web08.6102.1649335583646989091
 for <devel@edk2.groups.io>;
 Thu, 07 Apr 2022 05:46:23 -0700
Authentication-Results: mx.groups.io;
 dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OTFaCDfG;
 spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.20, mailfrom: maciej.rabeda@linux.intel.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649335583; x=1680871583;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=gxVhA6S577+SnHFexZlyH6z4XVDRNwzzOQlVp4f3Klg=;
  b=OTFaCDfGWfgg6h2CzREaiOSIpq8MgjnrdREpUY669ew+pjrXxDmqBl0r
   pskOwCLsfmkVGNDlr9cAh3Mr7hIM0Q8qcbCPow9aXw+/Jm1VixjMZ0UAh
   BdQs2uixUP3OqjGbcRto1u/yIGqYbYStAQvpRWoN3xX8cMGLBLiMF7SHs
   VTkYNO85NmVcTCqyrmXwUQMZdiO6+zNxh2dlf41W7U6/+Fa9GCj0jgjFd
   Ip5Sjg8a6y+PNQ5ptwDuAE3LZzm3wtn2m2rWz4KVdW/EkxUy3b8nbVaDU
   acTFEkLwaJRDLHpxIluXtW1GVB/9OPRvsyAR06FEDckwgfYbgsxL7sPqY
   w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10309"; a="248839842"
X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; 
   d="scan'208";a="248839842"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 05:46:22 -0700
X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; 
   d="scan'208";a="506135452"
Received: from mrabeda-mobl2.ger.corp.intel.com (HELO [10.213.27.116]) ([10.213.27.116])
  by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 05:46:20 -0700
Message-ID: <10f3672d-9e0c-61be-344d-9b8a2675942e@linux.intel.com>
Date: Thu, 7 Apr 2022 14:46:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAwLzVdIEh0dHAgRml4ZXMgKFRha2UgVHdvKQ==?=
To: Gerd Hoffmann <kraxel@redhat.com>, devel@edk2.groups.io,
 gaoliming@byosoft.com.cn
Cc: osteffen@redhat.com, jiaxin.wu@intel.com, siyuan.fu@intel.com
References: <20220304130403.47832-1-osteffen@redhat.com>
 <20220322133008.152037-1-osteffen@redhat.com>
 <01f201d83e53$ff55a440$fe00ecc0$@byosoft.com.cn>
 <20220407095750.rqwjlf3cvcj2gy5f@sirius.home.kraxel.org>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
In-Reply-To: <20220407095750.rqwjlf3cvcj2gy5f@sirius.home.kraxel.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Gerd,

Sorry, I can spare very little time for reviews these days...

I am alright with the patch with two cosmetic changes.

1. In HttpResponseWorker():

     if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen 
("HTTP/1.0")) == 0) {
       DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting 
Connection close.\n"));
       HttpInstance->ConnectionClose = TRUE;
     }

I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need 
to call a AsciiStrLen every time this flow is executed, it is easily a 
compile-time thing.

2. In HttpResponseWorker(), index -> Index, coding standard.

I can merge this patch with changes above one I get an ACK from you.

Thanks,
Maciej

On 7 kwi 2022 11:57, Gerd Hoffmann wrote:
> On Wed, Mar 23, 2022 at 09:19:09AM +0800, gaoliming wrote:
>> Maciej, Jiaxin and Siyuan:
>>    Can you help review this fix?
> Ping.  Anything blocking the merge of these bugfixes?
>
> thanks,
>    Gerd
>