From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Barkelew, Bret" <bret.barkelew@microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Chris Fernald <chris.fernald@outlook.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Kubacki, Michael" <michael.kubacki@microsoft.com>,
Oliver Steffen <osteffen@redhat.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
Date: Thu, 30 Mar 2023 14:10:33 -0600 [thread overview]
Message-ID: <10f90a64-374b-3ccc-4660-ffdb7ce18937@bsdio.com> (raw)
In-Reply-To: <SA2PR11MB49381E547B91B5FC24373857D28E9@SA2PR11MB4938.namprd11.prod.outlook.com>
Good idea. I'll send out a v2 patch with that change.
On 3/30/23 2:09 PM, Kinney, Michael D wrote:
> Rebecca,
>
> In order to avoid issues with the order or timing or merges, could
> CFLAGS be added in one set of patches and then later remove BUILD_CLAGS
> in a second set of patches?
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
>> Sent: Thursday, March 30, 2023 1:05 PM
>> To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris
>> Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>;
>> Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>> This should be merged at the same time as the edk2 patch that supports
>> passing CC and CXX to make when building BaseTools.
>>
>> Rebecca Cran (1):
>> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>> edk2basetools/Workspace/DscBuildData.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --
>> 2.34.1
>>
>>
>>
>>
>>
prev parent reply other threads:[~2023-03-30 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 20:04 [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change Rebecca Cran
2023-03-30 20:04 ` [PATCH edk2-basetools 1/1] " Rebecca Cran
2023-03-30 20:09 ` [edk2-devel] [PATCH edk2-basetools 0/1] " Michael D Kinney
2023-03-30 20:10 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f90a64-374b-3ccc-4660-ffdb7ce18937@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox