From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A3DC720356866 for ; Wed, 15 Nov 2017 08:19:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A38A761D05; Wed, 15 Nov 2017 16:23:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-47.rdu2.redhat.com [10.10.122.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id E03ED60F86; Wed, 15 Nov 2017 16:23:23 +0000 (UTC) To: Yonghong Zhu , edk2-devel@lists.01.org Cc: Liming Gao References: <1510638762-6604-1-git-send-email-yonghong.zhu@intel.com> From: Laszlo Ersek Message-ID: <1101ea54-bd52-6add-7065-f126d1737d96@redhat.com> Date: Wed, 15 Nov 2017 17:23:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510638762-6604-1-git-send-email-yonghong.zhu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 15 Nov 2017 16:23:24 +0000 (UTC) Subject: Re: [Patch] BaseTools: Fix the bug to collect source files per build rule family X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 16:19:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hello Yonghong, On 11/14/17 06:52, Yonghong Zhu wrote: > when collect source files list we should also consider build rule > family. what bug does this patch fix? I guess the bug is that something is missed / not done, because changes to the build rules are not noticed? Can you please elaborate in the commit message? Thanks! Laszlo > > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py > index b3e7089..008ad8e 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3265,17 +3265,17 @@ class ModuleAutoGen(AutoGen): > # match tool chain > if F.TagName not in ("", "*", self.ToolChain): > EdkLogger.debug(EdkLogger.DEBUG_9, "The toolchain [%s] for processing file [%s] is found, " > "but [%s] is needed" % (F.TagName, str(F), self.ToolChain)) > continue > - # match tool chain family > - if F.ToolChainFamily not in ("", "*", self.ToolChainFamily): > + # match tool chain family or build rule family > + if F.ToolChainFamily not in ("", "*", self.ToolChainFamily, self.BuildRuleFamily): > EdkLogger.debug( > EdkLogger.DEBUG_0, > "The file [%s] must be built by tools of [%s], " \ > - "but current toolchain family is [%s]" \ > - % (str(F), F.ToolChainFamily, self.ToolChainFamily)) > + "but current toolchain family is [%s], buildrule family is [%s]" \ > + % (str(F), F.ToolChainFamily, self.ToolChainFamily, self.BuildRuleFamily)) > continue > > # add the file path into search path list for file including > if F.Dir not in self.IncludePathList and self.AutoGenVersion >= 0x00010005: > self.IncludePathList.insert(0, F.Dir) >