From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.1633.1627928643945402234 for ; Mon, 02 Aug 2021 11:24:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=AL4klC7L; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 62BAB208AB04; Mon, 2 Aug 2021 11:24:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 62BAB208AB04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1627928643; bh=MAFAUXTaXiMagYiLBx7B5ksn26eDCq6JLJDUonWJwtY=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=AL4klC7L4L1C3746T/H3+xRz3KmYDVv2WTVy17+YEveaTyvBhB0CzEyQeYw27kp8K G/2TN6aUF30yFBHXdyMulDul1mlztwhBhLsSwidpo2L3nPWF9XMXV8gLAo1ExRwkZ7 /EwtOyZNWtCdMCa6COx54pFLKrVx3+lsBBxcyQ1o= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 00/41] Consolidate SpiFlashCommonLib instances From: "Michael Kubacki" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" Cc: "Agyeman, Prince" , "Chiu, Chasel" , "Kethi Reddy, Deepika" , "Dong, Eric" , "Luo, Heng" , Jeremy Soller , "Esakkithevar, Kathappan" , Liming Gao , "Chaganty, Rangasai V" References: <20210625212120.235-1-mikuback@linux.microsoft.com> <94f70b88-5eb6-ba12-c4ce-dbe78948ed9c@linux.microsoft.com> Message-ID: <110fa8e7-62ee-3e2b-b7b1-d5c538f29e14@linux.microsoft.com> Date: Mon, 2 Aug 2021 14:24:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <94f70b88-5eb6-ba12-c4ce-dbe78948ed9c@linux.microsoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Nate, Does BoardMtOlympus in edk2-platforms/master build for you? It looks like some additional microcode patches were added and the=20 microcode FV was not expanded. Generating MICROCODE_FV FV Return Value =3D 2 GenFv: ERROR 3000: Invalid the required fv image size 0x22460 exceeds the set fv image size 0x10000 - Michael On 7/28/2021 8:08 PM, Michael Kubacki wrote: > Sure. These packages were added to edk2-platforms throughout the=20 > lifetime of this patch series. >=20 > Hopefully this is the last rebase... >=20 > Regards, > Michael >=20 > On 7/28/2021 7:58 PM, Desimone, Nathaniel L wrote: >> Hi Michael, >> >> The change content looks good. However, after applying your patch=20 >> series PurleyOpenBoardPkg and WhitleyOpenBoardPkg no longer compile.=20 >> Can you please fix these build errors? >> >> For your reference, these are the tests that I ran: >> >> build_bios.py -p BoardMtOlympus -t VS2015x86 -d >> build_bios.py -p WilsonCityRvp -t VS2015x86 -d >> >> Thanks, >> Nate >> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of Michae= l >>> Kubacki >>> Sent: Friday, June 25, 2021 2:21 PM >>> To: devel@edk2.groups.io >>> Cc: Agyeman, Prince ; Chiu, Chasel >>> ; Kethi Reddy, Deepika >>> ; Dong, Eric ; Lu= o, >>> Heng ; Jeremy Soller ; >>> Esakkithevar, Kathappan ; Liming Ga= o >>> ; Desimone, Nathaniel L >>> ; Chaganty, Rangasai V >>> >>> Subject: [edk2-devel] [edk2-platforms][PATCH v4 00/41] Consolidate >>> SpiFlashCommonLib instances >>> >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >>> >>> SpiFlashCommonLib is duplicated in multiple places across the=20 >>> MinPlatform >>> design in edk2-platforms. I'm planning to build some additional=20 >>> functionality >>> on top of SpiFlashCommonLib and, ideally, this duplication will be >>> consolidated into a single instance usable across all current library= =20 >>> consumers. >>> >>> This patch series focuses on consolidating the various SpiFlashCommon= Lib >>> instances as agreed upon in=20 >>> https://edk2.groups.io/g/devel/message/71701. >>> >>> Read the BZ for more general background around this series. >>> >>> I only have an UpXtreme board on hand so maintainers/reviewers of oth= er >>> board packages should test these changes on those boards. >>> >>> V4 changes: >>> - Assigned new GUID values to the PCH SPI PPI and Protocols to >>> =C2=A0=C2=A0 differentiate from previous instances. This was done bec= ause >>> =C2=A0=C2=A0 the interface changed to identify SPI flash regions by G= UID. >>> >>> V3 changes: >>> - Added support to IntelSiliconPkg to identify flash regions by GUID = as >>> =C2=A0=C2=A0 requested in v2 review feedback. >>> V2 changes: >>> - Rebased patch series on current edk2-platforms master (32183bdaa91) >>> >>> Note: Previous patch series only received a couple review comments af= ter >>> being on the mailing list for over 2 months. Please be respectful of >>> contributors time and efforts and review in a timely manner. >>> >>> Cc: Agyeman Prince >>> Cc: Chasel Chiu >>> Cc: Deepika Kethi Reddy >>> Cc: Eric Dong >>> Cc: Heng Luo >>> Cc: Jeremy Soller >>> Cc: Kathappan Esakkithevar >>> Cc: Liming Gao >>> Cc: Nate DeSimone >>> Cc: Rangasai V Chaganty >>> Signed-off-by: Michael Kubacki Michae= l >>> Kubacki (41): >>> =C2=A0=C2=A0 CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.= dec entry >>> =C2=A0=C2=A0 WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPk= g.dec entry >>> =C2=A0=C2=A0 CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GU= ID to INF >>> =C2=A0=C2=A0 IntelSiliconPkg: Add BIOS area base address and size PCD= s >>> =C2=A0=C2=A0 IntelSiliconPkg: Add microcode FV PCDs >>> =C2=A0=C2=A0 IntelSiliconPkg: Add PCH SPI PPI >>> =C2=A0=C2=A0 IntelSiliconPkg: Add PCH SPI Protocol >>> =C2=A0=C2=A0 IntelSiliconPkg: Add SpiFlashCommonLib >>> =C2=A0=C2=A0 IntelSiliconPkg: Add SmmSpiFlashCommonLib >>> =C2=A0=C2=A0 IntelSiliconPkg: Add MM SPI FVB services >>> =C2=A0=C2=A0 CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and= ucode PCDs >>> =C2=A0=C2=A0 KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and = ucode PCDs >>> =C2=A0=C2=A0 SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and uc= ode PCDs >>> =C2=A0=C2=A0 TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and= ucode PCDs >>> =C2=A0=C2=A0 WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area a= nd ucode PCDs >>> =C2=A0=C2=A0 CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and = ucode PCDs >>> =C2=A0=C2=A0 KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and uc= ode PCDs >>> =C2=A0=C2=A0 SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode = PCDs >>> =C2=A0=C2=A0 TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and u= code PCDs >>> =C2=A0=C2=A0 CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCo= mmonLib >>> =C2=A0=C2=A0 KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCom= monLib >>> =C2=A0=C2=A0 SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommo= nLib >>> =C2=A0=C2=A0 TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCo= mmonLib >>> =C2=A0=C2=A0 WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlash= CommonLib >>> =C2=A0=C2=A0 MinPlatformPkg: Remove SpiFvbService modules >>> =C2=A0=C2=A0 CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib >>> =C2=A0=C2=A0 KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib >>> =C2=A0=C2=A0 SimicsIch10Pkg: Remove SmmSpiFlashCommonLib >>> =C2=A0=C2=A0 TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib >>> =C2=A0=C2=A0 MinPlatformPkg: Remove SpiFlashCommonLibNull >>> =C2=A0=C2=A0 KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add=20 >>> IntelSiliconPkg.dec >>> =C2=A0=C2=A0 CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol fr= om package >>> =C2=A0=C2=A0 KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from= package >>> =C2=A0=C2=A0 SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package >>> =C2=A0=C2=A0 TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol fro= m package >>> =C2=A0=C2=A0 IntelSiliconPkg: Add flash region GUIDs >>> =C2=A0=C2=A0 IntelSiliconPkg: Identify flash regions by GUID >>> =C2=A0=C2=A0 CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash= regions by >>> =C2=A0=C2=A0=C2=A0=C2=A0 GUID >>> =C2=A0=C2=A0 KabylakeSiliconPkg: Identify flash regions by GUID >>> =C2=A0=C2=A0 SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regio= ns by GUID >>> =C2=A0=C2=A0 TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash = regions by >>> =C2=A0=C2=A0=C2=A0=C2=A0 GUID >>> >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiComm= onLi=20 >>> >>> b/SpiCommon.c = =20 >>> | 144 ++++++++-- >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= piF >>> lashCommon.c = =20 >>> | 196 ------------- >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= piF >>> lashCommonSmmLib.c = =20 >>> |=C2=A0 54 ---- >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/FvbInfo.c >>> |=C2=A0=C2=A0 0 >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceCom=20 >>> >>> mon.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | =20 >>> 4 +- >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceMm=20 >>> >>> .c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | =20 >>> 8 +- >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceStan=20 >>> >>> daloneMm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 0 >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceTrad=20 >>> >>> itionalMm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 0 >>> >>> Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/Spi >>> FlashCommonSmmLib.c =3D> >>> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas= hC >>> ommonLib.c |=C2=A0=C2=A0 2 +- >>> =C2=A0 {Platform/Intel/TigerlakeOpenBoardPkg =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashC= om >>> mon.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 7 +- >>> =C2=A0 {Platform/Intel/MinPlatformPkg/Flash =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlash= Comm=20 >>> >>> onLibNull.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 12 +- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/SecureMemoryMapConfiguratio= n. >>> c = =20 >>> | 106 ++++++- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Spi= Fla >>> shCommon.c = =20 >>> | 196 ------------- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Spi= Fla >>> shCommonSmmLib.c = =20 >>> |=C2=A0 54 ---- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonL= ib/ >>> SpiCommon.c = =20 >>> | 140 +++++++-- >>> >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCom= m >>> on.c = =20 >>> | 194 ------------- >>> >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCom= m >>> onSmmLib.c = =20 >>> |=C2=A0 54 ---- >>> >>> Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= m >>> mon.c = =20 >>> | 165 ++++++++--- >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c >>> |=C2=A0=C2=A0 4 +- >>> >>> Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiC= ommon=20 >>> >>> Lib/SpiCommon.c = =20 >>> | 176 >>> ++++++++++-- >>> =C2=A0 Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/Flash >>> MapInclude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d >>> sc = =20 >>> |=C2=A0=C2=A0 7 +- >>> >>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f >>> df = =20 >>> |=C2=A0 38 +-- >>> >>> Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi= b/ >>> PeiPolicyUpdateLib.inf = =20 >>> |=C2=A0=C2=A0 2 +- >>> >>> Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitD= xe.i=20 >>> >>> nf = =20 >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIn >>> clude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.ds= c >>> |=C2=A0=C2=A0 7 +- >>> =C2=A0 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fd= f >>> |=C2=A0 40 +-- >>> >>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMa >>> pInclude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= dsc >>> |=C2=A0=C2=A0 7 +- >>> =C2=A0 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= fdf >>> |=C2=A0 40 +-- >>> >>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSi= lic >>> onPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = =20 >>> | >>> 4 +- >>> >>> Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/= PeiS=20 >>> >>> erialPortLibSpiFlash.inf = =20 >>> |=C2=A0=C2=A0 1 + >>> =C2=A0 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLi= b.h >>> |=C2=A0 98 ------- >>> =C2=A0 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec >>> |=C2=A0=C2=A0 2 - >>> =C2=A0 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >>> |=C2=A0=C2=A0 6 - >>> =C2=A0 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.d= sc >>> |=C2=A0=C2=A0 6 +- >>> =C2=A0 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df >>> |=C2=A0=C2=A0 2 +- >>> =C2=A0 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df.inc >>> |=C2=A0=C2=A0 8 +- >>> =C2=A0 Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf >>> |=C2=A0=C2=A0 8 +- >>> >>> Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashM= a >>> pInclude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPk= g.dsc >>> |=C2=A0=C2=A0 7 +- >>> =C2=A0 Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPk= g.fdf >>> |=C2=A0 40 +-- >>> =C2=A0 Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Li >>> b/PeiPolicyUpdateLib.inf = =20 >>> |=C2=A0=C2=A0 1 - >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyIni= tDx >>> e.inf = =20 >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMa >>> pInclude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/ >>> PeiMultiBoardInitPreMemLib.inf = =20 >>> |=C2=A0=C2=A0 2 +- >>> =C2=A0 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.d= sc >>> |=C2=A0=C2=A0 7 +- >>> =C2=A0 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.f= df >>> |=C2=A0 38 +-- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/F >>> lashMapInclude.fdf = =20 >>> |=C2=A0=C2=A0 4 +- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk >>> g.dsc = =20 >>> |=C2=A0=C2=A0 7 +- >>> >>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk >>> g.fdf = =20 >>> |=C2=A0 38 +-- >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpu= Policy=20 >>> >>> Lib.inf = =20 >>> |=C2=A0=C2=A0 4 +- >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Private/Library/PchSpi= Comm=20 >>> >>> onLib.h = =20 >>> |=C2=A0 16 +- >>> =C2=A0 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSp= iLib.inf >>> |=C2=A0=C2=A0 1 + >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiComm= onLi=20 >>> >>> b/BasePchSpiCommonLib.inf = =20 >>> |=C2=A0 13 + >>> >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= m >>> mSpiFlashCommonLib.inf = =20 >>> |=C2=A0 51 ---- >>> =C2=A0 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf >>> |=C2=A0=C2=A0 1 + >>> =C2=A0 Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec >>> |=C2=A0=C2=A0 8 - >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceCom=20 >>> >>> mon.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2= =A0 0 >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceMm=20 >>> >>> .h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 0 >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceSm=20 >>> >>> m.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | = =20 >>> 6 +- >>> =C2=A0 {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceStan=20 >>> >>> daloneMm.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 6 +- >>> =C2=A0 Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h >>> |=C2=A0 45 +++ >>> =C2=A0 Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> >>> IntelSiliconPkg}/Include/Library/SpiFlashCommonLib.h >>> |=C2=A0=C2=A0 2 +- >>> =C2=A0 Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D>=20 >>> IntelSiliconPkg}/Include/Ppi/Spi.h >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> >>> IntelSiliconPkg}/Include/Protocol/Spi.h >>> |=C2=A0 39 +-- >>> =C2=A0 Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec >>> |=C2=A0 37 +++ >>> =C2=A0 Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc >>> |=C2=A0 17 ++ >>> =C2=A0 {Platform/Intel/TigerlakeOpenBoardPkg =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFla= sh >>> CommonLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 24 +- >>> =C2=A0 {Platform/Intel/MinPlatformPkg/Flash =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlash= Comm=20 >>> >>> onLibNull.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 3 +- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPo= licyLi=20 >>> >>> b.inf = =20 >>> |=C2=A0=C2=A0 4 +- >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf >>> |=C2=A0 12 +- >>> =20 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLi= b.h >>> |=C2=A0 98 ------- >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h >>> |=C2=A0 26 -- >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h >>> | 293 ------------------- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/IncludePrivate/Library/PchSpiCom= monL=20 >>> >>> ib.h = =20 >>> |=C2=A0 20 +- >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiL= ib.inf >>> |=C2=A0=C2=A0 1 + >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Smm >>> SpiFlashCommonLib.inf = =20 >>> |=C2=A0 53 ---- >>> >>> Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonL= ib/ >>> BasePchSpiCommonLib.inf = =20 >>> |=C2=A0 11 + >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf >>> |=C2=A0=C2=A0 1 + >>> =C2=A0 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec >>> |=C2=A0 13 +- >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec >>> |=C2=A0 11 - >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCommonLib= .h >>> |=C2=A0 98 ------- >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h >>> | 295 ------------------- >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiComm= onLib.h >>> |=C2=A0 46 +-- >>> >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlash= C >>> ommonLib.inf = =20 >>> |=C2=A0 50 ---- >>> >>> Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BaseP= ch >>> SpiCommonLib.inf = =20 >>> |=C2=A0 16 +- >>> =C2=A0 Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf >>> |=C2=A0=C2=A0 3 +- >>> =C2=A0 Silicon/Intel/TigerlakeSiliconPkg/Include/Protocol/Spi.h >>> | 301 -------------------- >>> >>> Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/IncludePrivate/Library/= SpiCom=20 >>> >>> monLib.h = =20 >>> |=C2=A0 16 +- >>> >>> Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiC= ommon=20 >>> >>> Lib/BaseSpiCommonLib.inf = =20 >>> |=C2=A0 19 +- >>> =C2=A0 Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf >>> |=C2=A0=C2=A0 1 + >>> =C2=A0 Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTg= l.inf >>> |=C2=A0=C2=A0 1 + >>> =C2=A0 Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec >>> |=C2=A0=C2=A0 8 - >>> =C2=A0 98 files changed, 1083 insertions(+), 2567 deletions(-)=C2=A0 = delete=20 >>> mode 100644 >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= piF >>> lashCommon.c >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= piF >>> lashCommonSmmLib.c >>> =C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/FvbInfo.c=20 >>> (100%) >>> rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceCom=20 >>> >>> mon.c (96%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceMm=20 >>> >>> .c (94%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceStan=20 >>> >>> daloneMm.c (100%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceTrad=20 >>> >>> itionalMm.c (100%)=C2=A0 rename >>> Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/Spi >>> FlashCommonSmmLib.c =3D> >>> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas= hC >>> ommonLib.c (90%)=C2=A0 rename {Platform/Intel/TigerlakeOpenBoardPkg =3D= > >>> Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashC= om >>> mon.c (93%)=C2=A0 rename {Platform/Intel/MinPlatformPkg/Flash =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlash= Comm=20 >>> >>> onLibNull.c (83%)=C2=A0 delete mode 100644 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Spi= Fla >>> shCommon.c >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Spi= Fla >>> shCommonSmmLib.c >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCom= m >>> on.c >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCom= m >>> onSmmLib.c >>> =C2=A0 delete mode 100644 >>> Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/S= m >>> mSpiFlashCommonLib.inf >>> =C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceCom=20 >>> >>> mon.h (100%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceMm=20 >>> >>> .h (100%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceSm=20 >>> >>> m.inf (88%)=C2=A0 rename {Platform/Intel/MinPlatformPkg =3D> >>> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServ= iceStan=20 >>> >>> daloneMm.inf (88%)=C2=A0 create mode 100644 >>> Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h >>> =C2=A0 rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> >>> IntelSiliconPkg}/Include/Library/SpiFlashCommonLib.h (96%)=C2=A0 rena= me >>> Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D>=20 >>> IntelSiliconPkg}/Include/Ppi/Spi.h >>> (85%)=C2=A0 rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> >>> IntelSiliconPkg}/Include/Protocol/Spi.h (89%)=C2=A0 rename >>> {Platform/Intel/TigerlakeOpenBoardPkg =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFla= sh >>> CommonLib.inf (67%)=C2=A0 rename {Platform/Intel/MinPlatformPkg/Flash= =3D> >>> Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlash= Comm=20 >>> >>> onLibNull.inf (91%)=C2=A0 delete mode 100644 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLi= b.h >>> =C2=A0 delete mode 100644=20 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/Smm >>> SpiFlashCommonLib.inf >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCommonLib.h >>> =C2=A0 delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Protoc= ol/Spi.h >>> =C2=A0 delete mode 100644 >>> Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlash= C >>> ommonLib.inf >>> =C2=A0 delete mode 100644=20 >>> Silicon/Intel/TigerlakeSiliconPkg/Include/Protocol/Spi.h >>> >>> --=20 >>> 2.28.0.windows.1 >>> >>> >>> >>> -=3D-=3D-=3D-=3D-=3D-=3D >>> Groups.io Links: You receive all messages sent to this group. >>> View/Reply Online (#77097): https://edk2.groups.io/g/devel/message/77= 097 >>> Mute This Topic: https://groups.io/mt/83794775/1767664 >>> Group Owner: devel+owner@edk2.groups.io >>> Unsubscribe: https://edk2.groups.io/g/devel/unsub >>> [nathaniel.l.desimone@intel.com] >>> -=3D-=3D-=3D-=3D-=3D-=3D >>>