On Mon, Dec 14, 2020 at 06:42 AM, Sughosh Ganu wrote:

> 
> + INT32 Ret;

Remove trailing space.

On Mon, Dec 14, 2020 at 06:42 AM, Sughosh Ganu wrote:

> 
> + if (Status == RETURN_UNSUPPORTED)
> + Ret = -1;
> + else if (Status == RETURN_INVALID_PARAMETER)
> + Ret = -2;
> + else
> + Ret = 0;

'{' and '}' are required for if statements, see https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming#5-7-3-4-1-the-if-statement-shall-be-followed-by-a-space-and-then-the-open-parenthesis

Also, LocateStandaloneMmCorePeCoffData() can return EFI_NOT_FOUND. Similarly, other error codes could also be returned and would need to be mapped.
Would it be better to have a function that does the conversion/mapping?

Regards,

Sami Mujawar