On Mon, Dec 14, 2020 at 06:42 AM, Sughosh Ganu wrote:<br />
<blockquote>+ INT32 Ret;</blockquote>
Remove trailing space.<br /><br />On Mon, Dec 14, 2020 at 06:42 AM, Sughosh Ganu wrote:<br />
<blockquote>+ if (Status == RETURN_UNSUPPORTED)<br />+ Ret = -1;<br />+ else if (Status == RETURN_INVALID_PARAMETER)<br />+ Ret = -2;<br />+ else<br />+ Ret = 0;</blockquote>
'{' and '}' are required for if statements, see <a href="https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming#5-7-3-4-1-the-if-statement-shall-be-followed-by-a-space-and-then-the-open-parenthesis" target="_blank" rel="noopener">https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming#5-7-3-4-1-the-if-statement-shall-be-followed-by-a-space-and-then-the-open-parenthesis</a><br /><br />Also, <span style="color: #000000;">LocateStandaloneMmCorePeCoffData() can return </span><span style="color: #008000;">EFI_NOT_FOUND. </span>Similarly, other error codes could also be returned and would need to be mapped.<br />Would it be better to have a function that does the conversion/mapping?<br /><br />Regards,<br /><br />Sami Mujawar