From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4704.1622108403169409019 for ; Thu, 27 May 2021 02:40:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hM03jS7k; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622108402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlR+/B7e1UwXNaGqQGi/2iWKTRJrtVs1zddL/KtThnI=; b=hM03jS7kZ4ZDXuM0mw/qLvSv+Aihf+fuCxAJquH8RnL75TV1bGiVX0lmJf974/QmpY4jTD 2bHgHT4UI1kJhDnwmuD6tS5lkasQXUNAy7jXksnquRGRo1y+y7VATwmWty7VOjJQzb8f40 Md19rkX20d63Up3z0JzghySXz2fqSeY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-KnVgb939MsizvPouY71qkw-1; Thu, 27 May 2021 05:39:58 -0400 X-MC-Unique: KnVgb939MsizvPouY71qkw-1 Received: by mail-wm1-f71.google.com with SMTP id r1-20020a05600c35c1b029018ec2043223so14711wmq.7 for ; Thu, 27 May 2021 02:39:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SlR+/B7e1UwXNaGqQGi/2iWKTRJrtVs1zddL/KtThnI=; b=C6LY7qsJdRTzcAbV0UmoamQeT9wWFAGN93voTjp1hMvbWkUvsB0NK3c/V8dfjAae85 8dwHojW8GYQpPsgPlG7jXz+F7oWr+9p/hs4Wh5upq/C1OZJ6Yd2ZT9GneT5QBO7t0gSS XQ5kd7rEjhv44LwMBy6gzr0FRuMOCwCbgZKYva7KuX63RuKAx6dUDW4VuuaYvuMePJDl 8i4lHnBWAmKcR0B6WxbT9Hqx2C6DwlG7BYanPfAW63McBZIybFJXtNyt5Jy+m4nurpSv 4wKnWDGYSqbFEoXGRLxtyBtNgzuDE1I9eCVpm7YwOZD2qz0Zru8zBaFVAQESVFWVzLNe Bhig== X-Gm-Message-State: AOAM533si7M+FAjen2SCqtgB8GIh/JrRpyHDhqfbGu3KCeNYEH6p4HTr nMFDx0ng5Ampz2mCCMo8D/5xq1IEYa4VM/YShhc0pHKqEkAv8bY6Jw8omGMtAVDxxtC4dlHfRwq GrSrWvM/foNThaQ== X-Received: by 2002:a05:600c:2d89:: with SMTP id i9mr7375900wmg.139.1622108397341; Thu, 27 May 2021 02:39:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNbN+nZMeSQTCiT2pS5rCLDZZoQPg3a0fbd7QBsoW9NUCyqjeYgXPXIu11yKjAj7ZOIN7XCQ== X-Received: by 2002:a05:600c:2d89:: with SMTP id i9mr7375876wmg.139.1622108397090; Thu, 27 May 2021 02:39:57 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id y14sm9716652wmj.37.2021.05.27.02.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 02:39:56 -0700 (PDT) Subject: Re: [PATCH 15/43] OvmfPkg/XenAcpiPlatformDxe: remove the InstallAcpiTable() helper function To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-16-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <111eceea-cafa-83e7-861e-a76f73f2adad@redhat.com> Date: Thu, 27 May 2021 11:39:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-16-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The InstallAcpiTable() helper function buys us nothing. Reduce code > complexity by removing the function. > > This patch is best viewed with "git show -b". > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.h | 9 --- > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.c | 30 ++-------- > OvmfPkg/XenAcpiPlatformDxe/Xen.c | 60 ++++++++++---------- > 3 files changed, 36 insertions(+), 63 deletions(-) Reviewed-by: Philippe Mathieu-Daude