From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.7533.1581043660574586911 for ; Thu, 06 Feb 2020 18:47:40 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2020 18:47:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,411,1574150400"; d="scan'208";a="225236571" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 06 Feb 2020 18:47:39 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Feb 2020 18:47:39 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 7 Feb 2020 10:47:37 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 7 Feb 2020 10:47:37 +0800 From: "Bob Feng" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , "Gao, Liming" Subject: Re: [Patch 2/4] BaseTools/PcdValueCommon: Fix 64-bit host compiler error Thread-Topic: [Patch 2/4] BaseTools/PcdValueCommon: Fix 64-bit host compiler error Thread-Index: AQHV3UIxbQMG9zR8Ck2EdyqjbDedE6gPB0sw Date: Fri, 7 Feb 2020 02:47:37 +0000 Message-ID: <112c3704269c403081f64bc2ebdc96d3@intel.com> References: <20200206230715.15564-1-michael.d.kinney@intel.com> <20200206230715.15564-3-michael.d.kinney@intel.com> In-Reply-To: <20200206230715.15564-3-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjY2YjRkZDktZjI1Zi00OTU4LTllMWItNTNlOTU4MGZkMjgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia0JaZ1wvNU52VGVuV3NwVGZGclNTZDExVHFBcWxzWEpVeTZPMFBURHBPandCVTBDM3BiXC9uNktPdHJUOUNCbVFXIn0= dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Kinney, Michael D =20 Sent: Friday, February 7, 2020 7:07 AM To: devel@edk2.groups.io Cc: Sean Brogan ; Feng, Bob C ; Gao, Liming Subject: [Patch 2/4] BaseTools/PcdValueCommon: Fix 64-bit host compiler err= or From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=3D2496 Cc: Sean Brogan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Michael D Kinney --- BaseTools/Source/C/Common/PcdValueCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/= C/Common/PcdValueCommon.c index 42e3581707..98023e8786 100644 --- a/BaseTools/Source/C/Common/PcdValueCommon.c +++ b/BaseTools/Source/C/Common/PcdValueCommon.c @@ -478,7 +478,7 @@ Returns: // // Read all of the file contents. // - BytesRead =3D fread (*FileBuffer, sizeof (UINT8), *FileSize, InputFile); + BytesRead =3D (UINT32)fread (*FileBuffer, sizeof (UINT8), *FileSize, Inp= utFile); if (BytesRead !=3D *FileSize * sizeof (UINT8)) { fprintf (stderr, "Error reading the input file %s\n", InputFileName); fclose (InputFile); --=20 2.21.0.windows.1