From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs To: Michael D Kinney ,devel@edk2.groups.io From: scott.wiginton@hpe.com X-Originating-Location: Texas, US (15.203.233.78) X-Originating-Platform: Windows Chrome 77 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 18 Oct 2019 14:52:11 -0700 References: In-Reply-To: Message-ID: <11551.1571435531558989546@groups.io> Content-Type: multipart/alternative; boundary="omBM6jda7MKZeqcj5327" --omBM6jda7MKZeqcj5327 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, I'm not sure that I agree with your last statement.=C2=A0 The says that Ha= rdwareInstance is "Only present in version 3 or higher" in reference to the= = =C2=A0EFI_FIRMWARE_IMAGE_DESCRIPTOR.=C2=A0 Isn't that the point of the=C2= =A0DescriptorVersion parameter in FMP.GetImageInfo?=C2=A0 To know if that = field is event valid or not.=C2=A0 The function in question even looks at t= his passed in FW image descriptor version (though the parameter is called F= mpVersion).=C2=A0 The code just sets it to 0 if the FmpVersion is < 3.=C2= =A0 If one or more devices producing FMPs in the system do not support FW = image descriptor 3 or later, then this will cause an ASSERT. Thanks, SWig --omBM6jda7MKZeqcj5327 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael,

I'm not sure that I agree with your last statement.&= nbsp; The says that HardwareInstance is "Only present in version 3 or highe= r" in reference to the EFI_FIRMWARE_IMAGE_DESCRIPTOR.  Isn't that= the point of the DescriptorVersion parameter in FMP.GetImageInfo?&nbs= p; To know if that field is event valid or not.  The function in quest= ion even looks at this passed in FW image descriptor version (though the pa= rameter is called FmpVersion).  The code just sets it to 0 if the FmpV= ersion is < 3.  If one or more devices producing FMPs in the system= do not support FW image descriptor 3 or later, then this will cause an ASS= ERT.

Thanks,
SWig --omBM6jda7MKZeqcj5327--