From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Chiu, Chasel <chasel.chiu@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.
Date: Sat, 18 Mar 2023 15:06:22 -0700 [thread overview]
Message-ID: <11561.1679177182773635574@groups.io> (raw)
In-Reply-To: <20230317172050.1228-1-chasel.chiu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 137 bytes --]
Hi Chasel,
If you want to improve the ASM further, maybe opt for “test reg, reg” over “cmp reg, 0”?
Best regards,
Marvin
[-- Attachment #2: Type: text/html, Size: 173 bytes --]
next prev parent reply other threads:[~2023-03-18 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 17:20 [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings Chiu, Chasel
2023-03-18 13:04 ` [edk2-devel] " Ashraf Ali S
2023-03-18 22:07 ` Marvin Häuser
2023-03-19 9:07 ` Ashraf Ali S
2023-03-19 9:36 ` Marvin Häuser
2023-03-19 16:57 ` Ashraf Ali S
2023-03-18 22:06 ` Marvin Häuser [this message]
2023-03-20 6:03 ` Ni, Ray
2023-03-20 7:31 ` Pedro Falcato
2023-03-21 23:05 ` Nate DeSimone
2023-03-22 0:17 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11561.1679177182773635574@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox