public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE
@ 2021-04-30 19:40 Heinrich Schuchardt
  2021-05-11 21:37 ` [edk2-devel] " Samer El-Haj-Mahmoud
  2021-08-03 15:38 ` Samer El-Haj-Mahmoud
  0 siblings, 2 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-04-30 19:40 UTC (permalink / raw)
  To: EDK II Development
  Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
	Samer El-Haj-Mahmoud, Heinrich Schuchardt

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2284

EFI_MEMORY_TYPE is an enum. SctPrint expects an UINTN when printing with
%d. Add missing conversions in MemoryAllocationServicesBBTestFunction.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../MemoryAllocationServicesBBTestFunction.c  | 98 +++++++++----------
 1 file changed, 49 insertions(+), 49 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
index bf8cd3b3afa4..e545b3cfc5b8 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
@@ -417,7 +417,7 @@ BBTestAllocatePagesInterfaceTest (
                      (UINTN)__LINE__,
                      Status,
                      TplArray[Index],
-                     AllocatePagesMemoryType[TypeIndex]
+                     (UINTN)AllocatePagesMemoryType[TypeIndex]
                      );
       if (!(Memory & EFI_PAGE_MASK)) {
         AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -437,7 +437,7 @@ BBTestAllocatePagesInterfaceTest (
                      __FILE__,
                      (UINTN)__LINE__,
                      TplArray[Index],
-                     AllocatePagesMemoryType[TypeIndex]
+                     (UINTN)AllocatePagesMemoryType[TypeIndex]
                      );
       if (Memory != 0) {
         Status = gtBS->FreePages (
@@ -455,7 +455,7 @@ BBTestAllocatePagesInterfaceTest (
                          (UINTN)__LINE__,
                          Status,
                          TplArray[Index],
-                         AllocatePagesMemoryType[TypeIndex]
+                         (UINTN)AllocatePagesMemoryType[TypeIndex]
                          );
         }
       }
@@ -478,7 +478,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -512,7 +512,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -532,7 +532,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory <= Descriptor.PhysicalStart +
              SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) -
@@ -554,7 +554,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex],
+                       (UINTN)AllocatePagesMemoryType[TypeIndex],
                        Descriptor.PhysicalStart,
                        Descriptor.NumberOfPages,
                        Memory
@@ -589,7 +589,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory2 & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -609,7 +609,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if ( Memory2 <= Descriptor.PhysicalStart +
              SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) -
@@ -631,7 +631,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex],
+                       (UINTN)AllocatePagesMemoryType[TypeIndex],
                        Memory2
                        );
         if (Memory != 0) {
@@ -650,7 +650,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -670,7 +670,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -694,7 +694,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -739,7 +739,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -759,7 +759,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -779,7 +779,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -797,7 +797,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -824,7 +824,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -869,7 +869,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -889,7 +889,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -909,7 +909,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -927,7 +927,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -947,7 +947,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -992,7 +992,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1012,7 +1012,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start + (SctLShiftU64 (PageNum/3, EFI_PAGE_SHIFT) & 0xFFFFFFFFFFFF0000)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1032,7 +1032,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -1050,7 +1050,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -1070,7 +1070,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -1115,7 +1115,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1135,7 +1135,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start + (SctLShiftU64 (PageNum * 2 / 3, EFI_PAGE_SHIFT) & 0xFFFFFFFFFFFF0000)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1155,7 +1155,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -1173,7 +1173,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -1200,7 +1200,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -1245,7 +1245,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1265,7 +1265,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1285,7 +1285,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -1303,7 +1303,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -1323,7 +1323,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -1377,7 +1377,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1397,7 +1397,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1417,7 +1417,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           if (PageNum != 1) {
@@ -1442,7 +1442,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -1462,7 +1462,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
       } else {
         PageNum = (UINTN)Descriptor.NumberOfPages;
@@ -1507,7 +1507,7 @@ BBTestAllocatePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (!(Memory & EFI_PAGE_MASK)) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1527,7 +1527,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory == Start) {
           AssertionType = EFI_TEST_ASSERTION_PASSED;
@@ -1547,7 +1547,7 @@ BBTestAllocatePagesInterfaceTest (
                        __FILE__,
                        (UINTN)__LINE__,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         if (Memory != 0) {
           Status = gtBS->FreePages (
@@ -1565,7 +1565,7 @@ BBTestAllocatePagesInterfaceTest (
                            (UINTN)__LINE__,
                            Status,
                            TplArray[Index],
-                           AllocatePagesMemoryType[TypeIndex]
+                           (UINTN)AllocatePagesMemoryType[TypeIndex]
                            );
           }
         }
@@ -1656,7 +1656,7 @@ BBTestFreePagesInterfaceTest (
                        (UINTN)__LINE__,
                        Status,
                        TplArray[Index],
-                       AllocatePagesMemoryType[TypeIndex]
+                       (UINTN)AllocatePagesMemoryType[TypeIndex]
                        );
         continue;
       }
@@ -1685,7 +1685,7 @@ BBTestFreePagesInterfaceTest (
                      (UINTN)__LINE__,
                      Status,
                      TplArray[Index],
-                     AllocatePagesMemoryType[TypeIndex]
+                     (UINTN)AllocatePagesMemoryType[TypeIndex]
                      );
     }

--
2.30.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE
  2021-04-30 19:40 [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE Heinrich Schuchardt
@ 2021-05-11 21:37 ` Samer El-Haj-Mahmoud
  2021-07-09 11:50   ` G Edhaya Chandran
  2021-08-03 15:38 ` Samer El-Haj-Mahmoud
  1 sibling, 1 reply; 5+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-05-11 21:37 UTC (permalink / raw)
  To: devel@edk2.groups.io, xypron.glpk@gmx.de
  Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
	Samer El-Haj-Mahmoud

Thanks!!

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich
> Schuchardt via groups.io
> Sent: Friday, April 30, 2021 3:40 PM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print
> code for EFI_MEMORY_TYPE
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2284
>
> EFI_MEMORY_TYPE is an enum. SctPrint expects an UINTN when printing
> with %d. Add missing conversions in
> MemoryAllocationServicesBBTestFunction.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  .../MemoryAllocationServicesBBTestFunction.c  | 98 +++++++++----------
>  1 file changed, 49 insertions(+), 49 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c
> index bf8cd3b3afa4..e545b3cfc5b8 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/Blac
> kBoxTest/MemoryAllocationServicesBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationSer
> +++ vices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> @@ -417,7 +417,7 @@ BBTestAllocatePagesInterfaceTest (
>                       (UINTN)__LINE__,
>                       Status,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>        if (!(Memory & EFI_PAGE_MASK)) {
>          AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -437,7 +437,7 @@
> BBTestAllocatePagesInterfaceTest (
>                       __FILE__,
>                       (UINTN)__LINE__,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>        if (Memory != 0) {
>          Status = gtBS->FreePages (
> @@ -455,7 +455,7 @@ BBTestAllocatePagesInterfaceTest (
>                           (UINTN)__LINE__,
>                           Status,
>                           TplArray[Index],
> -                         AllocatePagesMemoryType[TypeIndex]
> +                         (UINTN)AllocatePagesMemoryType[TypeIndex]
>                           );
>          }
>        }
> @@ -478,7 +478,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -512,7 +512,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -532,7 +532,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory <= Descriptor.PhysicalStart +
>               SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) - @@ -
> 554,7 +554,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex],
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex],
>                         Descriptor.PhysicalStart,
>                         Descriptor.NumberOfPages,
>                         Memory
> @@ -589,7 +589,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory2 & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -609,7 +609,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if ( Memory2 <= Descriptor.PhysicalStart +
>               SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) - @@ -
> 631,7 +631,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex],
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex],
>                         Memory2
>                         );
>          if (Memory != 0) {
> @@ -650,7 +650,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -670,7 +670,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -694,7 +694,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -739,7 +739,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -759,7 +759,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -779,7 +779,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -797,7 +797,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -824,7 +824,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -869,7 +869,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -889,7 +889,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -909,7 +909,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -927,7 +927,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -947,7 +947,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -992,7 +992,7 @@
> BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1012,7 +1012,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start + (SctLShiftU64 (PageNum/3, EFI_PAGE_SHIFT) &
> 0xFFFFFFFFFFFF0000)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1032,7 +1032,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1050,7 +1050,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1070,7 +1070,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -1115,7 +1115,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1135,7 +1135,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start + (SctLShiftU64 (PageNum * 2 / 3, EFI_PAGE_SHIFT)
> & 0xFFFFFFFFFFFF0000)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1155,7 +1155,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1173,7 +1173,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1200,7 +1200,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -1245,7 +1245,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1265,7 +1265,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1285,7 +1285,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1303,7 +1303,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1323,7 +1323,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -1377,7 +1377,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1397,7 +1397,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1417,7 +1417,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            if (PageNum != 1) {
> @@ -1442,7 +1442,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1462,7 +1462,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages; @@ -1507,7 +1507,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1527,7 +1527,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED; @@ -1547,7 +1547,7
> @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1565,7 +1565,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1656,7 +1656,7 @@ BBTestFreePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          continue;
>        }
> @@ -1685,7 +1685,7 @@ BBTestFreePagesInterfaceTest (
>                       (UINTN)__LINE__,
>                       Status,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>      }
>
> --
> 2.30.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#74678): https://edk2.groups.io/g/devel/message/74678
> Mute This Topic: https://groups.io/mt/82490304/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud@arm.com] -=-=-=-=-=-=
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE
  2021-05-11 21:37 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-07-09 11:50   ` G Edhaya Chandran
  0 siblings, 0 replies; 5+ messages in thread
From: G Edhaya Chandran @ 2021-07-09 11:50 UTC (permalink / raw)
  To: Samer El-Haj-Mahmoud, devel

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]

Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>

[-- Attachment #2: Type: text/html, Size: 63 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE
  2021-04-30 19:40 [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE Heinrich Schuchardt
  2021-05-11 21:37 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-08-03 15:38 ` Samer El-Haj-Mahmoud
  2021-09-07  8:33   ` G Edhaya Chandran
  1 sibling, 1 reply; 5+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-08-03 15:38 UTC (permalink / raw)
  To: devel@edk2.groups.io, xypron.glpk@gmx.de
  Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
	Samer El-Haj-Mahmoud

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich
> Schuchardt via groups.io
> Sent: Friday, April 30, 2021 3:40 PM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code
> for EFI_MEMORY_TYPE
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2284
>
> EFI_MEMORY_TYPE is an enum. SctPrint expects an UINTN when printing with
> %d. Add missing conversions in MemoryAllocationServicesBBTestFunction.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  .../MemoryAllocationServicesBBTestFunction.c  | 98 +++++++++----------
>  1 file changed, 49 insertions(+), 49 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackB
> oxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackB
> oxTest/MemoryAllocationServicesBBTestFunction.c
> index bf8cd3b3afa4..e545b3cfc5b8 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackB
> oxTest/MemoryAllocationServicesBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackB
> oxTest/MemoryAllocationServicesBBTestFunction.c
> @@ -417,7 +417,7 @@ BBTestAllocatePagesInterfaceTest (
>                       (UINTN)__LINE__,
>                       Status,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>        if (!(Memory & EFI_PAGE_MASK)) {
>          AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -437,7 +437,7 @@ BBTestAllocatePagesInterfaceTest (
>                       __FILE__,
>                       (UINTN)__LINE__,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>        if (Memory != 0) {
>          Status = gtBS->FreePages (
> @@ -455,7 +455,7 @@ BBTestAllocatePagesInterfaceTest (
>                           (UINTN)__LINE__,
>                           Status,
>                           TplArray[Index],
> -                         AllocatePagesMemoryType[TypeIndex]
> +                         (UINTN)AllocatePagesMemoryType[TypeIndex]
>                           );
>          }
>        }
> @@ -478,7 +478,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -512,7 +512,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -532,7 +532,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory <= Descriptor.PhysicalStart +
>               SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) -
> @@ -554,7 +554,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex],
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex],
>                         Descriptor.PhysicalStart,
>                         Descriptor.NumberOfPages,
>                         Memory
> @@ -589,7 +589,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory2 & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -609,7 +609,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if ( Memory2 <= Descriptor.PhysicalStart +
>               SctLShiftU64 (Descriptor.NumberOfPages, EFI_PAGE_SHIFT) -
> @@ -631,7 +631,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex],
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex],
>                         Memory2
>                         );
>          if (Memory != 0) {
> @@ -650,7 +650,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -670,7 +670,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -694,7 +694,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -739,7 +739,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -759,7 +759,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -779,7 +779,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -797,7 +797,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -824,7 +824,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -869,7 +869,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -889,7 +889,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -909,7 +909,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -927,7 +927,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -947,7 +947,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -992,7 +992,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1012,7 +1012,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start + (SctLShiftU64 (PageNum/3, EFI_PAGE_SHIFT) &
> 0xFFFFFFFFFFFF0000)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1032,7 +1032,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1050,7 +1050,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1070,7 +1070,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -1115,7 +1115,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1135,7 +1135,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start + (SctLShiftU64 (PageNum * 2 / 3, EFI_PAGE_SHIFT) &
> 0xFFFFFFFFFFFF0000)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1155,7 +1155,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1173,7 +1173,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1200,7 +1200,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -1245,7 +1245,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1265,7 +1265,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1285,7 +1285,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1303,7 +1303,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1323,7 +1323,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -1377,7 +1377,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1397,7 +1397,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1417,7 +1417,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            if (PageNum != 1) {
> @@ -1442,7 +1442,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1462,7 +1462,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>        } else {
>          PageNum = (UINTN)Descriptor.NumberOfPages;
> @@ -1507,7 +1507,7 @@ BBTestAllocatePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (!(Memory & EFI_PAGE_MASK)) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1527,7 +1527,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory == Start) {
>            AssertionType = EFI_TEST_ASSERTION_PASSED;
> @@ -1547,7 +1547,7 @@ BBTestAllocatePagesInterfaceTest (
>                         __FILE__,
>                         (UINTN)__LINE__,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          if (Memory != 0) {
>            Status = gtBS->FreePages (
> @@ -1565,7 +1565,7 @@ BBTestAllocatePagesInterfaceTest (
>                             (UINTN)__LINE__,
>                             Status,
>                             TplArray[Index],
> -                           AllocatePagesMemoryType[TypeIndex]
> +                           (UINTN)AllocatePagesMemoryType[TypeIndex]
>                             );
>            }
>          }
> @@ -1656,7 +1656,7 @@ BBTestFreePagesInterfaceTest (
>                         (UINTN)__LINE__,
>                         Status,
>                         TplArray[Index],
> -                       AllocatePagesMemoryType[TypeIndex]
> +                       (UINTN)AllocatePagesMemoryType[TypeIndex]
>                         );
>          continue;
>        }
> @@ -1685,7 +1685,7 @@ BBTestFreePagesInterfaceTest (
>                       (UINTN)__LINE__,
>                       Status,
>                       TplArray[Index],
> -                     AllocatePagesMemoryType[TypeIndex]
> +                     (UINTN)AllocatePagesMemoryType[TypeIndex]
>                       );
>      }
>
> --
> 2.30.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#74678): https://edk2.groups.io/g/devel/message/74678
> Mute This Topic: https://groups.io/mt/82490304/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud@arm.com]
> -=-=-=-=-=-=
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE
  2021-08-03 15:38 ` Samer El-Haj-Mahmoud
@ 2021-09-07  8:33   ` G Edhaya Chandran
  0 siblings, 0 replies; 5+ messages in thread
From: G Edhaya Chandran @ 2021-09-07  8:33 UTC (permalink / raw)
  To: Samer El-Haj-Mahmoud, devel

[-- Attachment #1: Type: text/plain, Size: 87 bytes --]

The patch is upstreamed through commit id : 1abfd7a6e48eab8c1434dd657c7864aaf6ed7a11

[-- Attachment #2: Type: text/html, Size: 91 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-07  8:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-30 19:40 [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE Heinrich Schuchardt
2021-05-11 21:37 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-07-09 11:50   ` G Edhaya Chandran
2021-08-03 15:38 ` Samer El-Haj-Mahmoud
2021-09-07  8:33   ` G Edhaya Chandran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox