From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 66E3A2095DE5A
 for <edk2-devel@lists.01.org>; Thu, 10 Aug 2017 12:45:13 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 917AB144033;
 Thu, 10 Aug 2017 19:47:32 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 917AB144033
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com;
 spf=fail smtp.mailfrom=lersek@redhat.com
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-96.phx2.redhat.com
 [10.3.116.96])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 280C360F8C;
 Thu, 10 Aug 2017 19:47:30 +0000 (UTC)
To: Brijesh Singh <brijesh.singh@amd.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Tom Lendacky <thomas.lendacky@amd.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <1502107139-412-1-git-send-email-brijesh.singh@amd.com>
 <1502107139-412-4-git-send-email-brijesh.singh@amd.com>
 <3a8ede72-03f0-5627-f680-72f41da588e9@redhat.com>
 <4e2203d0-ae4a-67ae-2f1b-9d1908010b3d@amd.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <117a4814-7088-dd00-b3ff-64b40c218cc0@redhat.com>
Date: Thu, 10 Aug 2017 21:47:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <4e2203d0-ae4a-67ae-2f1b-9d1908010b3d@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Thu, 10 Aug 2017 19:47:32 +0000 (UTC)
Subject: Re: [PATCH v1 03/14] OvmfPkg/VirtioPciDeviceDxe: Implement new member functions
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Aug 2017 19:45:13 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/10/17 20:41, Brijesh Singh wrote:
> Hi Laszlo,
> 
> On 08/09/2017 12:09 PM, Laszlo Ersek wrote:
> [Snip]
> 
>>
>>> +
>>> +EFI_STATUS
>>> +EFIAPI
>>> +VirtioPciUnmapSharedBuffer (
>>> +  VIRTIO_DEVICE_PROTOCOL    *This,
>>> +  VOID                      *Mapping
>>> +  )
>>> +{
>>> +  return EFI_SUCCESS;
>>> +}
>>>
>>
>> (9) Please refresh the function signatures in both "VirtioPciDevice.h"
>> and "VirtioPciFunctions.c", from the protocol definition in
>> "OvmfPkg/Include/Protocol/VirtioDevice.h".
>>
>> In particular, all the IN and OUT decoration is missing here.
> 
> I see that several functions defined in VirtioPciDevice.h is missing IN
> and OUT,

Ouch, you are right!

> do you want me to send a separate patch to fix that too ?

That would be very kind of you.

Thanks!
Laszlo