From: "Rebecca Cran" <rebecca@bsdio.com>
To: Yuwei Chen <yuwei.chen@intel.com>, devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>, Bob Feng <bob.c.feng@intel.com>
Subject: Re: [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file
Date: Fri, 9 Jun 2023 19:04:00 -0600 [thread overview]
Message-ID: <117dda45-f4e3-b4be-aa91-a1ed08e6b40f@bsdio.com> (raw)
In-Reply-To: <20230605081235.1991-1-yuwei.chen@intel.com>
That won't work on Unix, where the separator is ':', not ';'.
--
Rebecca Cran
On 6/5/23 02:12, Yuwei Chen wrote:
> Currently, Python FMMT tool does not support automatically
> select FMMTConf.ini file which saves GuidTool settings.
> This patch support this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709bc8..671d77c47de9 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
> if os.environ['FmmtConfPath']:
> self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
> else:
> - PathList = os.environ['PATH']
> + PathList = os.environ['PATH'].split(';')
> for CurrentPath in PathList:
> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')
next prev parent reply other threads:[~2023-06-10 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 8:12 [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file Yuwei Chen
2023-06-10 1:04 ` Rebecca Cran [this message]
2023-06-21 12:12 ` [edk2-devel] " Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117dda45-f4e3-b4be-aa91-a1ed08e6b40f@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox