[PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file

[PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file

[Yuwei Chen]

Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
index a25681709bc8..671d77c47de9 100644
--- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
+++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
@@ -110,7 +110,7 @@ class GUIDTools:
         if os.environ['FmmtConfPath']:
             self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
         else:
-            PathList = os.environ['PATH']
+            PathList = os.environ['PATH'].split(';')
             for CurrentPath in PathList:
                 if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
                     self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')
-- 
2.27.0.windows.1

Re: [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file

[Rebecca Cran]

That won't work on Unix, where the separator is ':', not ';'.


-- 

Rebecca Cran


On 6/5/23 02:12, Yuwei Chen wrote:
> Currently, Python FMMT tool does not support automatically
> select FMMTConf.ini file which saves GuidTool settings.
> This patch support this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
>   BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709bc8..671d77c47de9 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
>           if os.environ['FmmtConfPath']:
>               self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
>           else:
> -            PathList = os.environ['PATH']
> +            PathList = os.environ['PATH'].split(';')
>               for CurrentPath in PathList:
>                   if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
>                       self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')

Re: [edk2-devel] [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file

[Yuwei Chen]

Hi Rebecca,

Thanks for reminder. Will update the patch later.

Thanks,
Christine

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Saturday, June 10, 2023 9:04 AM
> To: Chen, Christine <yuwei.chen@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C
> <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select
> Config file
> 
> That won't work on Unix, where the separator is ':', not ';'.
> 
> 
> --
> 
> Rebecca Cran
> 
> 
> On 6/5/23 02:12, Yuwei Chen wrote:
> > Currently, Python FMMT tool does not support automatically select
> > FMMTConf.ini file which saves GuidTool settings.
> > This patch support this features.
> >
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> > ---
> >   BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > index a25681709bc8..671d77c47de9 100644
> > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > @@ -110,7 +110,7 @@ class GUIDTools:
> >           if os.environ['FmmtConfPath']:
> >               self.tooldef_file = os.path.join(os.environ['FmmtConfPath'],
> 'FmmtConf.ini')
> >           else:
> > -            PathList = os.environ['PATH']
> > +            PathList = os.environ['PATH'].split(';')
> >               for CurrentPath in PathList:
> >                   if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
> >                       self.tooldef_file = os.path.join(CurrentPath,
> > 'FmmtConf.ini')
> 
> 
> 
>