From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5415EAC0988 for ; Tue, 9 Jan 2024 02:14:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SjmmRfIvrpZaytClRmgUf/pWoOnRWuSJmZo+dHbXeZM=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1704766442; v=1; b=HfKHBaxt65sRBLisPBzEcMK7leaHZF0+2BY6rA6x4b+Gjz7MFhj7mmNpmB2R+eotp2+VubaV PQ70IUG9UvHYbi4kzw1aStQ3wFvyCCj/arPFljYmIeyLTq1+ZtD0d9kfFbwCpnsPuf6P8u4O/Na sonPYlt2Lt9vzkQryaWKuUNI= X-Received: by 127.0.0.2 with SMTP id 7MM8YY7687511xZadsGoKhya; Mon, 08 Jan 2024 18:14:02 -0800 Subject: Re: [edk2-devel] [PATCH v10 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: yorange ,devel@edk2.groups.io From: "yorange" X-Originating-Location: Chengdu, Sichuan, CN (125.69.92.252) X-Originating-Platform: Windows Chrome 120 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 08 Jan 2024 18:14:01 -0800 References: <17828.1704727587183697949@groups.io> In-Reply-To: <17828.1704727587183697949@groups.io> Message-ID: <11840.1704766441420641451@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yangcheng.work@foxmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TqEasafJOePA7lpAkc25VMiHx7686176AA= Content-Type: multipart/alternative; boundary="dVACkiGmFuiiUbkwPbuM" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HfKHBaxt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=foxmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --dVACkiGmFuiiUbkwPbuM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Dhaval, I can understand a little bit why ASSERT is used=EF=BC=8CIf we can determin= e that Riscv's BaseCacheMaintenanceLib needs to depend on the CMO instructi= on set, then RISCV processor platforms that do not have the CMO instruction= set should not use this library. They should use BaseCacheMaintenanceLibNu= ll or other libraries instead. In fact, like the DwEmmcDxe driver I use on = VisionFive2, doing nothing when it comes to Cache management will have no e= ffect. . . However, we may be able to add some DEBUG information before ASSERT to prom= pt developers to use the correct Cache management library. After all, many = RISCV platforms use BaseCacheMaintenanceLib that previously only printed in= formation that RISC-V unsupported function. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113417): https://edk2.groups.io/g/devel/message/113417 Mute This Topic: https://groups.io/mt/103150435/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --dVACkiGmFuiiUbkwPbuM Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Dhaval,
I can understand a little bit why ASSERT is used=EF=BC=8CIf= we can determine that Riscv's BaseCacheMaintenanceLib needs to depend on t= he CMO instruction set, then RISCV processor platforms that do not have the= CMO instruction set should not use this library. They should use BaseCache= MaintenanceLibNull or other libraries instead. In fact, like the DwEmmcDxe = driver I use on VisionFive2, doing nothing when it comes to Cache managemen= t will have no effect. . .
However, we may be able to add some DEBUG i= nformation before ASSERT to prompt developers to use the correct Cache mana= gement library. After all, many RISCV platforms use BaseCacheMaintenanceLib= that previously only printed information that RISC-V unsupported function.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113417) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--dVACkiGmFuiiUbkwPbuM--