From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0063.outbound.protection.outlook.com [104.47.36.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A8502095B9E6 for ; Wed, 23 Aug 2017 13:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iy56fkeYH72RyR9Yd6zekMPvI2CJvk1wvMjvaZFxRLU=; b=raNEWuxaquPc0n6t+8gxyuga1rPUl/dWHwN3zeYyukHJ6JWUg4f/hZMIiIKhwGMsZoYzCAGNAR3VBNPC3hsIjU8+b7VFqe6cZ4YMeHPwTleb4kYnKWSpKJzFA/yO1pSIfQNplqEvRRIHITzUPX6iP0/NVTCrprp0ZzQGhUEVfZY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 23 Aug 2017 20:50:35 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1503490967-5559-1-git-send-email-brijesh.singh@amd.com> <1503490967-5559-8-git-send-email-brijesh.singh@amd.com> <9713645a-bfc0-0dc9-c11b-0b154265c941@redhat.com> <83cf4f23-e569-d87a-b07b-795f0cf5319d@redhat.com> From: Brijesh Singh Message-ID: <1189aa4d-26c1-4042-eef5-503812a86704@amd.com> Date: Wed, 23 Aug 2017 15:50:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <83cf4f23-e569-d87a-b07b-795f0cf5319d@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR12CA0037.namprd12.prod.outlook.com (10.172.49.23) To BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b45a62a-ce33-4082-777f-08d4ea689b20 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR12MB0147; X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 3:IlkkEt2tuKbJHp25s9U5JDc5Kzhi/sY4O3fa7uMFstel+baNYQ2Ocowof170/YiMrWteTR7QKOII/CTb5W+cx7J0h2tsITfT2s22WDTDFEKzjWKaNH+liCj4jnNpQVJ/N63CfkH07jJiJwiV4OtzcUPMCiwcoCv6NumBvgmf0OymosalTLnepb0TlL2e7gxQtbYGlS+0y/5eyAHhqpEIbNLd9lE/cWjk734IktYMwrhgvdqzhdNXnHIJICi/w5Hl; 25:NjtH/wpOKQdFTj2HHE9xZzxO0MA7aBYQGQnfZ5HNGvXA3iuZSswrJnoVqW0uZl5RlZPJ8fRzP7k21mgLFBucuk3QeWkR/n5mHBGUPhG6tH4ugi50sr5nFTT61SAz0crisusIE6UV+nadJR+Z2h2ZBB7N5N6dzmr41V4jYxjLf+rmRt4Uww+iRKZ07DM6t0mqJFSfWqt/IB4WmkRqPm81Zxr56YKDfjfAdUJd1a4hXNaMNvPvKRhRZ4cIQ1I72smfNTIjyMx33rcDYPyOpFp6hufynW71W3f2P6tXoElwlqQ1gs+jWK9jl9XbhRQwgBUaffyDKq6/LunUtRPC+oo2QQ==; 31:tdZP8kUvLPYezIuSMQ822Qtx1Xtc4ft1rbNUQCZFG+lJxVIPAbeJ3j8uGvgBbYUgwlXrmgFUQe5oqBgwQQy2FbJlsgADXb8WVJoseVIYzq4pAajCmsUkFrW2PZN8MChVKiOKcKu9AyqC5kB8eLqOcZgRhHZdNzmN7Re73JhiUr0oZpzSr7fYKcBc9wjFty5cC6v8O/VmA2TnFKboH+z/wHO0yAihHq/9I3R59gp05oE= X-MS-TrafficTypeDiagnostic: BY2PR12MB0147: X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:tMGmcSjdyrAzAYmtXgWPL7Da1ECd+nbrPw5Lhj136b7aMtD9cNkTxwmFV4SDoaHYZhUxqwC90pSlTzMB+vFGLLOCe5ljq9jwgDK9tJwXszGNPv5Xd2dd6WPJR+5vBQBgOME4FQnepRdORWsFwQQ0kBtT03wFq1SRpMcLF+MhzWGJWMdUB0QR/gmNAzDOO+TGJNrHk6lDzj0qqxwO0AlCvDbiLz3qW+LSpIJI1B+KUwmynqao+WBsTg+g61nlgY2I+Oi89gXF2xHDOFtwx5xJ9+19HrAnlWlq+5826HiEGvVskyeOryZK2rZMbVfH9bTWrHOCU7ANGlzfPExe/BwP/gZHA8LANUHlN57i3eH1lWhfT06UQiokSvjFAhUcyTRGEOjL9J9fNz4J/BDy/gfXkXRz+3gH9xDJzIYbymhef64+O4QeXLPstsBPNFAjtCcTAzvndKuseH7mJ/Mb4mp2I9WSNYOQKc43uVJnuxd10bMH3IYH2+qiEHmT3Z009t1m; 4:jTGBNYT8w8773MJSDUZ4FtEub3kV0XdPi5Iif6xf415o00eLubicS5Pg4ZI66QlyjlZwUnq46t1K+Knr3Wpg5dDoFq/TPk1bgCdFjlh3+XlNIAiGKoYWbsItEmZ2ZTLtBkzFWi+Qlg2hg999IeZWlGkHY5KEn2CnKksxBsIhYiQpWEiR8iZB0t2febwxernarRDEFFntarxic5uYu9Wn35rsPo8ifVYNV356ZfwRtHrLsbl1sgzMAbbE5wZmxUzb X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR12MB0147; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR12MB0147; X-Forefront-PRVS: 040866B734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(377454003)(199003)(24454002)(189002)(345774005)(68736007)(65826007)(64126003)(8676002)(31696002)(2906002)(31686004)(83506001)(6666003)(5660300001)(2950100002)(7736002)(105586002)(81156014)(478600001)(25786009)(4326008)(42186005)(86362001)(106356001)(305945005)(7350300001)(81166006)(33646002)(54906002)(90366009)(23676002)(50986999)(54356999)(65806001)(76176999)(4001350100001)(47776003)(50466002)(66066001)(6116002)(6246003)(77096006)(93886005)(101416001)(53546010)(189998001)(229853002)(3846002)(36756003)(230700001)(65956001)(53936002)(110136004)(6486002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR12MB0147; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ3OzIzOk5KZU1nR1dXb3B1SHY1WU5IYXAvNlp1ZjBh?= =?utf-8?B?YVMwby9VV09YdG1tNmp2UkNLdDVMYUtGNEV5amh1cmJTMkQrdDVGU1k2VklQ?= =?utf-8?B?Zmp5T1dsL255QkJCdDV1ZFVRMk54aWUxeGFzOWxiWFFPcU8xQzlwTjkyNE1F?= =?utf-8?B?VlRLWGJGWUVtdXlpMlBRVlErM3VNZFNlWE01Q0kxTXdaRHFTcmVJT214UE1Y?= =?utf-8?B?QlBKbEhvckxuWkwyK3ExVCtmRXVpdnZNcDNjSjJkL0pWK043R0hoQ3M5K2k5?= =?utf-8?B?ZFp3eElxdTBLSDlucVVRUnl1SnNZbkV2ajBxQUhSbHI1ZzFHcVp4L0FvWnJs?= =?utf-8?B?R3dEUnp3cUV2b21lTm1JazRDdDJrRGxYTkFVaU1YTjMwTzdoRUdzTlVqQ21l?= =?utf-8?B?SWRBUDNPZDlObUg4alNGem5Td1lkeW9aTGFGeFJiQS9UbWpUMmFsWlRMbnRF?= =?utf-8?B?WkhIYWRqVlZwMHFTTThLWUwzWllndUZyMXNsSWxKQWZIRkRFOUlvN0xrM3Nh?= =?utf-8?B?bER6V3gzcFdOSXc3OVJuaFRiTkhWb2QwczhjNzhKRzgxMDlmZjNGbllnKzhU?= =?utf-8?B?ZXh6MW03Q1VBVnU2dUU3QlkzaWxFbjNlRmpxRGZRbTVyMVM5c01FTGtRY2lJ?= =?utf-8?B?d200RlNhSGVYV3k4MWhxaXU3QXJKb3N2Q3ZMVXpNWWJPbCtKbHdQL1ZJczZ5?= =?utf-8?B?MSt1RjNBdU5xbmQ0RytkYXhQUS9XMnNhbERUdFpkL2lpWE1hQWNIaVd4SmIx?= =?utf-8?B?T3hrcXBhOWE3TWZXK0krU0h1UkpKRndvcGhqSmp5ZVFadjJHYm4zaThyVHQy?= =?utf-8?B?MXp4VHh1K1A1Tm1OVlZIeFQwMXJibGEwU2J1OVNFSEVQUnNnOHpHK0NtSFZj?= =?utf-8?B?N0JyVzY2cWRjYW5id0ZuNEVJbUV2dk84cFpuc2pYOThDb24wSFFqc0pmbUJr?= =?utf-8?B?Tk0vdjk2clJ0emZ0RG5MU3dtdHJxRXJEY2dueWZBWll6bTJyWUJKeHFBSklR?= =?utf-8?B?WXVsTXlqd0Z0VVpMWnQrRWtKR2pDMGhManN3NFBXcWR5SDNGTldwRm5UazVN?= =?utf-8?B?MEdZdnlFMmJqRnBqUjZUa2FLUldFcWtjUXo1a2pjMnEwaFd1RjNIK2NwbE9z?= =?utf-8?B?b05tblc4WnZrN1JiT3ZiYVlQWWdpMkdvMmxDS0xiQzFxaUlGbStaRi9oUDNX?= =?utf-8?B?b2RLTzdFWVo2blFoQzBsN0N6Rm0xZ0ZwVnUyc09xUkhaWTEvYzBtUFA2Nkx0?= =?utf-8?B?VTNhcXZWUHFWUUxVTlR0ZkFmMVJ0TFowS2pGdzhvYkptMERYcEpjRWt1SFZB?= =?utf-8?B?WTc5dytWY0lTVlZLUnUxc2Rtalp5eDFvZ1pmbm9RVm44VzlJY3JPTEZIL1Jo?= =?utf-8?B?cVFkNXZvaWRUR3g1dGZTQkt5RTVZeGdxMXJxWld3R05Dcm56MnVzYTN1bXRl?= =?utf-8?B?bzhpcmxtU2NuMHA0b1hHMkxrQmYvMW45RTZEZENZWEd1M21YeHBxMEpObW5k?= =?utf-8?B?ZDZ0cFR4UnVCMnFoNUV5WjZHWjBFZzhnbDgzbnltSm1ib0JiVUlvbDhGVS9M?= =?utf-8?B?MC93Ny9mR1QwZEcyd0w1YWxlUXZuQ0ZXK0lncDF3UjRnYVYzMi9yOFFvdFdM?= =?utf-8?B?YWpsa3lLMER0WVIvQ0FkdGhtb3FVRFJocWZwdHZQUG9pWVlHVUJXQ2pOMHB3?= =?utf-8?B?RDV1OXltUEtVeTFzYWJaSXZmbGp6UWVzbXJyL1QzRzlEWEVJY0plT3JuVXVY?= =?utf-8?B?VkN4VDJXUUU4UGpSRXRKT2FTYzJURWlySFI1c3FZTWpxSFNmZHN5bkYxN1M5?= =?utf-8?B?RWF5SlhhWG9wMG53K3JXaVRBRjBFOXlPcDhLZWI5R0R6cUdMY1g5UVVzbDg0?= =?utf-8?B?NVhQL2pKK04wRGZ1enExd1hZa3hNVFNoRDZ1MEU2LzJHcnUzeUZ5YjJac2RH?= =?utf-8?B?VVVPVEI4U05HWFVmaEZtTi9lZFo4eW85azF6WmpNOVl1SlRnSVZPT2FSRFp5?= =?utf-8?Q?Mw4XJ2?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 6:4R2mqUFLQ8jNIm2OukzmUInzfUpwAQzMkyBVq9woY1Dum2D2vrTkFRXXGCM8k9oa/ix1zlKGgB79+kpq2OXuC4/qdA1MAdkdgb7Uge7iyQM0J0vQtqCasqZDBlnMQ32J6LVUbQX83jbT/HEoT935fz5NaYPjVLCIo+Guqf32ovybmiRzClGXQKVeu92/KrxxVcxPwDwLyjcFy1UIQbVYa2C7EcJClL+CIY1mX3Ks0vqMMX4nDS//gu8CuUush5dUq8yJl2zWH6zCg3lqt20BUXjMyWI8qmvYyNk+wKDCPncV7dN8ugBKijn5OBGZDao5/OKBYETkAbLdOkDesz8r3w==; 5:20zKpfx9eRPxfTBhTEsnestK7l2kWVDs8wJYnuM21DjtnrCB17Z4fKeM9EsHUUNub5S8sNoAhXauh63QC6G/mj07zgMOhwNh+m7PcJaj4R4IXvQQ2MdbdgPLjgQzjBK7AT0wYvkTjw9Thg7KCj4bMw==; 24:oHYW/I+bjAeEzbezbtbTTHMjVT45wR37ohYFpAy/jOadRxCEdkFTg1Rw/eeh1zR4zxPMRzOjclJVtkNFjETPzAfLR5bVJvnwewfrU5SKrss=; 7:ThGTwUwRnWu+vW+Pf3pS8w6xXJevam6P3rFfWIxFHjBoYO3b17+1vAvk4NGPNgMNFsTq0gZ2JZpMQrwm80cyKBd4Iq22DEjNTNrEWu4e+70JvUn/urkED97rW0zyeSjmYhrscoWAUzE6ByPeN+pwVM1YZjeRwaTdtXL/Kyog4IbC6OFEF4Y52zjomDG/IE37pPyd8DczmsMId57xRzfeiSLj36Gt1fDvr5iE8HWRNF4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:CNXpfLZXtHF72F1ps8q0Zss72Enj+PaQFjYDFk8ocUvziM4x3M2e0+5Z7B3py4aP5seey/YupKJrjP0uVZ8Dr3geFSmxtWhMWHB/43mdoUDGcB6We5xLw1yXOTBOuAnBBKoIagPapjxMTlYvYM8aQ0Hhkvx2QuMIzX3INv36BaZH5RANPzOVxCHfnf5D1R6Xv9z9YaJ+YRHE5QXpOPXL/ozbJVq+/ET+9D7RP174N46bv1Ji2tKH7syvZplrfLjj X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 20:50:35.9927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0147 Subject: Re: [PATCH v3 07/23] OvmfPkg/Virtio: take RingBaseShift in SetQueueAddress() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 20:48:05 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/23/2017 03:43 PM, Laszlo Ersek wrote: > On 08/23/17 22:41, Laszlo Ersek wrote: >> On 08/23/17 14:22, Brijesh Singh wrote: >>> For the case when an IOMMU is used for translating system physical >>> addresses to DMA bus master addresses, the transport-independent >>> virtio device drivers will be required to map their VRING areas to >>> bus addresses with VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer() calls. >>> >>> VirtioRingMap() maps the ring buffer system physical to a bus address. >>> When an IOMMU is used for translating the address then bus address can >>> start at a different offset from the system physical address. >> >> (1) The paragraph that you now have as first paragraph above was my >> suggestion, so thank you for picking it up. However, the second >> paragraph should have been deleted; I suggested the now-first paragraph >> as a replacement for the now-second one. >> >> I wrote, "to keep our references within the virtio device protocol". >> VirtioRingMap() is a VirtioLib function, which is a utility layer on top >> of the virtio device protocol. So, as I said, VirtioLib patches may >> refer to both VirtioLib and the protocol, but protocol patches should >> preferably only refer to the protocol, and not VirtioLib. >> >> VirtioLib --+ >> | ^ | >> | | | >> | +-------+ >> | >> v >> VirtioDeviceProtocol --+ >> ^ | >> | | >> +--------+ >> >> This is also consistent with the reordering of the patches that I asked >> for (and that you implemented well in v3, thank you for it). >> >> So, apologies if I wasn't clear enough of this -- it's not a big deal at >> all, I can remove the second paragraph when I push this. >> >> Reviewed-by: Laszlo Ersek >> Thanks Laszlo, Sorry I did not realize that second paragraph should have been deleted. Thanks for fixing. -Brijesh