Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI

["Pete Batard" <pete@akeo.ie>]

On 2020.07.28 22:00, Samer El-Haj-Mahmoud wrote:
> Arm SBSA specification section ver 6.0, 4.1.5 defines specific PPI
> values for certain standard interrupt IDs. The value for
> "Performance Monitors Interrupt" needs to be 23.
> 
> REF: https://developer.arm.com/documentation/den0029/latest
> 
> This partially fixes SBSA test #11 ("Incorrect PPI value") reported in
> https://github.com/pftf/RPi4/issues/74
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c481c3534263..00683afe96b9 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -433,10 +433,10 @@ [PcdsFixedAtBuild.common]
>     gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceHBase|0xFF844000
>     gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceVBase|0xFF846000
>     gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19
> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30
> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31
> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32
> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33
> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23
> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23
> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23
> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23
>   
>     #
>     # Fixed CPU settings.
> 

Reviewed-by: Pete Batard <pete@akeo.ie>