From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.14059.1596182119459152619 for ; Fri, 31 Jul 2020 00:55:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=P2TDfpcC; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.68, mailfrom: pete@akeo.ie) Received: by mail-wr1-f68.google.com with SMTP id 88so27084302wrh.3 for ; Fri, 31 Jul 2020 00:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yp0w7Gub2lOAuKQXJlSMbWm8CXi4j5cTnmcobuSQM/0=; b=P2TDfpcC11V0BmSl8C+2VxkojxufTzOy1nW2qOb2k7Y0xqCUQxGOwYRkAE1clnEsFp RduazWg/dkNr4kJTxgHTEJGbhj/FxD7X/G2QCA2TaOSogBCYDOaJFvFKkQydUPLunuFZ /lc7wO2DPskdGOFcYolY3NjkuSHMiMp/N5t3W9h4iwT1ey3n+Y5cr6AiyxdHHfL7Yv4N uEX8s7+2jzuZVwfL1ng3Q9H+Yzf9iPZepQbISfa+ot6P6wz8Wj/gyZcT7r6mVO+0Fp1B dnSEt3HUL7V3Two57NFMTe/dpz9NpDcbZPEJSbcBSCUamTqFUaQGhyR9n4BE2sHYSxk8 /PTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yp0w7Gub2lOAuKQXJlSMbWm8CXi4j5cTnmcobuSQM/0=; b=JkRrBAPL7nN7Hhmla+4EVlRXjUTwMh/ubcRL+xBHkvJO2FsiR4WDK//h45ot88tXmf UPZ/ZT1+epZVgkRYhwNGpUpZMyQs6vgRxitb3H/97cn7+JCnDk7ZY6WzMGx2nQny1ZXC 2BYPtzK33RJ9zMRYSusWzGk9//eIjphGwp9Hxcoy7EBmxJEsoIXfYWzDvDZaSNu/Lbm8 zsg6Ho31ZzYMj1oLR3mcmrtVuMyolDnBSJVI6/Tn0vtSGLO/8CvY0WI7UPT3WpHTdNYQ LQaHCl9/6fkwVGFBdJoa0dryqFTHxtu4OxksMk7R3OscgT9pqM8ZNFyaFv8exvEJkF6a /0vA== X-Gm-Message-State: AOAM530k758OGXHjy+XSm1NKwi+Rlb7Dng0NTh8Ya6mBplWdtz65UQoE oKKpSGptiOGxFTYIjUgZMXg42w== X-Google-Smtp-Source: ABdhPJzW8AgRUU3g9/tM9+I6/QDKAh2A/sL7rHSGaWyYhsstnu80V0cYCI+iL59uqt31z+Ql6UlGlw== X-Received: by 2002:a5d:4610:: with SMTP id t16mr2417414wrq.101.1596182118108; Fri, 31 Jul 2020 00:55:18 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.94.233]) by smtp.googlemail.com with ESMTPSA id a3sm12220322wme.34.2020.07.31.00.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 00:55:17 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin , Ard Biesheuvel References: <20200728210028.6024-1-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: <118c0e2d-94b3-a212-607b-49765f21e77f@akeo.ie> Date: Fri, 31 Jul 2020 08:55:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200728210028.6024-1-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.07.28 22:00, Samer El-Haj-Mahmoud wrote: > Arm SBSA specification section ver 6.0, 4.1.5 defines specific PPI > values for certain standard interrupt IDs. The value for > "Performance Monitors Interrupt" needs to be 23. > > REF: https://developer.arm.com/documentation/den0029/latest > > This partially fixes SBSA test #11 ("Incorrect PPI value") reported in > https://github.com/pftf/RPi4/issues/74 > > Cc: Leif Lindholm > Cc: Pete Batard > Cc: Andrei Warkentin > Cc: Ard Biesheuvel > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index c481c3534263..00683afe96b9 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -433,10 +433,10 @@ [PcdsFixedAtBuild.common] > gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceHBase|0xFF844000 > gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceVBase|0xFF846000 > gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19 > - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30 > - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31 > - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32 > - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33 > + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23 > + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23 > + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23 > + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23 > > # > # Fixed CPU settings. > Reviewed-by: Pete Batard