From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in22.apple.com (mail-out22.apple.com [17.171.2.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 58A551A1E28 for ; Fri, 21 Oct 2016 13:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1477083322; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dkxaighsChXTE9lkz+3aqJoP1noEySCptS7/6N41jvU=; b=UPRTNRpGjpdkXFCoO01/iaRL0PIKLwWLKnSRyP3+bPHV6Gfjn1NUOOOgwkLEXu8z CtdnS01CJkIN23fOAGiLsEmsE+bqN1Dz/ApZI60kEPPvvROSjcY9L37Zx4pVm26u hfd2FTZ+0ClzS3LMqDEkLZGqN1ISgxQyuzHDt8CgNS4gA4CuUR1ybIsVtH11eD/q dD+83yjT9Rpz4ub90HMZRJjtPMkazxHd3z+T52a2vmD75lnMpTW/lE5L5S/jI1ah FYY6XEC7HqEsZI9f0mB+t/PigL2qss3cus1to5YgrW4jM37+pA40aWpYneWpEUy9 gMQXRyLyabBiFB3g5L35Lw==; Received: from relay25.apple.com (relay25.apple.com [17.171.128.106]) by mail-in22.apple.com (Apple Secure Mail Relay) with SMTP id 9C.6A.07187.9B08A085; Fri, 21 Oct 2016 16:55:22 -0400 (EDT) X-AuditID: 11ab0216-4b3a89a000001c13-1d-580a80ba0876 Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by relay25.apple.com (Apple SCV relay) with SMTP id 2E.00.24919.9B08A085; Fri, 21 Oct 2016 16:55:21 -0400 (EDT) MIME-version: 1.0 Received: from [17.168.156.82] by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OFF00LQ80S6L280@ma1-mmpp-sz10.apple.com>; Fri, 21 Oct 2016 13:55:21 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <11C34A9A-0CD6-49D7-8A74-E810828B5A48@apple.com> Date: Fri, 21 Oct 2016 13:55:18 -0700 In-reply-to: <7A41C43F-250B-4DCB-9193-E21FBB4BA590@apple.com> Cc: Ard Biesheuvel , edk2-devel-01 , Leif Lindholm , "Gao, Liming" , Mike Kinney , Laszlo Ersek To: Jordan Justen References: <147707992484.13791.10042868456965197315@jljusten-ivb> <147708236992.14194.656313834108120082@jljusten-ivb> <7A41C43F-250B-4DCB-9193-E21FBB4BA590@apple.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsUiuLohS3dXA1eEwdUrzBb/P+xmtNhz6Ciz xY5r/SwWn3bvYbFYdmwHi8WKexvYLTo6/jE5sHss3vOSyePOtT1sHt2z/7F4vN93lS2AJYrL JiU1J7MstUjfLoEr4/n3NpaCnluMFd8WX2NsYHy8l7GLkYNDQsBEYsp3hS5GLg4hgYOMEqdu 7mPvYuQEi79Y/IEFInGYUWL+9x9sIAleAUGJH5PvsYDYzAJhEne2X2aEKHrHKLHt4gwmkISw gLjEuzObmEFsNgFliRXzP7BDNNtInLq7jQ2ipkDi24ZXYPUsAqoSlz7PYwSxOQVsJRZ/uwe2 mVngN6PE9Z0/wLaJCOhK9C3/A3VSN7PEw9drmSB+kJWY/csLJC4h8JhN4svmk4wTGIVmIbl2 FpJrIWwtie+PWoHiHEC2vMTB87IQYU2JZ/c+sUPY2hJP3l1gXcDItopRODcxM0c3M8/ISC+x oCAnVS85P3cTIziymMR2MN57bXiIUYCDUYmHl0GMK0KINbGsuDL3EKM0B4uSOK/DSrYIIYH0 xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwOl2qfXouVUdzSGp/2ONT8WFnw1NqTXsszZHb/8flQ X3fXyTSAfffK+Z65DaXvJWoKD52d8OzpB6sN5p/2zgk35349dUXeoQ/vH+bb16rXdf7Yp384 7hob06U63yNV5TuO90VGOa3wt7FabJpoYtVi8D/oOodRUofg7ebu6Lvb/dmmR1xPn6vEUpyR aKjFXFScCABIttmejQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsUiuLphmu7OBq4Ig96r5hb/P+xmtNhz6Ciz xY5r/SwWn3bvYbFYdmwHi8WKexvYLTo6/jE5sHss3vOSyePOtT1sHt2z/7F4vN93lS2AJYrL JiU1J7MstUjfLoEr4/n3NpaCnluMFd8WX2NsYHy8l7GLkZNDQsBE4sXiDywQtpjEhXvr2boY uTiEBA4zSsz//oMNJMErICjxY/I9sCJmgTCJO9svM0IUvWOU2HZxBhNIQlhAXOLdmU3MIDab gLLEivkf2CGabSRO3d3GBlFTIPFtwyuwehYBVYlLn+eBXcEpYCux+BvIAi6gBb8ZJa7v/AG2 TURAV6Jv+R8WiG3dzBIPX68F6uYAulVWYvYvrwmMArOQHDgLyYEQtpbE90etQHEOIFte4uB5 WYiwpsSze5/YIWxtiSfvLrAuYGRbxShYlJqTWGlkqpdYUJCTqpecn7uJERIjWTsYb980O8Qo wMGoxMNbncUVIcSaWFZcmXuIUYKDWUmEd8oG9ggh3pTEyqrUovz4otKc1OJDjNIcLErivGqF QNUC6YklqdmpqQWpRTBZJg5OqQbGVO8333Yl/ud/Gs9aZMXdyv0zKfJm8AmH2olqRxWVUmW6 nu08tN9rTwt7CfukuNWP5y8NOzOpKvV1094LZyTPPiruPLS77gTLlnsrlHkfq+o7nOlz227b 7rfrsbFt67EroS+mnFZsexjy9btfko/JnLqvi0qneG22Lt369RbLSRlNnbUip+fxKLEUZyQa ajEXFScCAAWZwZGNAgAA X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 20:55:23 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Oct 21, 2016, at 1:54 PM, Andrew Fish wrote: > >> >> On Oct 21, 2016, at 1:39 PM, Jordan Justen wrote: >> >> On 2016-10-21 13:20:49, Andrew Fish wrote: >>> On Oct 21, 2016, at 12:58 PM, Jordan Justen >>> wrote: >>> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >>> >>> I don't remember seeing any discussion regarding >>> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >>> seeing these bugs being filed and assigned. >>> >>> I agree. >>> >>> Also, the terminology seems confusing. 'new deprecated' seems like a >>> contradiction. I guess it means 'newly deprecated', but that seems >>> like a term that is quickly going to become obsolete. Soon there will >>> be old deprecated items that are disabled with this switch. >>> DISABLE_DEPRECATED_INTERFACES sounds better. >>> >>> But, shouldn't we have platforms opt-in to using the deprecated >>> interfaces rather than adding DISABLE_NEW_DEPRECATED_INTERFACES to the >>> build command line for every EDK II platform? >>> >>> Not using deprecated items should be the default for EDK II platforms. >>> If a platform has to opt-in to the deprecated content in their .dsc, >>> then it is obvious that they are relying on deprecated functionality. >>> >>> So, I guess I'd propose adding ENABLE_DEPRECATED_INTERFACES instead. >>> >>> Jordan, >>> I think it depends on your point of view. If you have a platform that >>> works and you update the edk2 revision you would expect it to still work. >> >> I think this is what UDK is for. If you want to depend directly on EDK >> II, then you'll see less stability. >> > > Jordan, > > Well there should be a published plan for a future UDK that this change is going to happen before we "break it" in master. Publishing the plan with the UDK does not count :). > >>> Thus the option is to DISABLE_DEPRECATED_INTERFACES as that maintains >>> backward compatibility. >> >> In order to support UDK releases, maybe ENABLE_UDK2014_INTERFACES would be >> something to consider. Or ENABLE_UDK_INTERFACE=2014 so we can use <=. >> >> But, I still think that EDK II platforms (as a goal) should represent >> the best, cleanest examples of using EDK II. And, I think having every >> platform accumulate cruft like CFLAGS to disable deprecated interfaces >> works against that goal. >> >> Another point. What about when we want to deprecate more interfaces? >> Oh know, we better not break platforms that only specified >> DISABLE_NEW_DEPRECATED_INTERFACES! Let's add >> DISABLE_NEW_DEPRECATED_INTERFACES2! :) >> > > I think you make a very good point. How about DISABLE_2014_DEPRECATE_INTERFACES. I think that version scales, and might actually encourage cleanup as it shows when the interface first got deprecated. > Sorry, DISABLE_2014_DEPRECATED_INTERFACES. Thanks, Andrew Fish > Thanks, > > Andrew Fish > >> -Jordan >> >>> I think it makes total sense to turn on DISABLE_DEPRECATED_INTERFACES on >>> all the open source edk2 platform as soon as possible so all the open >>> source code is following current best practices. >>> Not to mention it would probably be a really good idea to give all the >>> downstream folks a long lead time about the plan of making a non backward >>> compatible change. >>> Thanks, >>> Andrew Fish >>> >>> -Jordan >>> >>> Before making any such changes, I would like a strong commitment from >>> other package owners that deprecating an interface brings along with >>> it the responsibility to update all existing callers, otherwise >>> setting this define will only result in more breakage, and ARM has >>> seen its share of inadvertent breakage in the past when changes to >>> core code were made without taking other architectures into account. >>> >>> On 21 October 2016 at 02:21, >>> wrote: >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=164 >>> >>> yonghong.zhu@intel.com changed: >>> >>> What |Removed |Added >>> ---------------------------------------------------------------------------- >>> Priority|Lowest |Normal >>> Status|UNCONFIRMED |CONFIRMED >>> Assignee|michael.d.kinney@intel.com >>> |ard.biesheuvel@linaro.org >>> Ever confirmed|0 |1 >>> Release(s) the| |EDK II Trunk >>> issues must be| | >>> fixed| | >>> >>> --- Comment #1 from yonghong.zhu@intel.com --- >>> Assign to Package owner. >>> >>> -- >>> You are receiving this mail because: >>> You are the assignee for the bug. >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel > >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel