From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A90472112386A
 for <edk2-devel@lists.01.org>; Thu,  6 Sep 2018 11:22:26 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id DB5B740676C0;
 Thu,  6 Sep 2018 18:22:25 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-62.rdu2.redhat.com
 [10.10.120.62])
 by smtp.corp.redhat.com (Postfix) with ESMTP id C07792166BA2;
 Thu,  6 Sep 2018 18:22:24 +0000 (UTC)
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Jiewen Yao <jiewen.yao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Liming Gao <liming.gao@intel.com>, Star Zeng <star.zeng@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Chao Zhang <chao.b.zhang@intel.com>
References: <20180906134523.2036-1-ard.biesheuvel@linaro.org>
 <20180906134523.2036-4-ard.biesheuvel@linaro.org>
 <22163ca3-78c7-3bbe-2fb8-453f847ed69f@redhat.com>
 <CAKv+Gu8Mia=d7NpmyT4jEocBU7YbnBzXGxTAuSjZDCJZVu2--Q@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <11a7c2d3-4a35-475f-4dc9-b67f7c881f07@redhat.com>
Date: Thu, 6 Sep 2018 20:22:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8Mia=d7NpmyT4jEocBU7YbnBzXGxTAuSjZDCJZVu2--Q@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Thu, 06 Sep 2018 18:22:25 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Thu, 06 Sep 2018 18:22:25 +0000 (UTC) for IP:'10.11.54.6'
 DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH 3/4] SecurityPkg: remove PE/COFF header workaround for ELILO on IPF
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 18:22:26 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/06/18 19:25, Ard Biesheuvel wrote:
> On 6 September 2018 at 18:47, Laszlo Ersek <lersek@redhat.com> wrote:

>> For build-testing, I suggest
>>
>>   build -p SecurityPkg/SecurityPkg.dsc ...
>>
>> It will build all SecurityPkg modules, without putting them in a flash device (FD).
>>
> 
> That is what I used to perform the build test, which completed without
> error. [...]

That's spooky! In "SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c", no
declaration of "mNtHeader" should be visible. Hm...

Arrgh, if you check "SecurityPkg/SecurityPkg.dsc", the
"SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf" file is listed *only* under

[Components.IA32, Components.X64]

Thus, assuming you built natively on AARCH64, this module was not built. :/

Jiewen, is there any particular reason for not building Tcg2Dxe on
AARCH64? Is it just "historical lack of AARCH64 test environment
providing TPM2 hardware", or something more "architectural"?

Thanks!
Laszlo