From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 24 Apr 2019 12:17:08 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E153230ADBCD; Wed, 24 Apr 2019 19:17:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-123.rdu2.redhat.com [10.10.120.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4D20600C4; Wed, 24 Apr 2019 19:17:01 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD To: devel@edk2.groups.io, philmd@redhat.com, jian.j.wang@intel.com, "rebecca@bluestop.org" , "ard.biesheuvel@linaro.org" Cc: "Ye, Ting" , Stephano Cetola References: <20190419223829.62336-1-rebecca@bluestop.org> <8544dcc5-7817-fd5a-abe1-98ee00e6400a@bluestop.org> <17b0c77c-cb9c-dbef-8101-889f2351f691@redhat.com> From: "Laszlo Ersek" Message-ID: <11affcc6-4611-ea2c-4c1b-1a1986369f45@redhat.com> Date: Wed, 24 Apr 2019 21:17:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <17b0c77c-cb9c-dbef-8101-889f2351f691@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 24 Apr 2019 19:17:08 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable +Stephano On 04/24/19 11:25, Philippe Mathieu-Daud=C3=A9 wrote: > On 4/22/19 3:46 PM, Wang, Jian J wrote: >> crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep= it in inf. >> That means we need this patch for build on FreeBSD. >> >> Reviewed-by: Jian J Wang >=20 > Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship > again: rebecca via Groups.Io And, again, that's exactly how the sender is displayed to me by Thunderbird, in my list folder only: From: Rebecca via Groups.Io Again, in email that I get directly from Rebecca, the From field looks just fine. So I don't think there's anything to fix for package maintainers here. It seems that groups.io rewrites the sender address for Rebecca. I don't know why groups.io performs this rewrite, and why only for Rebecca. Stephano -- can you please ask groups.io why it keeps changing the From header on messages sent by "Rebecca Cran "? Thanks Laszlo >=20 >> Jian >> >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> rebecca via Groups.Io >>> Sent: Sunday, April 21, 2019 1:18 AM >>> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org >>> Cc: Ye, Ting ; Gang Wei ; Wang,= Jian >>> J >>> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration= to fix >>> openssl build on FreeBSD >>> >>> On 2019-04-20 05:28, Ard Biesheuvel wrote: >>>> >>>> This is slightly odd. The host architecture shouldn't really matter, >>>> and so if we end up calling different code in UEFI when built on *BSD= , >>>> there is differently something wrong. Or am I missing something? >>> >>> >>> No, that's a good point. I guess it's something we don't ever call. >>> >>> In fact, OVMF continues to build after removing crypto/uid.c (which >>> contains the OPENSSL_issetugid definition) from >>> CryptoPkg/Library/OpensslLib/OpensslLib.inf and >>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf . >>> >>> >>> -- >>> >>> Rebecca Cran >=20 >=20 >=20