From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 399BF21BADAB2 for ; Fri, 1 Feb 2019 05:47:35 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 860187AEAC; Fri, 1 Feb 2019 13:47:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-24.rdu2.redhat.com [10.10.123.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0D2A608DA; Fri, 1 Feb 2019 13:47:26 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Shenglei Zhang , edk2-devel@lists.01.org Cc: Anthony Perard , Jordan Justen References: <20190201053445.13660-1-shenglei.zhang@intel.com> <20190201053445.13660-7-shenglei.zhang@intel.com> <90f309f1-204b-49fa-189a-4144fef9c322@redhat.com> From: Laszlo Ersek Message-ID: <11bb68ea-73ac-718e-23d8-def2c0f45db0@redhat.com> Date: Fri, 1 Feb 2019 14:47:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <90f309f1-204b-49fa-189a-4144fef9c322@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 01 Feb 2019 13:47:34 +0000 (UTC) Subject: Re: [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 13:47:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/01/19 10:50, Philippe Mathieu-Daudé wrote: > Hi, > > On 2/1/19 6:34 AM, Shenglei Zhang wrote: >> Remove content related to UNIXGCC in README. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1377 >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Anthony Perard >> Cc: Julien Grall >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Shenglei Zhang >> --- >> OvmfPkg/README | 19 ------------------- >> 1 file changed, 19 deletions(-) >> >> diff --git a/OvmfPkg/README b/OvmfPkg/README >> index 68ce0750af..c014d07bfb 100644 >> --- a/OvmfPkg/README >> +++ b/OvmfPkg/README >> @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address 0x800000. The >> remaining OVMF firmware then uses this decompressed firmware >> volume image. >> >> -=== UNIXGCC Debug === >> - >> -If you build with the UNIXGCC toolchain, then debugging will be disabled >> -due to larger image sizes being produced by the UNIXGCC toolchain. The >> -first choice recommendation is to use GCC48 or newer instead. >> - >> -If you must use UNIXGCC, then you can override the build options for >> -particular libraries and modules in the .dsc to re-enable debugging >> -selectively. For example: >> - [Components] >> - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf { >> - >> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG >> - } >> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { >> - >> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG >> - } >> - >> === UEFI Windows 7 & Windows 2008 Server === >> >> * One of the '-vga std' and '-vga qxl' QEMU options should be used. >> > > Doesn't it make sense to squash this commit with the previous one as > "OvmfPkg: Remove UNIXGCC"? Good point. Thanks Laszlo